Skip to content

Commit 2575c01

Browse files
author
maddieclayton
committed
fix based on comments
1 parent c9de84b commit 2575c01

File tree

5 files changed

+31
-28
lines changed

5 files changed

+31
-28
lines changed

‎src/ResourceManager/Common/Commands.ResourceManager.Common/ArgumentCompleters/ResourceGroupCompleter.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ protected static IList<String> ResourceGroupNames
5454

5555
if (_timeout == -1)
5656
{
57+
resourceGroups.Wait();
5758
tempResourceGroupList = CreateResourceGroupList(resourceGroups.Result);
5859
if (resourceGroups.Result != null)
5960
{

‎src/ResourceManager/Common/Commands.ResourceManager.Common/ArgumentCompleters/ResourceTypeCompleter.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ protected static IList<String> ResourceTypes
6161

6262
if (_timeout == -1)
6363
{
64+
task.Wait();
6465
page = task.Result;
6566
resourceTypes.AddRange(page);
6667
}

‎src/ResourceManager/Common/Commands.ResourceManager.Common/ArgumentCompleters/ScopeCompleter.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ protected static IList<String> Scopes
5151

5252
if (_timeout == -1)
5353
{
54+
resourceGroups.Wait();
5455
tempScopeList = CreateScopeList(resourceGroups.Result, context.Subscription.Id);
5556
_scopeDictionary[contextHash] = tempScopeList;
5657
}

‎src/ResourceManager/Profile/Commands.Profile.Test/SessionRecords/Microsoft.Azure.Commands.Profile.Test.ArgumentCompleterTests/TestLocationCompleter.json

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"RequestBody": "",
88
"RequestHeaders": {
99
"x-ms-client-request-id": [
10-
"faf02f79-046b-4fbb-ab2c-19a435671ed2"
10+
"7331acd8-9a77-405c-a2f2-0338cb47cea7"
1111
],
1212
"accept-language": [
1313
"en-US"
@@ -34,16 +34,16 @@
3434
"no-cache"
3535
],
3636
"x-ms-ratelimit-remaining-subscription-reads": [
37-
"14998"
37+
"14999"
3838
],
3939
"x-ms-request-id": [
40-
"8a39a050-09a3-4505-af19-cce9acf89b49"
40+
"f9a9e19c-0513-4477-89b4-38f359316e22"
4141
],
4242
"x-ms-correlation-request-id": [
43-
"8a39a050-09a3-4505-af19-cce9acf89b49"
43+
"f9a9e19c-0513-4477-89b4-38f359316e22"
4444
],
4545
"x-ms-routing-request-id": [
46-
"WESTUS2:20180510T233514Z:8a39a050-09a3-4505-af19-cce9acf89b49"
46+
"WESTUS2:20180510T235718Z:f9a9e19c-0513-4477-89b4-38f359316e22"
4747
],
4848
"Strict-Transport-Security": [
4949
"max-age=31536000; includeSubDomains"
@@ -55,7 +55,7 @@
5555
"no-cache"
5656
],
5757
"Date": [
58-
"Thu, 10 May 2018 23:35:13 GMT"
58+
"Thu, 10 May 2018 23:57:18 GMT"
5959
]
6060
},
6161
"StatusCode": 200
@@ -67,7 +67,7 @@
6767
"RequestBody": "",
6868
"RequestHeaders": {
6969
"x-ms-client-request-id": [
70-
"5ce658c8-79e0-4356-9c6e-3db3adfaede5"
70+
"cdb799e6-e786-4d2f-9624-c1100a30a4ca"
7171
],
7272
"accept-language": [
7373
"en-US"
@@ -94,16 +94,16 @@
9494
"no-cache"
9595
],
9696
"x-ms-ratelimit-remaining-subscription-reads": [
97-
"14998"
97+
"14999"
9898
],
9999
"x-ms-request-id": [
100-
"323d75c4-2400-41b7-868c-2a305c8d4c9e"
100+
"51161095-1850-4723-95a5-1f386c13eb7a"
101101
],
102102
"x-ms-correlation-request-id": [
103-
"323d75c4-2400-41b7-868c-2a305c8d4c9e"
103+
"51161095-1850-4723-95a5-1f386c13eb7a"
104104
],
105105
"x-ms-routing-request-id": [
106-
"WESTUS2:20180510T233515Z:323d75c4-2400-41b7-868c-2a305c8d4c9e"
106+
"WESTUS2:20180510T235720Z:51161095-1850-4723-95a5-1f386c13eb7a"
107107
],
108108
"Strict-Transport-Security": [
109109
"max-age=31536000; includeSubDomains"
@@ -115,7 +115,7 @@
115115
"no-cache"
116116
],
117117
"Date": [
118-
"Thu, 10 May 2018 23:35:15 GMT"
118+
"Thu, 10 May 2018 23:57:20 GMT"
119119
]
120120
},
121121
"StatusCode": 200
@@ -127,7 +127,7 @@
127127
"RequestBody": "",
128128
"RequestHeaders": {
129129
"x-ms-client-request-id": [
130-
"936e4274-0433-4519-a6d0-6bbd289efc90"
130+
"973a0082-232b-49bb-bbc4-7f5412ee5f67"
131131
],
132132
"accept-language": [
133133
"en-US"
@@ -154,16 +154,16 @@
154154
"no-cache"
155155
],
156156
"x-ms-ratelimit-remaining-subscription-reads": [
157-
"14997"
157+
"14998"
158158
],
159159
"x-ms-request-id": [
160-
"051d74d1-68a3-4510-a1a9-69f499ad4243"
160+
"904f3ebb-bbe4-4d1f-9509-fffbc256e699"
161161
],
162162
"x-ms-correlation-request-id": [
163-
"051d74d1-68a3-4510-a1a9-69f499ad4243"
163+
"904f3ebb-bbe4-4d1f-9509-fffbc256e699"
164164
],
165165
"x-ms-routing-request-id": [
166-
"WESTUS2:20180510T233516Z:051d74d1-68a3-4510-a1a9-69f499ad4243"
166+
"WESTUS2:20180510T235721Z:904f3ebb-bbe4-4d1f-9509-fffbc256e699"
167167
],
168168
"Strict-Transport-Security": [
169169
"max-age=31536000; includeSubDomains"
@@ -175,7 +175,7 @@
175175
"no-cache"
176176
],
177177
"Date": [
178-
"Thu, 10 May 2018 23:35:16 GMT"
178+
"Thu, 10 May 2018 23:57:21 GMT"
179179
]
180180
},
181181
"StatusCode": 200

‎src/ResourceManager/Profile/Commands.Profile.Test/SessionRecords/Microsoft.Azure.Commands.Profile.Test.ArgumentCompleterTests/TestResourceGroupCompleter.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"RequestBody": "",
88
"RequestHeaders": {
99
"x-ms-client-request-id": [
10-
"e284ab97-a26c-4e7a-99ec-5fe860f82b9b"
10+
"f488f674-38d7-4a88-b653-f811c12e3e97"
1111
],
1212
"accept-language": [
1313
"en-US"
@@ -37,13 +37,13 @@
3737
"14999"
3838
],
3939
"x-ms-request-id": [
40-
"c317aae8-acac-47e0-8101-0897713b22c7"
40+
"541e8036-5f61-4f32-b5bb-62ded792b463"
4141
],
4242
"x-ms-correlation-request-id": [
43-
"c317aae8-acac-47e0-8101-0897713b22c7"
43+
"541e8036-5f61-4f32-b5bb-62ded792b463"
4444
],
4545
"x-ms-routing-request-id": [
46-
"WESTUS2:20180510T233406Z:c317aae8-acac-47e0-8101-0897713b22c7"
46+
"WESTUS2:20180510T235707Z:541e8036-5f61-4f32-b5bb-62ded792b463"
4747
],
4848
"Strict-Transport-Security": [
4949
"max-age=31536000; includeSubDomains"
@@ -55,7 +55,7 @@
5555
"no-cache"
5656
],
5757
"Date": [
58-
"Thu, 10 May 2018 23:34:05 GMT"
58+
"Thu, 10 May 2018 23:57:07 GMT"
5959
]
6060
},
6161
"StatusCode": 200
@@ -67,7 +67,7 @@
6767
"RequestBody": "",
6868
"RequestHeaders": {
6969
"x-ms-client-request-id": [
70-
"a07fb454-6ba9-4336-bd29-34e331cb2244"
70+
"32ce7c60-dcc6-4a27-9a69-dd3436de21b6"
7171
],
7272
"accept-language": [
7373
"en-US"
@@ -97,13 +97,13 @@
9797
"14999"
9898
],
9999
"x-ms-request-id": [
100-
"26a20ea1-7df8-4c1b-b13e-6d885bfec930"
100+
"db9699d2-f4a4-4c60-a5e1-d7dcae158d77"
101101
],
102102
"x-ms-correlation-request-id": [
103-
"26a20ea1-7df8-4c1b-b13e-6d885bfec930"
103+
"db9699d2-f4a4-4c60-a5e1-d7dcae158d77"
104104
],
105105
"x-ms-routing-request-id": [
106-
"WESTUS2:20180510T233406Z:26a20ea1-7df8-4c1b-b13e-6d885bfec930"
106+
"WESTUS2:20180510T235708Z:db9699d2-f4a4-4c60-a5e1-d7dcae158d77"
107107
],
108108
"Strict-Transport-Security": [
109109
"max-age=31536000; includeSubDomains"
@@ -115,7 +115,7 @@
115115
"no-cache"
116116
],
117117
"Date": [
118-
"Thu, 10 May 2018 23:34:05 GMT"
118+
"Thu, 10 May 2018 23:57:07 GMT"
119119
]
120120
},
121121
"StatusCode": 200

0 commit comments

Comments
 (0)