Introducing announced change in output type for AddAlertRule and AddAutoscaleSetting cmdlets.

Author: gucalder

src/ResourceManager/Insights/Commands.Insights/Alerts/AddAzureRmAlertRuleCommandBase.cs

@@ -13,8 +13,7 @@
 // ----------------------------------------------------------------------------------
 
 using System.Net;
-using System.Threading.Tasks;
-using Microsoft.Azure.Management.Monitor.Management;
+using Microsoft.Azure.Commands.Insights.OutputClasses;
 using Microsoft.Azure.Management.Monitor.Management.Models;
 using System.Collections.Generic;
 using System.Management.Automation;
@@ -77,21 +76,16 @@ public abstract class AddAzureRmAlertRuleCommandBase : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("The output of this cmdlet will change in the next release to return a single object, not a list, that includes the updated or newly created object.");
             AlertRuleResource parameters = this.CreateSdkCallParameters();
 
             // Part of the result of this operation is operation (result.Body ==> a AutoscaleSettingResource) is being discarded for backwards compatibility
             var result = this.MonitorManagementClient.AlertRules.CreateOrUpdateWithHttpMessagesAsync(resourceGroupName: this.ResourceGroup, parameters: parameters, ruleName: parameters.AlertRuleResourceName).Result;
 
-            // Keep this response for backwards compatibility.
-            // Note: Create operations return the newly created object in the new specification, i.e. need to use result.Body
-            var response = new List<AzureOperationResponse>
+            var response = new PSAddAlertRuleOperationResponse
             {
-                new AzureOperationResponse()
-                {
-                    RequestId = result.RequestId,
-                    StatusCode = HttpStatusCode.OK
-                }
+                RequestId = result.RequestId,
+                StatusCode = result.Response != null ? result.Response.StatusCode : HttpStatusCode.OK,
+                AlertRule = result.Body
             };
 
             WriteObject(response);

src/ResourceManager/Insights/Commands.Insights/Alerts/AddAzureRmLogAlertRuleCommand.cs

@@ -16,13 +16,14 @@
 using System;
 using System.Collections.Generic;
 using System.Management.Automation;
+using Microsoft.Azure.Commands.Insights.OutputClasses;
 
 namespace Microsoft.Azure.Commands.Insights.Alerts
 {
     /// <summary>
     /// Add an Alert rule
     /// </summary>
-    [Cmdlet(VerbsCommon.Add, "AzureRmLogAlertRule"), OutputType(typeof(List<PSObject>))]
+    [Cmdlet(VerbsCommon.Add, "AzureRmLogAlertRule"), OutputType(typeof(PSAddAlertRuleOperationResponse))]
     public class AddAzureRmLogAlertRuleCommand : AddAzureRmAlertRuleCommandBase
     {
         /// <summary>

src/ResourceManager/Insights/Commands.Insights/Alerts/AddAzureRmMetricAlertRuleCommand.cs

@@ -12,6 +12,7 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------
 
+using Microsoft.Azure.Commands.Insights.OutputClasses;
 using Microsoft.Azure.Management.Monitor.Management.Models;
 using System;
 using System.Collections.Generic;
@@ -22,7 +23,7 @@ namespace Microsoft.Azure.Commands.Insights.Alerts
     /// <summary>
     /// Add an Alert rule
     /// </summary>
-    [Cmdlet(VerbsCommon.Add, "AzureRmMetricAlertRule"), OutputType(typeof(List<PSObject>))]
+    [Cmdlet(VerbsCommon.Add, "AzureRmMetricAlertRule"), OutputType(typeof(PSAddAlertRuleOperationResponse))]
     public class AddAzureRmMetricAlertRuleCommand : AddAzureRmAlertRuleCommandBase
     {
         /// <summary>

src/ResourceManager/Insights/Commands.Insights/Alerts/AddAzureRmWebtestAlertRuleCommand.cs

@@ -12,6 +12,7 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------
 
+using Microsoft.Azure.Commands.Insights.OutputClasses;
 using Microsoft.Azure.Management.Monitor.Management.Models;
 using System;
 using System.Collections.Generic;
@@ -22,7 +23,7 @@ namespace Microsoft.Azure.Commands.Insights.Alerts
     /// <summary>
     /// Add an Alert rule
     /// </summary>
-    [Cmdlet(VerbsCommon.Add, "AzureRmWebtestAlertRule"), OutputType(typeof(List<PSObject>))]
+    [Cmdlet(VerbsCommon.Add, "AzureRmWebtestAlertRule"), OutputType(typeof(PSAddAlertRuleOperationResponse))]
     public class AddAzureRmWebtestAlertRuleCommand : AddAzureRmAlertRuleCommandBase
     {
         /// <summary>

src/ResourceManager/Insights/Commands.Insights/Autoscale/AddAzureRmAutoscaleSettingCommand.cs

@@ -28,7 +28,7 @@ namespace Microsoft.Azure.Commands.Insights.Autoscale
     /// <summary>
     /// Create or update an Autoscale setting
     /// </summary>
-    [Cmdlet(VerbsCommon.Add, "AzureRmAutoscaleSetting"), OutputType(typeof(AzureOperationResponse))]
+    [Cmdlet(VerbsCommon.Add, "AzureRmAutoscaleSetting"), OutputType(typeof(PSAddAutoscaleSettingOperationResponse))]
     public class AddAzureRmAutoscaleSettingCommand : ManagementCmdletBase
     {
         internal const string AddAzureRmAutoscaleSettingCreateParamGroup = "Parameters for Add-AzureRmAutoscaleSetting cmdlet in the create semantics";
@@ -102,21 +102,15 @@ public class AddAzureRmAutoscaleSettingCommand : ManagementCmdletBase
         /// </summary>
         protected override void ProcessRecordInternal()
         {
-            WriteWarning("This output of this cmdlet will change in the next release to return a single object that includes the newly created object.");
             AutoscaleSettingResource parameters = this.CreateAutoscaleSettingResource();
 
             // The result of this operation is operation (AutoscaleSettingResource) is being discarded for backwards compatibility
             var result = this.MonitorManagementClient.AutoscaleSettings.CreateOrUpdateWithHttpMessagesAsync(resourceGroupName: this.ResourceGroup, autoscaleSettingName: this.Name, parameters: parameters).Result;
-
-            // Keep this response for backwards compatibility.
-            // Note: Create operations return the newly created object in the new specification, i.e. need to use result.Body
-            var response = new List<AzureOperationResponse>
+            var response = new PSAddAutoscaleSettingOperationResponse()
             {
-                new AzureOperationResponse()
-                {
-                    RequestId = result.RequestId,
-                    StatusCode = result.Response != null ? result.Response.StatusCode : HttpStatusCode.OK
-                }
+                RequestId = result.RequestId,
+                StatusCode = result.Response != null ? result.Response.StatusCode : HttpStatusCode.OK,
+                SettingSpec = result.Body    
             };
 
             WriteObject(response);