Skip to content

Commit 3c76192

Browse files
author
Maddie Clayton
authored
Merge pull request Azure#7227 from markcowl/analysis
Updating common package versions for analysis services
2 parents a0e100d + ffd1197 commit 3c76192

File tree

5 files changed

+62
-8
lines changed

5 files changed

+62
-8
lines changed

src/ResourceManager/Profile/Commands.Profile.Test/TypeConversionTests.cs

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ public void CanConvertNullEnvironments()
5959
Assert.Null(environment.BatchEndpointResourceId);
6060
Assert.Null(environment.AzureOperationalInsightsEndpointResourceId);
6161
Assert.Null(environment.AzureOperationalInsightsEndpoint);
62+
Assert.Null(environment.AzureAnalysisServicesEndpointSuffix);
63+
6264
}
6365

6466
[Theory]
@@ -69,21 +71,21 @@ public void CanConvertNullEnvironments()
6971
"https://manage.windowsazure.com/publishsettings", "https://management.azure.com",
7072
"https://management.core.windows.net", ".sql.azure.com", ".core.windows.net",
7173
".trafficmanager.windows.net", "https://batch.core.windows.net", "https://datalake.azure.net",
72-
"https://api.loganalytics.io", "https://api.loganalytics.io/v1")]
74+
"https://api.loganalytics.io", "https://api.loganalytics.io/v1", "analysisservices.azure.net")]
7375
[Trait(Category.AcceptanceType, Category.CheckIn)]
7476
public void CanConvertValidEnvironments(string name, bool onPremise, string activeDirectory, string serviceResource,
7577
string adTenant, string dataLakeJobs, string dataLakeFiles, string kvDnsSuffix,
7678
string kvResource, string gallery, string graph, string graphResource, string portal,
7779
string publishSettings, string resourceManager, string serviceManagement,
7880
string sqlSuffix, string storageSuffix, string trafficManagerSuffix, string batchResource, string dataLakeResource,
79-
string azureOperationalInsightsEndpointResourceId, string azureOperationalInsightsEndpoint)
81+
string azureOperationalInsightsEndpointResourceId, string azureOperationalInsightsEndpoint, string analysisServicesSuffix)
8082
{
8183
AzureEnvironment azEnvironment = CreateEnvironment(name, onPremise, activeDirectory,
8284
serviceResource, adTenant, dataLakeJobs, dataLakeFiles, kvDnsSuffix,
8385
kvResource, gallery, graph, graphResource, portal, publishSettings,
8486
resourceManager, serviceManagement, sqlSuffix, storageSuffix,
8587
trafficManagerSuffix, batchResource, dataLakeResource,
86-
azureOperationalInsightsEndpointResourceId, azureOperationalInsightsEndpoint);
88+
azureOperationalInsightsEndpointResourceId, azureOperationalInsightsEndpoint, analysisServicesSuffix);
8789
var environment = (PSAzureEnvironment)azEnvironment;
8890
Assert.NotNull(environment);
8991
CheckEndpoint(AzureEnvironment.Endpoint.ActiveDirectory, azEnvironment,
@@ -128,6 +130,8 @@ public void CanConvertValidEnvironments(string name, bool onPremise, string acti
128130
environment.AzureOperationalInsightsEndpointResourceId);
129131
CheckEndpoint(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpoint, azEnvironment,
130132
environment.AzureOperationalInsightsEndpoint);
133+
CheckEndpoint(AzureEnvironment.ExtendedEndpoint.AnalysisServicesEndpointSuffix, azEnvironment,
134+
environment.AzureAnalysisServicesEndpointSuffix);
131135
Assert.Equal(azEnvironment.Name, environment.Name);
132136
Assert.Equal(azEnvironment.OnPremise, environment.EnableAdfsAuthentication);
133137
}
@@ -163,7 +167,9 @@ public void CanConvertNullPSEnvironments()
163167
Assert.False(environment.IsEndpointSet(AzureEnvironment.Endpoint.BatchEndpointResourceId));
164168
Assert.False(environment.IsEndpointSet(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpointResourceId));
165169
Assert.False(environment.IsEndpointSet(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpoint));
170+
Assert.False(environment.IsEndpointSet(AzureEnvironment.ExtendedEndpoint.AnalysisServicesEndpointSuffix));
166171
}
172+
167173
[Theory]
168174
[InlineData("TestAll", true, "https://login.microsoftonline.com", "https://management.core.windows.net/",
169175
"Common", "https://mangement.azure.com/dataLakeJobs", "https://management.azure.com/dataLakeFiles",
@@ -172,14 +178,14 @@ public void CanConvertNullPSEnvironments()
172178
"https://manage.windowsazure.com/publishsettings", "https://management.azure.com",
173179
"https://management.core.windows.net", ".sql.azure.com", ".core.windows.net",
174180
".trafficmanager.windows.net", "https://batch.core.windows.net", "https://datalake.azure.net",
175-
"https://api.loganalytics.io", "https://api.loganalytics.io/v1")]
181+
"https://api.loganalytics.io", "https://api.loganalytics.io/v1", "analysisservices.azure.net")]
176182
[Trait(Category.AcceptanceType, Category.CheckIn)]
177183
public void CanConvertValidPSEnvironments(string name, bool onPremise, string activeDirectory, string serviceResource,
178184
string adTenant, string dataLakeJobs, string dataLakeFiles, string kvDnsSuffix,
179185
string kvResource, string gallery, string graph, string graphResource, string portal,
180186
string publishSettings, string resourceManager, string serviceManagement,
181187
string sqlSuffix, string storageSuffix, string trafficManagerSuffix, string batchResource, string dataLakeResource,
182-
string azureOperationalInsightsEndpointResourceId, string azureOperationalInsightsEndpoint)
188+
string azureOperationalInsightsEndpointResourceId, string azureOperationalInsightsEndpoint, string analysisServicesSuffix)
183189
{
184190
PSAzureEnvironment environment = new PSAzureEnvironment
185191
{
@@ -206,6 +212,7 @@ public void CanConvertValidPSEnvironments(string name, bool onPremise, string ac
206212
BatchEndpointResourceId = batchResource,
207213
AzureOperationalInsightsEndpointResourceId = azureOperationalInsightsEndpointResourceId,
208214
AzureOperationalInsightsEndpoint = azureOperationalInsightsEndpoint,
215+
AzureAnalysisServicesEndpointSuffix = analysisServicesSuffix
209216
};
210217
var azEnvironment = (AzureEnvironment)environment;
211218
Assert.NotNull(environment);
@@ -251,6 +258,8 @@ public void CanConvertValidPSEnvironments(string name, bool onPremise, string ac
251258
environment.AzureOperationalInsightsEndpointResourceId);
252259
CheckEndpoint(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpoint, azEnvironment,
253260
environment.AzureOperationalInsightsEndpoint);
261+
CheckEndpoint(AzureEnvironment.ExtendedEndpoint.AnalysisServicesEndpointSuffix, azEnvironment,
262+
environment.AzureAnalysisServicesEndpointSuffix);
254263
Assert.Equal(azEnvironment.Name, environment.Name);
255264
Assert.Equal(azEnvironment.OnPremise, environment.EnableAdfsAuthentication);
256265
}
@@ -261,7 +270,7 @@ private AzureEnvironment CreateEnvironment(string name, bool onPremise, string a
261270
string kvResource, string gallery, string graph, string graphResource, string portal,
262271
string publishSettings, string resourceManager, string serviceManagement,
263272
string sqlSuffix, string storageSuffix, string trafficManagerSuffix, string batchResource, string dataLakeResource,
264-
string azureOperationalInsightsEndpointResourceId, string azureOperationalInsightsEndpoint)
273+
string azureOperationalInsightsEndpointResourceId, string azureOperationalInsightsEndpoint, string analysisServicesSuffix)
265274
{
266275
var environment = new AzureEnvironment() { Name = name, OnPremise = onPremise };
267276
SetEndpoint(AzureEnvironment.Endpoint.ActiveDirectory, environment, activeDirectory);
@@ -306,6 +315,8 @@ private AzureEnvironment CreateEnvironment(string name, bool onPremise, string a
306315
azureOperationalInsightsEndpointResourceId);
307316
CheckEndpoint(AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpoint, environment,
308317
azureOperationalInsightsEndpoint);
318+
CheckEndpoint(AzureEnvironment.ExtendedEndpoint.AnalysisServicesEndpointSuffix, environment,
319+
analysisServicesSuffix);
309320
return environment;
310321

311322
}

src/ResourceManager/Profile/Commands.Profile/Environment/AddAzureRMEnvironment.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,10 @@ public string DataLakeAudience
159159
HelpMessage = "The endpoint to use when communicating with the Azure Log Analytics API.")]
160160
public string AzureOperationalInsightsEndpoint { get; set; }
161161

162+
[Parameter(Mandatory = false,
163+
HelpMessage = "The endpoint to use when communicating with the Azure Log Analytics API.")]
164+
public string AzureAnalysisServicesEndpointSuffix { get; set; }
165+
162166
protected override void BeginProcessing()
163167
{
164168
// do not call begin processing there is no context needed for this cmdlet
@@ -304,6 +308,8 @@ public override void ExecuteCmdlet()
304308
nameof(AzureOperationalInsightsEndpointResourceId));
305309
SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpoint,
306310
nameof(AzureOperationalInsightsEndpoint));
311+
SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AnalysisServicesEndpointSuffix,
312+
nameof(AzureAnalysisServicesEndpointSuffix));
307313
WriteObject(new PSAzureEnvironment(profileClient.AddOrSetEnvironment(newEnvironment)));
308314
}
309315
});

src/ResourceManager/Profile/Commands.Profile/Environment/SetAzureRMEnvironment.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,10 @@ public string DataLakeAudience
160160
HelpMessage = "The endpoint to use when communicating with the Azure Log Analytics API.")]
161161
public string AzureOperationalInsightsEndpoint { get; set; }
162162

163+
[Parameter(Mandatory = false,
164+
HelpMessage = "The endpoint to use when communicating with the Azure Log Analytics API.")]
165+
public string AzureAnalysisServicesEndpointSuffix { get; set; }
166+
163167
protected override void BeginProcessing()
164168
{
165169
// do not call begin processing there is no context needed for this cmdlet
@@ -305,6 +309,8 @@ public override void ExecuteCmdlet()
305309
nameof(AzureOperationalInsightsEndpointResourceId));
306310
SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.OperationalInsightsEndpoint,
307311
nameof(AzureOperationalInsightsEndpoint));
312+
SetEndpointIfBound(newEnvironment, AzureEnvironment.ExtendedEndpoint.AnalysisServicesEndpointSuffix,
313+
nameof(AzureAnalysisServicesEndpointSuffix));
308314
WriteObject(new PSAzureEnvironment(profileClient.AddOrSetEnvironment(newEnvironment)));
309315
}
310316
});

src/ResourceManager/Profile/Commands.Profile/help/Add-AzureRmEnvironment.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Add-AzureRmEnvironment [-Name] <String> [[-PublishSettingsFileUrl] <String>] [[-
2424
[[-AzureDataLakeAnalyticsCatalogAndJobEndpointSuffix] <String>] [-EnableAdfsAuthentication]
2525
[[-AdTenant] <String>] [[-GraphAudience] <String>] [[-DataLakeAudience] <String>]
2626
[[-BatchEndpointResourceId] <String>] [[-AzureOperationalInsightsEndpointResourceId] <String>]
27-
[[-AzureOperationalInsightsEndpoint] <String>] [-Scope <ContextModificationScope>]
27+
[[-AzureOperationalInsightsEndpoint] <String>] [-AzureAnalysisServicesEndpointSuffix <String>] [-Scope <ContextModificationScope>]
2828
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2929
```
3030

@@ -162,6 +162,22 @@ Accept pipeline input: True (ByPropertyName)
162162
Accept wildcard characters: False
163163
```
164164
165+
### -AzureAnalysisServicesEndpointSuffix
166+
Dns Suffix of Azure Analysis Services service endpoints
167+
168+
```yaml
169+
Type: System.String
170+
Parameter Sets: Name
171+
Aliases:
172+
173+
Required: False
174+
Position: 15
175+
Default value: None
176+
Accept pipeline input: True (ByPropertyName)
177+
Accept wildcard characters: False
178+
```
179+
180+
165181
### -AzureDataLakeAnalyticsCatalogAndJobEndpointSuffix
166182
Dns Suffix of Azure Data Lake Analytics job and catalog services
167183

src/ResourceManager/Profile/Commands.Profile/help/Set-AzureRmEnvironment.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Set-AzureRmEnvironment [-Name] <String> [[-PublishSettingsFileUrl] <String>] [[-
2424
[[-AzureDataLakeAnalyticsCatalogAndJobEndpointSuffix] <String>] [-EnableAdfsAuthentication]
2525
[[-AdTenant] <String>] [[-GraphAudience] <String>] [[-DataLakeAudience] <String>]
2626
[[-BatchEndpointResourceId] <String>] [[-AzureOperationalInsightsEndpointResourceId] <String>]
27-
[[-AzureOperationalInsightsEndpoint] <String>] [-Scope <ContextModificationScope>]
27+
[[-AzureOperationalInsightsEndpoint] <String>] [[-AzureAnalysisServicesEndpointSuffix] <String>] [-Scope <ContextModificationScope>]
2828
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2929
```
3030

@@ -167,6 +167,21 @@ Accept pipeline input: True (ByPropertyName)
167167
Accept wildcard characters: False
168168
```
169169
170+
### -AzureAnalysisServicesEndpointSuffix
171+
Dns Suffix of Azure Analysis Services service endpoints
172+
173+
```yaml
174+
Type: System.String
175+
Parameter Sets: Name
176+
Aliases:
177+
178+
Required: False
179+
Position: 15
180+
Default value: None
181+
Accept pipeline input: True (ByPropertyName)
182+
Accept wildcard characters: False
183+
```
184+
170185
### -AzureDataLakeAnalyticsCatalogAndJobEndpointSuffix
171186
Dns Suffix of Azure Data Lake Analytics job and catalog services
172187

0 commit comments

Comments
 (0)