Skip to content

Commit 5eaf666

Browse files
committed
Storage: addressed some PR comments
1 parent aacdcf2 commit 5eaf666

11 files changed

+210
-167
lines changed

src/Storage/custom/hybrid-2019-03-01/Get-AzStorageAccount_GetByName.ps1

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ function Get-AzStorageAccount_GetByName {
22
[OutputType('Microsoft.Azure.PowerShell.Cmdlets.Storage.Models.Api20171001.IStorageAccount')]
33
[CmdletBinding(PositionalBinding=$false)]
44
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Profile('hybrid-2019-03-01')]
5-
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Description('Lists all the storage accounts available under the subscription. Note that storage keys are not returned; use the ListKeys operation for this.')]
65
param(
76
[Parameter(Mandatory, HelpMessage='Gets subscription credentials which uniquely identify the Microsoft Azure subscription. The subscription ID forms part of the URI for every service call.')]
87
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Path')]

src/Storage/custom/hybrid-2019-03-01/New-AzStorageAccount.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ function New-AzStorageAccount {
7474
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
7575
[System.Management.Automation.SwitchParameter]
7676
# A boolean indicating whether or not the service encrypts the data as it is stored.
77-
${BlobEnabled},
77+
${EncryptBlobService},
7878

7979
[Parameter(ParameterSetName='CreateExpanded1StorageEncryption', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
8080
[Parameter(ParameterSetName='CreateExpanded1KeyVaultEncryption', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
@@ -119,7 +119,7 @@ function New-AzStorageAccount {
119119
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
120120
[System.Management.Automation.SwitchParameter]
121121
# A boolean indicating whether or not the service encrypts the data as it is stored.
122-
${FileEnabled},
122+
${EncryptFileService},
123123

124124
[Parameter(ParameterSetName='CreateExpanded1KeyVaultEncryption', HelpMessage='The name of KeyVault key.')]
125125
[Parameter(ParameterSetName='CreateViaIdentityExpanded1KeyVaultEncryption', HelpMessage='The name of KeyVault key.')]
@@ -206,7 +206,7 @@ function New-AzStorageAccount {
206206
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
207207
[System.Management.Automation.SwitchParameter]
208208
# A boolean indicating whether or not the service encrypts the data as it is stored.
209-
${QueueEnabled},
209+
${EncryptQueueService},
210210

211211
[Parameter(ParameterSetName='CreateExpanded1StorageEncryption', HelpMessage='Indicates the type of storage account.')]
212212
[Parameter(ParameterSetName='CreateExpanded1KeyVaultEncryption', HelpMessage='Indicates the type of storage account.')]
@@ -244,7 +244,7 @@ function New-AzStorageAccount {
244244
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
245245
[System.Management.Automation.SwitchParameter]
246246
# A boolean indicating whether or not the service encrypts the data as it is stored.
247-
${TableEnabled},
247+
${EncryptTableService},
248248

249249
[Parameter(ParameterSetName='CreateExpanded1StorageEncryption', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used for viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key with a length no greater than 128 characters and a value with a length no greater than 256 characters.')]
250250
[Parameter(ParameterSetName='CreateExpanded1KeyVaultEncryption', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used for viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key with a length no greater than 128 characters and a value with a length no greater than 256 characters.')]

src/Storage/custom/hybrid-2019-03-01/Update-AzStorageAccount.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ function Update-AzStorageAccount {
8484
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
8585
[System.Management.Automation.SwitchParameter]
8686
# A boolean indicating whether or not the service encrypts the data as it is stored.
87-
${BlobEnabled},
87+
${EncryptBlobService},
8888

8989
[Parameter(ParameterSetName='UpdateExpanded', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
9090
[Parameter(ParameterSetName='UpdateExpandedStorageEncryption', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
@@ -140,7 +140,7 @@ function Update-AzStorageAccount {
140140
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
141141
[System.Management.Automation.SwitchParameter]
142142
# A boolean indicating whether or not the service encrypts the data as it is stored.
143-
${FileEnabled},
143+
${EncryptFileService},
144144

145145

146146
[Parameter(ParameterSetName='UpdateExpandedKeyVaultEncryption', HelpMessage='The name of KeyVault key.')]
@@ -231,7 +231,7 @@ function Update-AzStorageAccount {
231231
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
232232
[System.Management.Automation.SwitchParameter]
233233
# A boolean indicating whether or not the service encrypts the data as it is stored.
234-
${QueueEnabled},
234+
${EncryptQueueService},
235235

236236
[Parameter(ParameterSetName='UpdateExpanded', HelpMessage='Indicates the type of storage account.')]
237237
[Parameter(ParameterSetName='UpdateExpandedStorageEncryption', HelpMessage='Indicates the type of storage account.')]
@@ -277,7 +277,7 @@ function Update-AzStorageAccount {
277277
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
278278
[System.Management.Automation.SwitchParameter]
279279
# A boolean indicating whether or not the service encrypts the data as it is stored.
280-
${TableEnabled},
280+
${EncryptTableService},
281281

282282
[Parameter(ParameterSetName='UpdateExpanded', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters.')]
283283
[Parameter(ParameterSetName='UpdateExpandedStorageEncryption', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters.')]

src/Storage/custom/latest-2019-04-30/Get-AzStorageAccount_GetByName.ps1

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ function Get-AzStorageAccount_GetByName {
22
[OutputType('Microsoft.Azure.PowerShell.Cmdlets.Storage.Models.Api20190401.IStorageAccount')]
33
[CmdletBinding(PositionalBinding=$false)]
44
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Profile('latest-2019-04-30')]
5-
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Description('Lists all the storage accounts available under the subscription. Note that storage keys are not returned; use the ListKeys operation for this.')]
65
param(
76
[Parameter(Mandatory, HelpMessage='The ID of the target subscription.')]
87
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Path')]

src/Storage/custom/latest-2019-04-30/New-AzStorageAccount.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ function New-AzStorageAccount {
7474
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
7575
[System.Management.Automation.SwitchParameter]
7676
# A boolean indicating whether or not the service encrypts the data as it is stored.
77-
${BlobEnabled},
77+
${EncryptBlobService},
7878

7979
[Parameter(ParameterSetName='CreateExpandedStorageEncryption', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
8080
[Parameter(ParameterSetName='CreateExpandedKeyVaultEncryption', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
@@ -128,7 +128,7 @@ function New-AzStorageAccount {
128128
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
129129
[System.Management.Automation.SwitchParameter]
130130
# A boolean indicating whether or not the service encrypts the data as it is stored.
131-
${FileEnabled},
131+
${EncryptFileService},
132132

133133
[Parameter(ParameterSetName='CreateExpandedStorageEncryption', HelpMessage='Account HierarchicalNamespace enabled if sets to true.')]
134134
[Parameter(ParameterSetName='CreateExpandedKeyVaultEncryption', HelpMessage='Account HierarchicalNamespace enabled if sets to true.')]
@@ -224,7 +224,7 @@ function New-AzStorageAccount {
224224
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
225225
[System.Management.Automation.SwitchParameter]
226226
# A boolean indicating whether or not the service encrypts the data as it is stored.
227-
${QueueEnabled},
227+
${EncryptQueueService},
228228

229229
[Parameter(ParameterSetName='CreateExpandedStorageEncryption', HelpMessage='Indicates the type of storage account.')]
230230
[Parameter(ParameterSetName='CreateExpandedKeyVaultEncryption', HelpMessage='Indicates the type of storage account.')]
@@ -262,7 +262,7 @@ function New-AzStorageAccount {
262262
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
263263
[System.Management.Automation.SwitchParameter]
264264
# A boolean indicating whether or not the service encrypts the data as it is stored.
265-
${TableEnabled},
265+
${EncryptTableService},
266266

267267
[Parameter(ParameterSetName='CreateExpandedStorageEncryption', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used for viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key with a length no greater than 128 characters and a value with a length no greater than 256 characters.')]
268268
[Parameter(ParameterSetName='CreateExpandedKeyVaultEncryption', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used for viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key with a length no greater than 128 characters and a value with a length no greater than 256 characters.')]

src/Storage/custom/latest-2019-04-30/Set-AzRmStorageContainerImmutabilityPolicy.ps1

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@ To view examples, please use the -Online parameter with Get-Help or navigate to:
99
Microsoft.Azure.PowerShell.Cmdlets.Storage.Models.Api20180201.IImmutabilityPolicy
1010
.Outputs
1111
Microsoft.Azure.PowerShell.Cmdlets.Storage.Models.Api20180201.IImmutabilityPolicy
12+
.Notes
13+
COMPLEX PARAMETER PROPERTIES
14+
To create the parameters described below, construct a hash table containing the appropriate properties. For information on hash tables, run Get-Help about_Hash_Tables.
15+
16+
PARAMETER <IImmutabilityPolicy>: The ImmutabilityPolicy property of a blob container, including Id, resource name, resource type, Etag.
17+
ImmutabilityPeriodSinceCreationInDay <Int32>: The immutability period for the blobs in the container since the policy creation, in days.
18+
[ETag <String>]: MISSING DESCRIPTION 03
1219
.Link
1320
https://docs.microsoft.com/en-us/powershell/module/az.storage/set-azrmstoragecontainerimmutabilitypolicy
1421
#>
@@ -20,42 +27,50 @@ function Set-AzRmStorageContainerImmutabilityPolicy {
2027
param(
2128
[Parameter(Mandatory, HelpMessage='The name of the storage account within the specified resource group. Storage account names must be between 3 and 24 characters in length and use numbers and lower-case letters only.')]
2229
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Path')]
30+
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Runtime.Info(SerializedName='accountName', Required, PossibleTypes=([System.String]), Description='The name of the storage account within the specified resource group. Storage account names must be between 3 and 24 characters in length and use numbers and lower-case letters only.')]
2331
[System.String]
2432
# The name of the storage account within the specified resource group. Storage account names must be between 3 and 24 characters in length and use numbers and lower-case letters only.
2533
${AccountName},
2634

2735
[Parameter(Mandatory, HelpMessage='The name of the blob container within the specified storage account. Blob container names must be between 3 and 63 characters in length and use numbers, lower-case letters and dash (-) only. Every dash (-) character must be immediately preceded and followed by a letter or number.')]
2836
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Path')]
37+
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Runtime.Info(SerializedName='containerName', Required, PossibleTypes=([System.String]), Description='The name of the blob container within the specified storage account. Blob container names must be between 3 and 63 characters in length and use numbers, lower-case letters and dash (-) only. Every dash (-) character must be immediately preceded and followed by a letter or number.')]
2938
[System.String]
3039
# The name of the blob container within the specified storage account. Blob container names must be between 3 and 63 characters in length and use numbers, lower-case letters and dash (-) only. Every dash (-) character must be immediately preceded and followed by a letter or number.
3140
${ContainerName},
3241

3342
[Parameter(Mandatory, HelpMessage='The name of the resource group within the user''s subscription. The name is case insensitive.')]
3443
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Path')]
44+
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Runtime.Info(SerializedName='resourceGroupName', Required, PossibleTypes=([System.String]), Description='The name of the resource group within the user''s subscription. The name is case insensitive.')]
3545
[System.String]
3646
# The name of the resource group within the user's subscription. The name is case insensitive.
3747
${ResourceGroupName},
3848

3949
[Parameter(Mandatory, HelpMessage='The ID of the target subscription.')]
4050
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Path')]
51+
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Runtime.Info(SerializedName='subscriptionId', Required, PossibleTypes=([System.String]), Description='The ID of the target subscription.')]
4152
[System.String]
4253
# The ID of the target subscription.
4354
${SubscriptionId},
4455

4556
[Parameter(HelpMessage='The entity state (ETag) version of the immutability policy to update. A value of "*" can be used to apply the operation only if the immutability policy already exists. If omitted, this operation will always be applied.')]
4657
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Header')]
58+
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Runtime.Info(SerializedName='If-Match', PossibleTypes=([System.String]), Description='The entity state (ETag) version of the immutability policy to update. A value of "*" can be used to apply the operation only if the immutability policy already exists. If omitted, this operation will always be applied.')]
4759
[System.String]
4860
# The entity state (ETag) version of the immutability policy to update. A value of "*" can be used to apply the operation only if the immutability policy already exists. If omitted, this operation will always be applied.
4961
${IfMatch},
5062

51-
[Parameter(ParameterSetName='Update', ValueFromPipeline, HelpMessage='The ImmutabilityPolicy property of a blob container, including Id, resource name, resource type, Etag.')]
63+
[Parameter(ParameterSetName='Update', ValueFromPipeline, HelpMessage='The ImmutabilityPolicy property of a blob container, including Id, resource name, resource type, Etag. To construct, see NOTES section for PARAMETER properties and create a hash table.')]
5264
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
65+
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Runtime.Info(SerializedName='parameters', PossibleTypes=([Microsoft.Azure.PowerShell.Cmdlets.Storage.Models.Api20180201.IImmutabilityPolicy]), Description='The ImmutabilityPolicy property of a blob container, including Id, resource name, resource type, Etag.')]
5366
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Models.Api20180201.IImmutabilityPolicy]
5467
# The ImmutabilityPolicy property of a blob container, including Id, resource name, resource type, Etag.
68+
# To construct, see NOTES section for PARAMETER properties and create a hash table.
5569
${Parameter},
5670

5771
[Parameter(ParameterSetName='UpdateExpanded', Mandatory, HelpMessage='The immutability period for the blobs in the container since the policy creation, in days.')]
5872
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
73+
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Runtime.Info(SerializedName='body', Required, PossibleTypes=([System.Int32]), Description='The immutability period for the blobs in the container since the policy creation, in days.')]
5974
[System.Int32]
6075
# The immutability period for the blobs in the container since the policy creation, in days.
6176
${ImmutabilityPeriod},

src/Storage/custom/latest-2019-04-30/Update-AzStorageAccount.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ function Update-AzStorageAccount {
8484
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
8585
[System.Management.Automation.SwitchParameter]
8686
# A boolean indicating whether or not the service encrypts the data as it is stored.
87-
${BlobEnabled},
87+
${EncryptBlobService},
8888

8989
[Parameter(ParameterSetName='UpdateExpanded1', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
9090
[Parameter(ParameterSetName='UpdateExpanded1StorageEncryption', Mandatory, HelpMessage='Gets or sets the custom domain name assigned to the storage account. Name is the CNAME source.')]
@@ -151,7 +151,7 @@ function Update-AzStorageAccount {
151151
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
152152
[System.Management.Automation.SwitchParameter]
153153
# A boolean indicating whether or not the service encrypts the data as it is stored.
154-
${FileEnabled},
154+
${EncryptFileService},
155155

156156

157157
[Parameter(ParameterSetName='UpdateExpanded1KeyVaultEncryption', HelpMessage='The name of KeyVault key.')]
@@ -242,7 +242,7 @@ function Update-AzStorageAccount {
242242
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
243243
[System.Management.Automation.SwitchParameter]
244244
# A boolean indicating whether or not the service encrypts the data as it is stored.
245-
${QueueEnabled},
245+
${EncryptQueueService},
246246

247247
[Parameter(ParameterSetName='UpdateExpanded1', HelpMessage='Indicates the type of storage account.')]
248248
[Parameter(ParameterSetName='UpdateExpanded1StorageEncryption', HelpMessage='Indicates the type of storage account.')]
@@ -288,7 +288,7 @@ function Update-AzStorageAccount {
288288
[Microsoft.Azure.PowerShell.Cmdlets.Storage.Category('Body')]
289289
[System.Management.Automation.SwitchParameter]
290290
# A boolean indicating whether or not the service encrypts the data as it is stored.
291-
${TableEnabled},
291+
${EncryptTableService},
292292

293293
[Parameter(ParameterSetName='UpdateExpanded1', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters.')]
294294
[Parameter(ParameterSetName='UpdateExpanded1StorageEncryption', HelpMessage='Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters.')]

0 commit comments

Comments
 (0)