Skip to content

Commit 6770753

Browse files
jeffrey-acejeffrey-ace
committed
Resolve PR comments
1 parent 89e29c8 commit 6770753

18 files changed

+769
-95
lines changed

‎src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ManagementPartnerTests.ps1

Lines changed: 36 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,21 @@ Tests get management partner
2020
#>
2121
function Test-GetPartner
2222
{
23+
# Setup
2324
$partnerId="123457"
25+
$partner = New-AzureRmManagementPartner -PartnerId $partnerId
26+
27+
# Test
2428
$partner = Get-AzureRmManagementPartner -PartnerId $partnerId
2529

2630
# Assert
2731
Assert-AreEqual $partnerId $partner.PartnerId
2832
Assert-NotNull $partner.TenantId
2933
Assert-NotNull $partner.ObjectId
3034
Assert-NotNull $partner.State
35+
36+
# cleanup
37+
Remove-AzureRmManagementPartner -PartnerId $partnerId
3138
}
3239

3340

@@ -37,13 +44,21 @@ Tests get management partner without parnter id
3744
#>
3845
function Test-GetPartnerNoPartnerId
3946
{
47+
# Setup
48+
$partnerId="123457"
49+
$partner = New-AzureRmManagementPartner -PartnerId $partnerId
50+
51+
# Test
4052
$partner = Get-AzureRmManagementPartner
4153

4254
# Assert
43-
Assert-NotNull $partner.PartnerId
55+
Assert-AreEqual $partnerId $partner.PartnerId
4456
Assert-NotNull $partner.TenantId
4557
Assert-NotNull $partner.ObjectId
4658
Assert-NotNull $partner.State
59+
60+
# cleanup
61+
Remove-AzureRmManagementPartner -PartnerId $partnerId
4762
}
4863

4964

@@ -61,6 +76,9 @@ function Test-NewPartner
6176
Assert-NotNull $partner.TenantId
6277
Assert-NotNull $partner.ObjectId
6378
Assert-NotNull $partner.State
79+
80+
# cleanup
81+
Remove-AzureRmManagementPartner -PartnerId $partnerId
6482
}
6583

6684

@@ -70,14 +88,22 @@ Tests update management partner
7088
#>
7189
function Test-UpdatePartner
7290
{
73-
$partnerId="123456"
74-
$partner = Update-AzureRmManagementPartner -PartnerId $partnerId
91+
# Setup
92+
$partnerId="123457"
93+
$partner = New-AzureRmManagementPartner -PartnerId $partnerId
94+
95+
# Test
96+
$newParnterId="123456"
97+
$partner = Update-AzureRmManagementPartner -PartnerId $newParnterId
7598

7699
# Assert
77-
Assert-AreEqual $partnerId $partner.PartnerId
100+
Assert-AreEqual $newParnterId $partner.PartnerId
78101
Assert-NotNull $partner.TenantId
79102
Assert-NotNull $partner.ObjectId
80103
Assert-NotNull $partner.State
104+
105+
# cleanup
106+
Remove-AzureRmManagementPartner -PartnerId $newParnterId
81107
}
82108

83109
<#
@@ -86,6 +112,10 @@ Tests remove management partner
86112
#>
87113
function Test-RemovePartner
88114
{
89-
$partnerId="123456"
90-
$partner = Remove-AzureRmManagementPartner -PartnerId $partnerId
115+
# Setup
116+
$partnerId="123457"
117+
$partner = New-AzureRmManagementPartner -PartnerId $partnerId
118+
119+
# Test
120+
Remove-AzureRmManagementPartner -PartnerId $partnerId
91121
}

‎src/ResourceManager/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ManagementPartnerTests/TestGetPartner.json

Lines changed: 148 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,85 @@
11
{
22
"Entries": [
3+
{
4+
"RequestUri": "/providers/Microsoft.ManagementPartner/partners/123457?api-version=2018-02-01",
5+
"EncodedRequestUri": "L3Byb3ZpZGVycy9NaWNyb3NvZnQuTWFuYWdlbWVudFBhcnRuZXIvcGFydG5lcnMvMTIzNDU3P2FwaS12ZXJzaW9uPTIwMTgtMDItMDE=",
6+
"RequestMethod": "PUT",
7+
"RequestBody": "",
8+
"RequestHeaders": {
9+
"x-ms-client-request-id": [
10+
"e597c0e8-4cb5-41e8-a27d-645a0575800f"
11+
],
12+
"accept-language": [
13+
"en-US"
14+
],
15+
"User-Agent": [
16+
"FxVersion/4.7.2600.0",
17+
"OSName/Windows10Enterprise",
18+
"OSVersion/6.3.16299",
19+
"Microsoft.Azure.Management.ManagementPartner.ACEProvisioningManagementPartnerAPIClient/0.0.0.0"
20+
]
21+
},
22+
"ResponseBody": "{\r\n \"id\": \"/providers/microsoft.managementpartner/partners/123457\",\r\n \"type\": \"Microsoft.ManagementPartner/partners\",\r\n \"name\": \"123457\",\r\n \"etag\": 53,\r\n \"properties\": {\r\n \"partnerId\": \"123457\",\r\n \"tenantId\": \"1b1121dd-6900-412a-af73-e8d44f81e1c1\",\r\n \"objectId\": \"2119ba66-2042-49a1-bc31-940691d21bf4\",\r\n \"version\": 53,\r\n \"updatedTime\": \"2018-02-07T23:49:06.0075959Z\",\r\n \"createdTime\": \"2018-01-20T05:36:32.6851653Z\",\r\n \"state\": \"Active\"\r\n }\r\n}",
23+
"ResponseHeaders": {
24+
"Content-Length": [
25+
"391"
26+
],
27+
"Content-Type": [
28+
"application/json; charset=utf-8"
29+
],
30+
"Expires": [
31+
"-1"
32+
],
33+
"Pragma": [
34+
"no-cache"
35+
],
36+
"Vary": [
37+
"Accept-Encoding"
38+
],
39+
"x-ms-ratelimit-remaining-tenant-writes": [
40+
"1194"
41+
],
42+
"request-id": [
43+
"3ab09812-d5ce-45d9-9f0c-eb1213566cf7"
44+
],
45+
"x-gsm": [
46+
"8.1.0.50 (AD-CAB-Provisioning:stage.ef4dadac6.180207-2231)"
47+
],
48+
"x-content-type-options": [
49+
"nosniff"
50+
],
51+
"Strict-Transport-Security": [
52+
"max-age=31536000; includeSubDomains"
53+
],
54+
"x-ms-request-id": [
55+
"9a9ebc4a-d7cb-453b-ab89-c3563e1ab6ae"
56+
],
57+
"x-ms-correlation-request-id": [
58+
"9a9ebc4a-d7cb-453b-ab89-c3563e1ab6ae"
59+
],
60+
"x-ms-routing-request-id": [
61+
"CENTRALUS:20180207T234906Z:9a9ebc4a-d7cb-453b-ab89-c3563e1ab6ae"
62+
],
63+
"Cache-Control": [
64+
"no-cache"
65+
],
66+
"Date": [
67+
"Wed, 07 Feb 2018 23:49:06 GMT"
68+
],
69+
"Server": [
70+
"Microsoft-IIS/8.5"
71+
]
72+
},
73+
"StatusCode": 200
74+
},
375
{
476
"RequestUri": "/providers/Microsoft.ManagementPartner/partners/123457?api-version=2018-02-01",
577
"EncodedRequestUri": "L3Byb3ZpZGVycy9NaWNyb3NvZnQuTWFuYWdlbWVudFBhcnRuZXIvcGFydG5lcnMvMTIzNDU3P2FwaS12ZXJzaW9uPTIwMTgtMDItMDE=",
678
"RequestMethod": "GET",
779
"RequestBody": "",
880
"RequestHeaders": {
981
"x-ms-client-request-id": [
10-
"05b0bf53-2048-4189-a999-4a83ad1fd51e"
82+
"357f38e5-e9f8-457e-8a4d-484385381352"
1183
],
1284
"accept-language": [
1385
"en-US"
@@ -19,10 +91,10 @@
1991
"Microsoft.Azure.Management.ManagementPartner.ACEProvisioningManagementPartnerAPIClient/0.0.0.0"
2092
]
2193
},
22-
"ResponseBody": "{\r\n \"id\": \"/providers/microsoft.managementpartner/partners/123457\",\r\n \"type\": \"Microsoft.ManagementPartner/partners\",\r\n \"name\": \"123457\",\r\n \"etag\": 22,\r\n \"properties\": {\r\n \"partnerId\": \"123457\",\r\n \"tenantId\": \"1b1121dd-6900-412a-af73-e8d44f81e1c1\",\r\n \"objectId\": \"2119ba66-2042-49a1-bc31-940691d21bf4\",\r\n \"updatedTime\": \"2018-02-01T07:41:16.6395689Z\",\r\n \"createdTime\": \"2018-01-20T05:36:32.6851653Z\",\r\n \"state\": \"Active\"\r\n }\r\n}",
94+
"ResponseBody": "{\r\n \"id\": \"/providers/microsoft.managementpartner/partners/123457\",\r\n \"type\": \"Microsoft.ManagementPartner/partners\",\r\n \"name\": \"123457\",\r\n \"etag\": 53,\r\n \"properties\": {\r\n \"partnerId\": \"123457\",\r\n \"tenantId\": \"1b1121dd-6900-412a-af73-e8d44f81e1c1\",\r\n \"objectId\": \"2119ba66-2042-49a1-bc31-940691d21bf4\",\r\n \"version\": 53,\r\n \"updatedTime\": \"2018-02-07T23:49:06.0075959Z\",\r\n \"createdTime\": \"2018-01-20T05:36:32.6851653Z\",\r\n \"state\": \"Active\"\r\n }\r\n}",
2395
"ResponseHeaders": {
2496
"Content-Length": [
25-
"378"
97+
"391"
2698
],
2799
"Content-Type": [
28100
"application/json; charset=utf-8"
@@ -37,34 +109,100 @@
37109
"Accept-Encoding"
38110
],
39111
"x-ms-ratelimit-remaining-tenant-reads": [
40-
"14977"
112+
"14954"
113+
],
114+
"request-id": [
115+
"aad599d0-3008-4ec5-8cd7-74e92edcdf16"
116+
],
117+
"x-gsm": [
118+
"8.1.0.50 (AD-CAB-Provisioning:stage.ef4dadac6.180207-2231)"
119+
],
120+
"x-content-type-options": [
121+
"nosniff"
122+
],
123+
"Strict-Transport-Security": [
124+
"max-age=31536000; includeSubDomains"
125+
],
126+
"x-ms-request-id": [
127+
"57782269-bbac-4e08-bfca-d90d1e83ed62"
128+
],
129+
"x-ms-correlation-request-id": [
130+
"57782269-bbac-4e08-bfca-d90d1e83ed62"
131+
],
132+
"x-ms-routing-request-id": [
133+
"CENTRALUS:20180207T234906Z:57782269-bbac-4e08-bfca-d90d1e83ed62"
134+
],
135+
"Cache-Control": [
136+
"no-cache"
137+
],
138+
"Date": [
139+
"Wed, 07 Feb 2018 23:49:06 GMT"
140+
],
141+
"Server": [
142+
"Microsoft-IIS/8.5"
143+
]
144+
},
145+
"StatusCode": 200
146+
},
147+
{
148+
"RequestUri": "/providers/Microsoft.ManagementPartner/partners/123457?api-version=2018-02-01",
149+
"EncodedRequestUri": "L3Byb3ZpZGVycy9NaWNyb3NvZnQuTWFuYWdlbWVudFBhcnRuZXIvcGFydG5lcnMvMTIzNDU3P2FwaS12ZXJzaW9uPTIwMTgtMDItMDE=",
150+
"RequestMethod": "DELETE",
151+
"RequestBody": "",
152+
"RequestHeaders": {
153+
"x-ms-client-request-id": [
154+
"a0b4bc09-e932-4b9f-9568-a18fe7d81a8a"
155+
],
156+
"accept-language": [
157+
"en-US"
158+
],
159+
"User-Agent": [
160+
"FxVersion/4.7.2600.0",
161+
"OSName/Windows10Enterprise",
162+
"OSVersion/6.3.16299",
163+
"Microsoft.Azure.Management.ManagementPartner.ACEProvisioningManagementPartnerAPIClient/0.0.0.0"
164+
]
165+
},
166+
"ResponseBody": "",
167+
"ResponseHeaders": {
168+
"Content-Length": [
169+
"0"
170+
],
171+
"Expires": [
172+
"-1"
173+
],
174+
"Pragma": [
175+
"no-cache"
41176
],
42177
"request-id": [
43-
"3eb0866b-c35d-4433-88dc-c40154867658"
178+
"ca4c6f14-a6a8-41b8-9c1a-726cbc1f828a"
44179
],
45180
"x-gsm": [
46-
"8.1.0.38 (AD-CAB-Provisioning:dev.44ef628fd.180131-1010)"
181+
"8.1.0.50 (AD-CAB-Provisioning:stage.ef4dadac6.180207-2231)"
47182
],
48183
"x-content-type-options": [
49184
"nosniff"
50185
],
51186
"Strict-Transport-Security": [
52187
"max-age=31536000; includeSubDomains"
53188
],
189+
"x-ms-ratelimit-remaining-tenant-writes": [
190+
"1193"
191+
],
54192
"x-ms-request-id": [
55-
"feab0bd5-18b8-43d5-b9f3-896891672a59"
193+
"a6bc8f2f-19a6-48b1-bc7d-1d0e694c3dee"
56194
],
57195
"x-ms-correlation-request-id": [
58-
"feab0bd5-18b8-43d5-b9f3-896891672a59"
196+
"a6bc8f2f-19a6-48b1-bc7d-1d0e694c3dee"
59197
],
60198
"x-ms-routing-request-id": [
61-
"CENTRALUS:20180201T080812Z:feab0bd5-18b8-43d5-b9f3-896891672a59"
199+
"CENTRALUS:20180207T234906Z:a6bc8f2f-19a6-48b1-bc7d-1d0e694c3dee"
62200
],
63201
"Cache-Control": [
64202
"no-cache"
65203
],
66204
"Date": [
67-
"Thu, 01 Feb 2018 08:08:12 GMT"
205+
"Wed, 07 Feb 2018 23:49:06 GMT"
68206
],
69207
"Server": [
70208
"Microsoft-IIS/8.5"

0 commit comments

Comments
 (0)