Skip to content

Commit 7dbe6d6

Browse files
authored
Merge pull request Azure#3879 from djyou/preview
[ACR] Fix help messages
2 parents 94bfbcb + 5653f9c commit 7dbe6d6

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Commands/RemoveAzureContainerRegistry.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ public class RemoveAzureContainerRegistry : ContainerRegistryCmdletBase
4848

4949
public override void ExecuteCmdlet()
5050
{
51-
if (ShouldProcess(Name, "Remove Container Registry"))
51+
if (string.Equals(ParameterSetName, RegistryObjectParameterSet))
5252
{
53-
if (string.Equals(ParameterSetName, RegistryObjectParameterSet))
54-
{
55-
ResourceGroupName = Registry.ResourceGroupName;
56-
Name = Registry.Name;
57-
}
53+
ResourceGroupName = Registry.ResourceGroupName;
54+
Name = Registry.Name;
55+
}
5856

57+
if (ShouldProcess(Name, "Remove Container Registry"))
58+
{
5959
RegistryClient.DeleteRegistry(ResourceGroupName, Name);
6060
}
6161
}

src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Commands/UpdateAzureContainerRegistry.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
namespace Microsoft.Azure.Commands.ContainerRegistry
2020
{
21-
[Cmdlet(VerbsData.Update, ContainerRegistryNoun, DefaultParameterSetName = "Empty", SupportsShouldProcess = true),
21+
[Cmdlet(VerbsData.Update, ContainerRegistryNoun,
22+
DefaultParameterSetName = "Empty",
23+
SupportsShouldProcess = true),
2224
OutputType(typeof(PSContainerRegistry))]
2325
public class UpdateAzureContainerRegistry : ContainerRegistryCmdletBase
2426
{
@@ -77,7 +79,7 @@ public class UpdateAzureContainerRegistry : ContainerRegistryCmdletBase
7779

7880
public override void ExecuteCmdlet()
7981
{
80-
if (ShouldProcess(Name, "Remove Container Registry"))
82+
if (ShouldProcess(Name, "Update Container Registry"))
8183
{
8284
var tags = TagsConversionHelper.CreateTagDictionary(Tag, validate: true);
8385

src/ResourceManager/ContainerRegistry/Commands.ContainerRegistry/Commands/UpdateAzureContainerRegistryCredential.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,14 @@ public class UpdateAzureContainerRegistryCredential : ContainerRegistryCmdletBas
5757

5858
public override void ExecuteCmdlet()
5959
{
60-
if (ShouldProcess(Name, string.Format("Update Container Registry Credential '{0}'", PasswordName)))
60+
if (string.Equals(ParameterSetName, RegistryObjectParameterSet))
6161
{
62-
if (string.Equals(ParameterSetName, RegistryObjectParameterSet))
63-
{
64-
ResourceGroupName = Registry.ResourceGroupName;
65-
Name = Registry.Name;
66-
}
62+
ResourceGroupName = Registry.ResourceGroupName;
63+
Name = Registry.Name;
64+
}
6765

66+
if (ShouldProcess(Name, string.Format("Update Container Registry Credential '{0}'", PasswordName)))
67+
{
6868
var credentials = RegistryClient.RegenerateRegistryCredential(ResourceGroupName, Name, PasswordName);
6969
WriteObject(new PSContainerRegistryCredential(credentials));
7070
}

0 commit comments

Comments
 (0)