Merge pull request Azure#4907 from michael-falk/athipp-public

Fix Sync-AzureAsInstance command to work with the new service api

Author: markcowl

src/ResourceManager/AnalysisServices/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Current Release
+* Fixed Synchronize-AzureAsInstance command to work with new AsAzure REST API for sync
 
 ## Version 0.4.7
 

src/ResourceManager/AnalysisServices/Commands.AnalysisServices.Dataplane/Commands/Synchronize-AzureASInstance.cs

@@ -142,7 +142,8 @@ public override void ExecuteCmdlet()
                 AsAzureClientSession.Instance.Login(context);
                 WriteProgress(new ProgressRecord(0, "Sync-AzureAnalysisServicesInstance.", string.Format("Authenticating user for '{0}' environment.", context.Environment.Name)));
                 var clusterResolveResult = ClusterResolve(context, serverName);
-                if (!clusterResolveResult.CoreServerName.Equals(serverName) || !clusterResolveResult.CoreServerName.EndsWith(":rw"))
+                var virtualServerName = clusterResolveResult.CoreServerName.Split(":".ToCharArray())[0];
+                if (!serverName.Equals(virtualServerName) && !clusterResolveResult.CoreServerName.EndsWith(":rw"))
                 {
                     throw new SynchronizationFailedException("Sync request can only be sent to the management endpoint");
                 }
@@ -245,6 +246,7 @@ protected override void InitializeQosEvent()
         {
             // No data collection for this commandlet
         }
+
         protected override string DataCollectionWarning
         {
             get
@@ -275,8 +277,7 @@ private async Task<ScaleOutServerDatabaseSyncDetails> SynchronizeDatabaseAsync(
             {
                 try
                 {
-                    // pollingUrlAndRetryAfter = await PostSyncRequestAsync(context, syncBaseUri, databaseName, accessToken);
-                    var synchronize = string.Format((string)context.Environment.Endpoints[AsAzureEnvironment.AsRolloutEndpoints.SyncEndpoint], this.clusterResolveResult.CoreServerName, databaseName);
+                    var synchronize = string.Format((string)context.Environment.Endpoints[AsAzureEnvironment.AsRolloutEndpoints.SyncEndpoint], this.serverName, databaseName);
                     this.AsAzureHttpClient.resetHttpClient();
                     using (var message = await AsAzureHttpClient.CallPostAsync(
                         syncBaseUri,
@@ -381,70 +382,81 @@ private async Task<ScaleOutServerDatabaseSyncResult> PollSyncStatusWithRetryAsyn
             {
                 ScaleOutServerDatabaseSyncResult response = null;
                 var syncCompleted = false;
-                do
+                var retryCount = 0;
+
+                while (!syncCompleted && retryCount < maxNumberOfAttempts)
                 {
-                    var retryCount = 0;
-                    while (retryCount < maxNumberOfAttempts)
+                    // Wait for specified polling interval other than retries.
+                    if (retryCount == 0)
                     {
-                        // Wait for specified polling interval other than retries.
-                        if (retryCount == 0)
-                        {
-                            // WriteInformation(new InformationRecord(string.Format("Synchronize database {0}. Attempt #{1}. Waiting for {2} seconds to get sync results...", databaseName, retryCount, pollingInterval.TotalSeconds), string.Empty));
-                            await Task.Delay(pollingInterval);
-                        }
-                        else
-                        {
-                            await Task.Delay(DefaultRetryIntervalForPolling);
-                        }
+                        await Task.Delay(pollingInterval);
+                    }
+                    else
+                    {
+                        await Task.Delay(DefaultRetryIntervalForPolling);
+                    }
 
-                        this.AsAzureHttpClient.resetHttpClient();
-                        using (HttpResponseMessage message = await AsAzureHttpClient.CallGetAsync(
-                            pollingUrl,
-                            string.Empty,
-                            accessToken,
-                            correlationId))
+                    this.AsAzureHttpClient.resetHttpClient();
+                    using (HttpResponseMessage message = await AsAzureHttpClient.CallGetAsync(
+                        pollingUrl,
+                        string.Empty,
+                        accessToken,
+                        correlationId))
+                    {
+                        bool shouldRetry = false;
+                        if (message.IsSuccessStatusCode && message.Content != null)
                         {
-                            syncCompleted = !message.StatusCode.Equals(HttpStatusCode.SeeOther);
-                            if (syncCompleted)
+                            var responseString = await message.Content.ReadAsStringAsync();
+                            response = JsonConvert.DeserializeObject<ScaleOutServerDatabaseSyncResult>(responseString);
+
+                            if (response != null)
                             {
-                                if (message.IsSuccessStatusCode)
+                                var state = response.SyncState;
+                                if (state == DatabaseSyncState.Completed || state == DatabaseSyncState.Failed)
                                 {
-                                    var responseString = await message.Content.ReadAsStringAsync();
-                                    response = JsonConvert.DeserializeObject<ScaleOutServerDatabaseSyncResult>(responseString);
-                                    break;
+                                    syncCompleted = true;
                                 }
                                 else
                                 {
-                                    retryCount++;
-                                    if (response == null)
-                                    {
-                                        response = new ScaleOutServerDatabaseSyncResult()
-                                        {
-                                            Database = databaseName,
-                                            SyncState = DatabaseSyncState.Invalid
-                                        };
-
-                                        response.Details = string.Format(
-                                            "Http Error code: {0}. {1}", 
-                                            message.StatusCode.ToString(), 
-                                            message.Content != null ? await message.Content.ReadAsStringAsync() : string.Empty);
-                                    }
-
-                                    if (message.StatusCode >= (HttpStatusCode)400 && message.StatusCode <= (HttpStatusCode)499)
-                                    {
-                                        break;   
-                                    }
+                                    pollingUrl = message.Headers.Location ?? pollingUrl;
+                                    pollingInterval = message.Headers.RetryAfter.Delta ?? pollingInterval;
                                 }
                             }
                             else
                             {
-                                pollingUrl = message.Headers.Location;
-                                pollingInterval = message.Headers.RetryAfter.Delta ?? pollingInterval;
+                                shouldRetry = true;
                             }
                         }
+                        else
+                        {
+                            shouldRetry = true;
+                        }
+
+                        if(shouldRetry)
+                        {
+                            retryCount++;
+                            response = new ScaleOutServerDatabaseSyncResult()
+                            {
+                                Database = databaseName,
+                                SyncState = DatabaseSyncState.Invalid
+                            };
+
+                            response.Details = string.Format(
+                                "Http Error code: {0}. Message: {1}",
+                                message.StatusCode.ToString(),
+                                message.Content != null ? await message.Content.ReadAsStringAsync() : string.Empty);
+
+                            if (message.StatusCode >= (HttpStatusCode)400 && message.StatusCode <= (HttpStatusCode)499)
+                            {
+                                break;
+                            }
+                        }
+                        else
+                        {
+                            retryCount = 0;
+                        }
                     }
                 }
-                while (!syncCompleted);
 
                 return response;
             });

src/ResourceManager/AnalysisServices/Commands.AnalysisServices.Dataplane/Models/AsAzureClientSession.cs

@@ -29,7 +29,7 @@ public class AsAzureClientSession
     {
         public const string RestartEndpointPathFormat = "/webapi/servers/{0}/restart?api-version=2016-10-01";
         public const string LogfileEndpointPathFormat = "/webapi/servers/{0}/logfileHere";
-        public const string SynchronizeEndpointPathFormat = "/webapi/servers/{0}/databases/{1}/sync";
+        public const string SynchronizeEndpointPathFormat = "/servers/{0}/models/{1}/sync";
         public const string AsAzureClientId = "cf710c6e-dfcc-4fa8-a093-d47294e44c66";
         public static readonly Uri RedirectUri = new Uri("urn:ietf:wg:oauth:2.0:oob");
         public static string DefaultRolloutEnvironmentKey = "asazure.windows.net";

src/ResourceManager/AnalysisServices/Commands.AnalysisServices.Test/InMemoryTests/DataPlaneCommandTests.cs

@@ -390,7 +390,7 @@ public void SynchronizeAzureASInstance_SingleDB_Succeeds()
 
             // set up sync respnose
             var postResponse = new HttpResponseMessage(HttpStatusCode.Accepted);
-            postResponse.Headers.Location = new Uri("https://1");
+            postResponse.Headers.Location = new Uri("https://done");
             postResponse.Headers.RetryAfter = new RetryConditionHeaderValue(TimeSpan.FromMilliseconds(500));
             postResponse.Headers.Add("x-ms-root-activity-id", Guid.NewGuid().ToString());
             postResponse.Headers.Add("x-ms-current-utc-date", Guid.NewGuid().ToString());