Skip to content

Commit e7521f6

Browse files
yanfa317yanfa317
committed
fix as comments
1 parent ad4e984 commit e7521f6

24 files changed

+63
-65
lines changed

‎src/ManagedNetwork/ManagedNetwork/Az.ManagedNetwork.psd1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ CmdletsToExport = 'Get-AzManagedNetwork',
8181
'New-AzManagedNetworkPeeringPolicy',
8282
'Get-AzManagedNetworkPeeringPolicy',
8383
'Remove-AzManagedNetworkPeeringPolicy',
84-
'Update-AzManagedNetworkPeeringPolicy'
84+
'Update-AzManagedNetworkPeeringPolicy'
8585

8686
# Variables to export from this module
8787
# VariablesToExport = @()
@@ -119,7 +119,7 @@ PrivateData = @{
119119
ReleaseNotes = '* Added new Powershell cmdlets for ManagedNetwork'
120120

121121
# Prerelease string of this module
122-
# Prerelease = 'preview'
122+
Prerelease = 'preview'
123123

124124
# Flag to indicate whether the module requires explicit user acceptance for install/update
125125
# RequireLicenseAcceptance = $false

‎src/ManagedNetwork/ManagedNetwork/ChangeLog.md

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,18 @@
1919
-->
2020

2121
## Upcoming Release
22-
23-
## Version 0.1.0
24-
* Demo availability of `Az.ManagedNetwork` module
22+
* Create cmdlets for Az.ManagedNetwork.
23+
- Get-AzManagedNetwork: To get managed network
24+
- New-AzManagedNetwork: To create managed network
25+
- New-AzManagedNetworkScope: To create managed network Scope
26+
- Remove-AzManaged Network: To remote managed network
27+
- Update-AzManagedNetwork: To update managed network
28+
- Get-AzManagedNetworkGroup: To get managed network group
29+
- New-AzManagedNetworkGroup: To create managed network group
30+
- Remove-AzManagedNetworkGroup: To remove managed network group
31+
- Update-AzManagedNetworkGroup: To update managed network group
32+
- Get-AzManagedNetworkPeeringPolicy: To get managed network peering policy
33+
- New-AzManagedNetworkPeeringPolicy: To create managed network peering policy
34+
- Remove-AzManagedNetworkPeeringPolicy: To remove managed network peering policy
35+
- Update-AzManagedNetworkPeeringPolicy: To update managed network peering policy
2536

‎src/ManagedNetwork/ManagedNetwork/Commands/ManagedNetwork/GetAzManagedNetwork.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ public class GetAzManagedNetwork : AzureManagedNetworkCmdletBase
4545
/// </summary>
4646
[Parameter(Mandatory = true,
4747
HelpMessage = HelpMessage.ResourceIdNameHelp,
48+
ValueFromPipelineByPropertyName = true,
4849
ParameterSetName = ParameterSetNames.ResourceIdParameterSet)]
4950
[ValidateNotNullOrEmpty]
5051
[ResourceIdCompleter("Microsoft.ManagedNetwork/managedNetworks")]

‎src/ManagedNetwork/ManagedNetwork/Commands/ManagedNetwork/NewAzManagedNetworkScope.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
namespace Microsoft.Azure.Commands.ManagedNetwork
2222
{
23-
[Cmdlet("New", "AzManagedNetworkScope", SupportsShouldProcess = true), OutputType(typeof(PSScope))]
23+
[Cmdlet("New", "AzManagedNetworkScope", SupportsShouldProcess = false)]
2424
[OutputType(typeof(PSScope))]
2525
public class NewAzManagedNetworkScope : AzureManagedNetworkCmdletBase
2626
{
@@ -36,12 +36,6 @@ public class NewAzManagedNetworkScope : AzureManagedNetworkCmdletBase
3636
[Parameter(Mandatory = false, HelpMessage = "Azure ManagedNetwork Scope subnet ids.")]
3737
public string[] SubnetIdList { get; set; }
3838

39-
/// <summary>
40-
/// The AsJob parameter to run in the background.
41-
/// </summary>
42-
[Parameter(Mandatory = false, HelpMessage = HelpMessage.AsJobHelp)]
43-
public SwitchParameter AsJob { get; set; }
44-
4539
public override void ExecuteCmdlet()
4640
{
4741
PSScope scope = new PSScope();

‎src/ManagedNetwork/ManagedNetwork/Commands/ManagedNetwork/RemoveAzManagedNetwork.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public class RemoveAzureManagedNetwork : AzureManagedNetworkCmdletBase
4242
/// </summary>
4343
[Parameter(Mandatory = true,
4444
HelpMessage = HelpMessage.ResourceIdNameHelp,
45+
ValueFromPipelineByPropertyName = true,
4546
ParameterSetName = ParameterSetNames.ResourceIdParameterSet)]
4647
[ValidateNotNullOrEmpty]
4748
[ResourceIdCompleter("Microsoft.ManagedNetwork/managedNetworks")]

‎src/ManagedNetwork/ManagedNetwork/Commands/ManagedNetworkGroup/GetAzManagedNetworkGroup.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public class GetAzManagedNetworkGroup : AzureManagedNetworkCmdletBase
4848
/// </summary>
4949
[Parameter(Mandatory = true,
5050
HelpMessage = HelpMessage.ResourceIdNameHelp,
51+
ValueFromPipelineByPropertyName = true,
5152
ParameterSetName = ParameterSetNames.ResourceIdParameterSet)]
5253
[ValidateNotNullOrEmpty]
5354
[ResourceIdCompleter("Microsoft.ManagedNetwork/managedNetworks/managednetworkgroups")]

‎src/ManagedNetwork/ManagedNetwork/Commands/ManagedNetworkGroup/RemoveAzManagedNetworkGroup.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ public class RemoveAzManagedNetworkGroup : AzureManagedNetworkCmdletBase
5555
/// </summary>
5656
[Parameter(Mandatory = true,
5757
HelpMessage = HelpMessage.ResourceIdNameHelp,
58+
ValueFromPipelineByPropertyName = true,
5859
ParameterSetName = ParameterSetNames.ResourceIdParameterSet)]
5960
[ValidateNotNullOrEmpty]
6061
[ResourceIdCompleter("Microsoft.ManagedNetwork/managedNetworks/managednetworkgroups")]

‎src/ManagedNetwork/ManagedNetwork/Commands/ManagedNetworkPeeringPolicy/GetAzManagedNetworkPeeringPolicy.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ public class GetAzManagedNetworkPeeringPolicy : AzureManagedNetworkCmdletBase
5757
/// </summary>
5858
[Parameter(Mandatory = true,
5959
HelpMessage = HelpMessage.ResourceIdNameHelp,
60+
ValueFromPipelineByPropertyName = true,
6061
ParameterSetName = ParameterSetNames.ResourceIdParameterSet)]
6162
[ValidateNotNullOrEmpty]
6263
[ResourceIdCompleter("Microsoft.ManagedNetwork/managedNetworks/managednetworkpeeringpolicies")]

‎src/ManagedNetwork/ManagedNetwork/Commands/ManagedNetworkPeeringPolicy/RemoveAzManagedNetworkPeeringPolicy.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ public class RemoveAzManagedNetworkPeeringPolicy : AzureManagedNetworkCmdletBase
6262
/// </summary>
6363
[Parameter(Mandatory = true,
6464
HelpMessage = HelpMessage.ResourceIdNameHelp,
65+
ValueFromPipelineByPropertyName = true,
6566
ParameterSetName = ParameterSetNames.ResourceIdParameterSet)]
6667
[ValidateNotNullOrEmpty]
6768
[ResourceIdCompleter("Microsoft.ManagedNetwork/managedNetworks/managednetworkpeeringpolicies")]

‎src/ManagedNetwork/ManagedNetwork/help/Az.ManagedNetwork.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Module Name: Az.ManagedNetwork
33
Module Guid: 00000000-0000-0000-0000-000000000000
44
Download Help Link: {{ Update Download Link }}
5-
Help Version: 1.0.0.0
5+
Help Version: 0.1.0.0
66
Locale: en-US
77
---
88

‎src/ManagedNetwork/ManagedNetwork/help/Get-AzManagedNetwork.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ Aliases:
144144
Required: True
145145
Position: Named
146146
Default value: None
147-
Accept pipeline input: False
147+
Accept pipeline input: True (ByPropertyName)
148148
Accept wildcard characters: False
149149
```
150150

‎src/ManagedNetwork/ManagedNetwork/help/Get-AzManagedNetworkGroup.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ Accept pipeline input: False
9595
Accept wildcard characters: False
9696
```
9797
98-
### -ManagedNetwork
98+
### -ManagedNetworkObject
9999
The object of Managed Network.
100100
101101
```yaml
@@ -106,7 +106,7 @@ Aliases:
106106
Required: True
107107
Position: Named
108108
Default value: None
109-
Accept pipeline input: False
109+
Accept pipeline input: True (ByValue)
110110
Accept wildcard characters: False
111111
```
112112
@@ -166,7 +166,7 @@ Aliases:
166166
Required: True
167167
Position: Named
168168
Default value: None
169-
Accept pipeline input: False
169+
Accept pipeline input: True (ByPropertyName)
170170
Accept wildcard characters: False
171171
```
172172

‎src/ManagedNetwork/ManagedNetwork/help/Get-AzManagedNetworkPeeringPolicy.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ Aliases:
122122
Required: True
123123
Position: Named
124124
Default value: None
125-
Accept pipeline input: False
125+
Accept pipeline input: True (ByValue)
126126
Accept wildcard characters: False
127127
```
128128
@@ -191,7 +191,7 @@ Aliases:
191191
Required: True
192192
Position: Named
193193
Default value: None
194-
Accept pipeline input: False
194+
Accept pipeline input: True (ByPropertyName)
195195
Accept wildcard characters: False
196196
```
197197

‎src/ManagedNetwork/ManagedNetwork/help/New-AzManagedNetworkGroup.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ Accept wildcard characters: False
142142
Azure ManagedNetwork management group ids.
143143
144144
```yaml
145-
Type: String[]
145+
Type: System.String[]
146146
Parameter Sets: (All)
147147
Aliases:
148148

@@ -187,7 +187,7 @@ Accept wildcard characters: False
187187
Azure ManagedNetwork subnet ids.
188188
189189
```yaml
190-
Type: String[]
190+
Type: System.String[]
191191
Parameter Sets: (All)
192192
Aliases:
193193

@@ -202,7 +202,7 @@ Accept wildcard characters: False
202202
Azure ManagedNetwork subscription ids.
203203
204204
```yaml
205-
Type: String[]
205+
Type: System.String[]
206206
Parameter Sets: (All)
207207
Aliases:
208208

@@ -217,7 +217,7 @@ Accept wildcard characters: False
217217
Azure ManagedNetwork virtual network ids.
218218
219219
```yaml
220-
Type: String[]
220+
Type: System.String[]
221221
Parameter Sets: (All)
222222
Aliases:
223223

@@ -266,7 +266,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
266266
267267
### System.String
268268
269-
### String[]
269+
### System.String[]
270270
271271
### Microsoft.Azure.Commands.Network.Models.PSManagedNetwork
272272

‎src/ManagedNetwork/ManagedNetwork/help/New-AzManagedNetworkPeeringPolicy.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ Accept wildcard characters: False
154154
Azure ManagedNetwork Policy Mesh Groups.
155155
156156
```yaml
157-
Type: String[]
157+
Type: System.String[]
158158
Parameter Sets: (All)
159159
Aliases:
160160

@@ -214,7 +214,7 @@ Accept wildcard characters: False
214214
Azure ManagedNetwork Policy Spoke Groups.
215215
216216
```yaml
217-
Type: String[]
217+
Type: System.String[]
218218
Parameter Sets: (All)
219219
Aliases:
220220

@@ -263,7 +263,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
263263
264264
### System.String
265265
266-
### String[]
266+
### System.String[]
267267
268268
### Microsoft.Azure.Commands.Network.Models.PSManagedNetwork
269269

‎src/ManagedNetwork/ManagedNetwork/help/New-AzManagedNetworkScope.md

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Creates a scope for managedNetwork.
1515
New-AzManagedNetworkScope [-ManagementGroupIdList <String[]>]
1616
[-SubscriptionIdList <String[]>]
1717
[-VirtualNetworkIdList <String[]>]
18-
[-SubnetIdList <String[]>] [-AsJob]
18+
[-SubnetIdList <String[]>]
1919
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
2020
```
2121

@@ -34,21 +34,6 @@ This example creates a Managed Network scope.
3434

3535
## PARAMETERS
3636

37-
### -AsJob
38-
Run in the background.
39-
40-
```yaml
41-
Type: System.Management.Automation.SwitchParameter
42-
Parameter Sets: (All)
43-
Aliases:
44-
45-
Required: False
46-
Position: Named
47-
Default value: None
48-
Accept pipeline input: False
49-
Accept wildcard characters: False
50-
```
51-
5237
### -DefaultProfile
5338
The credentials, account, tenant, and subscription used for communication with Azure.
5439

@@ -68,7 +53,7 @@ Accept wildcard characters: False
6853
Azure ManagedNetwork Scope management group ids.
6954
7055
```yaml
71-
Type: String[]
56+
Type: System.String[]
7257
Parameter Sets: (All)
7358
Aliases:
7459

@@ -83,7 +68,7 @@ Accept wildcard characters: False
8368
Azure ManagedNetwork Scope subnet ids.
8469
8570
```yaml
86-
Type: String[]
71+
Type: System.String[]
8772
Parameter Sets: (All)
8873
Aliases:
8974

@@ -98,7 +83,7 @@ Accept wildcard characters: False
9883
Azure ManagedNetwork Scope subscription ids.
9984
10085
```yaml
101-
Type: String[]
86+
Type: System.String[]
10287
Parameter Sets: (All)
10388
Aliases:
10489

@@ -113,7 +98,7 @@ Accept wildcard characters: False
11398
Azure ManagedNetwork Scope virtual network ids.
11499
115100
```yaml
116-
Type: String[]
101+
Type: System.String[]
117102
Parameter Sets: (All)
118103
Aliases:
119104

@@ -160,7 +145,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
160145
161146
## INPUTS
162147
163-
### String []
148+
### System.String []
164149
165150
## OUTPUTS
166151

‎src/ManagedNetwork/ManagedNetwork/help/Remove-AzManagedNetwork.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Aliases:
116116
Required: True
117117
Position: Named
118118
Default value: None
119-
Accept pipeline input: False
119+
Accept pipeline input: True (ByValue)
120120
Accept wildcard characters: False
121121
```
122122
@@ -176,7 +176,7 @@ Aliases:
176176
Required: True
177177
Position: Named
178178
Default value: None
179-
Accept pipeline input: False
179+
Accept pipeline input: True (ByPropertyName)
180180
Accept wildcard characters: False
181181
```
182182
@@ -218,6 +218,8 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
218218
219219
### System.String
220220
221+
### Microsoft.Azure.Commands.ManagedNetwork.Models.PSManagedNetwork
222+
221223
## OUTPUTS
222224
223225
### System.Boolean

‎src/ManagedNetwork/ManagedNetwork/help/Remove-AzManagedNetworkGroup.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ Aliases:
121121
Required: True
122122
Position: Named
123123
Default value: None
124-
Accept pipeline input: False
124+
Accept pipeline input: True (ByValue)
125125
Accept wildcard characters: False
126126
```
127127
@@ -151,7 +151,7 @@ Aliases:
151151
Required: True
152152
Position: Named
153153
Default value: None
154-
Accept pipeline input: False
154+
Accept pipeline input: True (ByValue)
155155
Accept wildcard characters: False
156156
```
157157

‎src/ManagedNetwork/ManagedNetwork/help/Remove-AzManagedNetworkPeeringPolicy.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ Aliases:
121121
Required: True
122122
Position: Named
123123
Default value: None
124-
Accept pipeline input: False
124+
Accept pipeline input: True (ByValue)
125125
Accept wildcard characters: False
126126
```
127127
@@ -151,7 +151,7 @@ Aliases:
151151
Required: True
152152
Position: Named
153153
Default value: None
154-
Accept pipeline input: False
154+
Accept pipeline input: True (ByValue)
155155
Accept wildcard characters: False
156156
```
157157
@@ -211,7 +211,7 @@ Aliases:
211211
Required: True
212212
Position: Named
213213
Default value: None
214-
Accept pipeline input: False
214+
Accept pipeline input: True (ByPropertyName)
215215
Accept wildcard characters: False
216216
```
217217

0 commit comments

Comments
 (0)