Skip to content

Commit f85d51a

Browse files
committed
Address PR comments
1 parent b2ee4b0 commit f85d51a

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

src/ResourceManager/AzureBatch/Commands.Batch/ComputeNodes/StartBatchComputeNodeServiceLogUploadCommand.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@
2020

2121
namespace Microsoft.Azure.Commands.Batch
2222
{
23-
[Cmdlet(VerbsLifecycle.Start, Constants.AzureBatchComputeNodeServiceLogUpload, DefaultParameterSetName = Constants.AzureBatchComputeNodeServiceLogUpload, SupportsShouldProcess = true),
23+
[Cmdlet(VerbsLifecycle.Start,
24+
Constants.AzureBatchComputeNodeServiceLogUpload,
25+
SupportsShouldProcess = true,
26+
DefaultParameterSetName = Constants.AzureBatchComputeNodeServiceLogUpload),
2427
OutputType(typeof(PSStartComputeNodeServiceLogUploadResult))]
2528
public class StartBatchComputeNodeServiceLogUploadCommand : BatchObjectModelCmdletBase
2629
{

src/ResourceManager/AzureBatch/Commands.Batch/Pools/GetBatchPoolNodeCountsCommand.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,11 @@
1919

2020
namespace Microsoft.Azure.Commands.Batch
2121
{
22-
[Cmdlet(VerbsCommon.Get, Constants.AzureBatchPoolNodeCounts, DefaultParameterSetName = Constants.AzureBatchPoolNodeCounts), OutputType(typeof(PSPoolNodeCounts))]
22+
[Cmdlet(VerbsCommon.Get,
23+
Constants.AzureBatchPoolNodeCounts,
24+
SupportsPaging = true,
25+
DefaultParameterSetName = Constants.AzureBatchPoolNodeCounts),
26+
OutputType(typeof(PSPoolNodeCounts))]
2327
public class GetBatchPoolNodeCountsCommand : BatchObjectModelCmdletBase
2428
{
2529
private const int defaultMaxCount = 10;

tools/StaticAnalysis/Exceptions/SignatureIssues.csv

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@
190190
"Microsoft.Azure.Commands.Batch.dll","Microsoft.Azure.Commands.Batch.NewBatchTaskCommand","New-AzureBatchTask","1","8410","Parameter Tasks of cmdlet New-AzureBatchTask does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
191191
"Microsoft.Azure.Commands.Batch.dll","Microsoft.Azure.Commands.Batch.NewBatchTaskCommand","New-AzureBatchTask","1","8410","Parameter ExitConditions of cmdlet New-AzureBatchTask does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
192192
"Microsoft.Azure.Commands.Batch.dll","Microsoft.Azure.Commands.Batch.GetBatchPoolNodeCountsCommand","Get-AzureBatchPoolNodeCounts","1","8400","Get-AzureBatchPoolNodeCounts uses the noun 'AzureBatchPoolNodeCounts', which does not follow the enforced naming convention of using a singular noun for a cmdlet name.","Consider using a singular noun for the cmdlet name."
193-
"Microsoft.Azure.Commands.Cdn.dll","Microsoft.Azure.Commands.Cdn.Origin.SetAzureRmCdnOrigin","Set-AzureRmCdnOrigin","1","8100","Set-AzureRmCdnOrigin Does not support ShouldProcess but the cmdlet verb Set indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
194193
"Microsoft.Azure.Commands.Cdn.dll","Microsoft.Azure.Commands.Cdn.Origin.SetAzureRmCdnOrigin","Set-AzureRmCdnOrigin","1","8100","Set-AzureRmCdnOrigin Does not support ShouldProcess but the cmdlet verb Set indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
195194
"Microsoft.Azure.Commands.Cdn.dll","Microsoft.Azure.Commands.Cdn.Endpoint.PublishAzureRmCdnEndpointContent","Publish-AzureRmCdnEndpointContent","1","8100","Publish-AzureRmCdnEndpointContent Does not support ShouldProcess but the cmdlet verb Publish indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
196195
"Microsoft.Azure.Commands.Cdn.dll","Microsoft.Azure.Commands.Cdn.Profile.NewAzureRmCdnProfile","New-AzureRmCdnProfile","1","8410","Parameter Tags of cmdlet New-AzureRmCdnProfile does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
@@ -1104,4 +1103,3 @@
11041103
"c:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.KeyVault\Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UpdateAzureKeyVaultNetworkRuleSet","Update-AzureRmKeyVaultNetworkRuleSet","1","8410","Parameter Bypass of cmdlet Update-AzureRmKeyVaultNetworkRuleSet does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
11051104
"c:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.KeyVault\Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UpdateAzureKeyVaultKey","Update-AzureKeyVaultKey","1","8410","Parameter Expires of cmdlet Update-AzureKeyVaultKey does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
11061105
"c:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.KeyVault\Microsoft.Azure.Commands.KeyVault.dll","Microsoft.Azure.Commands.KeyVault.UpdateAzureKeyVaultKey","Update-AzureKeyVaultKey","1","8410","Parameter KeyOps of cmdlet Update-AzureKeyVaultKey does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
1107-
"Microsoft.Azure.Commands.Cdn.dll","Microsoft.Azure.Commands.Cdn.Origin.SetAzureRmCdnOrigin","Set-AzureRmCdnOrigin","1","8100","Set-AzureRmCdnOrigin Does not support ShouldProcess but the cmdlet verb Set indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

0 commit comments

Comments
 (0)