Skip to content

Bring checking isArray out of the loop #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2021
Merged

Bring checking isArray out of the loop #14

merged 1 commit into from
Nov 14, 2021

Conversation

danialdezfouli
Copy link
Contributor

a minor performance improvement

@AsyncBanana
Copy link
Owner

Thanks for the PR! This might slow down objects with no changes, but this should help a lot for flat objects with lots of changes and does not increase size much.
I will release this in the next release.

@AsyncBanana AsyncBanana changed the title Bring out checking isArray out of the loop Bring checking isArray out of the loop Nov 14, 2021
@AsyncBanana AsyncBanana merged commit 0b4c00e into AsyncBanana:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsyncBanana AsyncBanana AsyncBanana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danialdezfouli @AsyncBanana