Skip to content

Commit 86b1e78

Browse files
committed
Add back rule but remove severity level change
1 parent 46962db commit 86b1e78

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

WordPress-VIP-Go/ruleset-test.inc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,10 @@ _ex( $some_nasty_var, 'context' ); // Error.
182182
echo esc_html_x( 'Something', 'context' ); // Ok.
183183
echo esc_html_x( $some_nasty_var, 'context' ); // Ok.
184184

185-
186-
187-
188-
185+
// WordPress.WP.GlobalVariablesOverride.OverrideProhibited
186+
global $wpdb;
187+
$wpdb = 'test'; // Error.
188+
$GLOBALS['domain']['subkey'] = 'something else'; // Error.
189189

190190
// WordPress.WP.EnqueuedResources.NonEnqueuedScript
191191
echo wp_kses( '<script src="' . esc_url( $url ) . '">', [ 'script' => [ 'src' => [], ], ] ); // Warning + Message.
@@ -297,7 +297,7 @@ get_user_meta(); // Ok.
297297
update_user_meta( $bar, '123', $foo ); // Ok.
298298

299299
// WordPressVIPMinimum.Variables.RestrictedVariables.user_meta__wpdb__usermeta
300-
global $wpdb; $query = "SELECT * FROM $wpdb->usermeta"; // Ok.
300+
$query = "SELECT * FROM $wpdb->usermeta"; // Ok.
301301

302302
// WordPressVIPMinimum.Functions.RestrictedFunctions.site_option_delete_site_option
303303
delete_site_option( $foo ); // Ok.

WordPress-VIP-Go/ruleset-test.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
165 => 1,
2424
180 => 1,
2525
181 => 1,
26+
187 => 1,
27+
188 => 1,
2628
252 => 1,
2729
255 => 1,
2830
256 => 1,

WordPress-VIP-Go/ruleset.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@
210210
<!-- We trust that translations are safe on VIP Go -->
211211
<severity>1</severity>
212212
</rule>
213+
<rule ref="WordPress.WP.GlobalVariablesOverride.Prohibited"/>
213214
<rule ref="WordPress.WP.EnqueuedResources.NonEnqueuedScript">
214215
<type>warning</type>
215216
<severity>3</severity>

0 commit comments

Comments
 (0)