Skip to content

Commit ee9d652

Browse files
committed
adding some exception and remove extra param
1 parent b59e347 commit ee9d652

File tree

3 files changed

+19
-2
lines changed

3 files changed

+19
-2
lines changed

infra/core/monitor/applicationinsights-dashboard.bicep

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,12 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
3434
]
3535
#disable-next-line BCP036
3636
type: 'Extension/AppInsightsExtension/PartType/AspNetOverviewPinnedPart'
37+
#disable-next-line BCP037
3738
asset: {
3839
idInputName: 'id'
3940
type: 'ApplicationInsights'
4041
}
42+
#disable-next-line BCP037
4143
defaultMenuItemId: 'overview'
4244
}
4345
}
@@ -65,10 +67,12 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
6567
]
6668
#disable-next-line BCP036
6769
type: 'Extension/AppInsightsExtension/PartType/ProactiveDetectionAsyncPart'
70+
#disable-next-line BCP037
6871
asset: {
6972
idInputName: 'ComponentId'
7073
type: 'ApplicationInsights'
7174
}
75+
#disable-next-line BCP037
7276
defaultMenuItemId: 'ProactiveDetection'
7377
}
7478
}
@@ -96,6 +100,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
96100
]
97101
#disable-next-line BCP036
98102
type: 'Extension/AppInsightsExtension/PartType/QuickPulseButtonSmallPart'
103+
#disable-next-line BCP037
99104
asset: {
100105
idInputName: 'ComponentId'
101106
type: 'ApplicationInsights'
@@ -137,6 +142,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
137142
]
138143
#disable-next-line BCP036
139144
type: 'Extension/AppInsightsExtension/PartType/AvailabilityNavButtonPart'
145+
#disable-next-line BCP037
140146
asset: {
141147
idInputName: 'ComponentId'
142148
type: 'ApplicationInsights'
@@ -178,6 +184,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
178184
]
179185
#disable-next-line BCP036
180186
type: 'Extension/AppInsightsExtension/PartType/AppMapButtonPart'
187+
#disable-next-line BCP037
181188
asset: {
182189
idInputName: 'ComponentId'
183190
type: 'ApplicationInsights'
@@ -236,6 +243,7 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
236243
]
237244
#disable-next-line BCP036
238245
type: 'Extension/AppInsightsExtension/PartType/UsageUsersOverviewPart'
246+
#disable-next-line BCP037
239247
asset: {
240248
idInputName: 'ComponentId'
241249
type: 'ApplicationInsights'
@@ -298,11 +306,14 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
298306
]
299307
#disable-next-line BCP036
300308
type: 'Extension/AppInsightsExtension/PartType/CuratedBladeFailuresPinnedPart'
309+
#disable-next-line BCP037
301310
isAdapter: true
311+
#disable-next-line BCP037
302312
asset: {
303313
idInputName: 'ResourceId'
304314
type: 'ApplicationInsights'
305315
}
316+
#disable-next-line BCP037
306317
defaultMenuItemId: 'failures'
307318
}
308319
}
@@ -362,11 +373,14 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
362373
]
363374
#disable-next-line BCP036
364375
type: 'Extension/AppInsightsExtension/PartType/CuratedBladePerformancePinnedPart'
376+
#disable-next-line BCP037
365377
isAdapter: true
378+
#disable-next-line BCP037
366379
asset: {
367380
idInputName: 'ResourceId'
368381
type: 'ApplicationInsights'
369382
}
383+
#disable-next-line BCP037
370384
defaultMenuItemId: 'performance'
371385
}
372386
}
@@ -453,10 +467,12 @@ resource applicationInsightsDashboard 'Microsoft.Portal/dashboards@2020-09-01-pr
453467
]
454468
#disable-next-line BCP036
455469
type: 'Extension/AppInsightsExtension/PartType/MetricsExplorerBladePinnedPart'
470+
#disable-next-line BCP037
456471
asset: {
457472
idInputName: 'ComponentId'
458473
type: 'ApplicationInsights'
459474
}
475+
#disable-next-line BCP037
460476
defaultMenuItemId: 'browser'
461477
}
462478
}

infra/core/monitor/monitoring.bicep

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
metadata description = 'Creates an Application Insights instance and a Log Analytics workspace.'
22
param logAnalyticsName string
3+
param includeApplicationInsights bool = false
34
param applicationInsightsName string
45
param applicationInsightsDashboardName string = ''
56
param location string = resourceGroup().location
67
param tags object = {}
78

9+
810
module logAnalytics 'loganalytics.bicep' = {
911
name: 'loganalytics'
1012
params: {
@@ -14,7 +16,7 @@ module logAnalytics 'loganalytics.bicep' = {
1416
}
1517
}
1618

17-
module applicationInsights 'applicationinsights.bicep' = {
19+
module applicationInsights 'applicationinsights.bicep' = if(includeApplicationInsights) {
1820
name: 'applicationinsights'
1921
params: {
2022
name: applicationInsightsName

infra/main.bicep

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ module monitoring 'core/monitor/monitoring.bicep' = {
383383
params: {
384384
location: location
385385
tags: updatedTags
386-
includeDashboard: false
387386
includeApplicationInsights: true
388387
logAnalyticsName: !empty(logAnalyticsName) ? logAnalyticsName : '${abbrs.operationalInsightsWorkspaces}${resourceToken}'
389388
applicationInsightsName: !empty(applicationInsightsName) ? applicationInsightsName : '${abbrs.insightsComponents}${resourceToken}'

0 commit comments

Comments
 (0)