Skip to content

Commit 0074b2a

Browse files
committed
Made FilterPSDataFactories more readable
1 parent 8fa470a commit 0074b2a

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/ResourceManager/DataFactories/Commands.DataFactoryV2/Models/DataFactoryClient.DataFactories.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,20 @@ public virtual List<PSDataFactory> FilterPSDataFactories(DataFactoryFilterOption
105105
}
106106
var dataFactories = new List<PSDataFactory>();
107107

108-
if (filterOptions.DataFactoryName != null)
108+
if (filterOptions.DataFactoryName != null && filterOptions.ResourceGroupName != null)
109109
{
110110
dataFactories.Add(GetDataFactory(filterOptions.ResourceGroupName, filterOptions.DataFactoryName));
111111
}
112-
else if (filterOptions.ResourceGroupName == null)
112+
else if (filterOptions.ResourceGroupName == null && filterOptions.DataFactoryName == null)
113113
{
114114
dataFactories.AddRange(ListDataFactoriesBySubscription(filterOptions));
115115
}
116116
else
117117
{
118+
if(filterOptions.ResourceGroupName == null && filterOptions.DataFactoryName != null)
119+
{
120+
throw new Exception("ResourceGroupName name can't be null if factory name is not due to parameter sets. Should never reach this point");
121+
}
118122
dataFactories.AddRange(ListDataFactories(filterOptions));
119123
}
120124
return dataFactories;

0 commit comments

Comments
 (0)