Skip to content

Commit 03cfa01

Browse files
EmmaZhuHovsep
authored andcommitted
[Release 1.6.0] Add warning message for incoming breaking change on ShouldContinue and ShouldProcess (#2574)
* Add ShoudContinue/ShouldProcess breaking change Warning Message * Remove ShoudContinue/ShouldProcess breaking change Warning Message from File Cmdlet, as they don't use Force currently.
1 parent 2ff321b commit 03cfa01

File tree

7 files changed

+16
-1
lines changed

7 files changed

+16
-1
lines changed

ChangeLog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
##2016.07.11 version 1.6.0
2+
* Azure Storage
3+
* Change Tags Parameter to Tag, and add parameter alias Tags
4+
- New-AzureRmStorageAccount
5+
- Set-AzureRmStorageAccount
26
* Azure Network
37
* New cmdlet added for Virtual Network Peering
48
* Azure Redis Cache

src/ResourceManager/Storage/Commands.Management.Storage/StorageAccount/RemoveAzureStorageAccount.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public override void ExecuteCmdlet()
4444
{
4545
base.ExecuteCmdlet();
4646

47+
WriteWarning("Will add confirmation of executing the cmdlet and Force parameter in a future release. ");
48+
4749
this.StorageClient.StorageAccounts.Delete(
4850
this.ResourceGroupName,
4951
this.Name);

src/ResourceManager/Storage/Commands.Management.Storage/StorageAccount/SetAzureStorageAccount.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,9 @@ public override void ExecuteCmdlet()
101101
{
102102
base.ExecuteCmdlet();
103103

104+
WriteWarning("Will add confirmation of executing the cmdlet and Force parameter in a future release. ");
104105
WriteWarning("The usage of Tags parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
105-
106+
106107
StorageAccountUpdateParameters updateParameters = new StorageAccountUpdateParameters();
107108
if (this.SkuName != null)
108109
{

src/Storage/Commands.Storage/Blob/Cmdlet/RemoveAzureStorageContainerStoredAccessPolicy.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,8 @@ internal bool RemoveAzureContainerStoredAccessPolicy(IStorageBlobManagement loca
101101
[PermissionSet(SecurityAction.Demand, Name = "FullTrust")]
102102
public override void ExecuteCmdlet()
103103
{
104+
WriteWarning("Force parameter in this cmdlet will be removed in a future release.");
105+
104106
if (String.IsNullOrEmpty(Container) || String.IsNullOrEmpty(Policy)) return;
105107
bool success = RemoveAzureContainerStoredAccessPolicy(Channel, Container, Policy);
106108
string result = string.Empty;

src/Storage/Commands.Storage/File/Cmdlet/RemoveAzureStorageShareStoredAccessPolicy.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ internal bool RemoveAzureShareStoredAccessPolicy(IStorageFileManagement localCha
8484
[PermissionSet(SecurityAction.Demand, Name = "FullTrust")]
8585
public override void ExecuteCmdlet()
8686
{
87+
WriteWarning("Force parameter in this cmdlet will be removed in a future release.");
88+
8789
bool success = RemoveAzureShareStoredAccessPolicy(Channel, ShareName, Policy);
8890
string result = string.Empty;
8991

src/Storage/Commands.Storage/Queue/Cmdlet/RemoveAzureStorageQueueStoredAccessPolicy.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ internal virtual bool ConfirmRemove(string message)
9898
[PermissionSet(SecurityAction.Demand, Name = "FullTrust")]
9999
public override void ExecuteCmdlet()
100100
{
101+
WriteWarning("Force parameter in this cmdlet will be removed in a future release.");
102+
101103
if (String.IsNullOrEmpty(Queue) || String.IsNullOrEmpty(Policy)) return;
102104
bool success = RemoveAzureQueueStoredAccessPolicy(Channel, Queue, Policy);
103105
string result = string.Empty;

src/Storage/Commands.Storage/Table/Cmdlet/RemoveAzureStorageTableStoredAccessPolicy.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,8 @@ internal bool RemoveAzureTableStoredAccessPolicy(IStorageTableManagement localCh
9999
[PermissionSet(SecurityAction.Demand, Name = "FullTrust")]
100100
public override void ExecuteCmdlet()
101101
{
102+
WriteWarning("Force parameter in this cmdlet will be removed in a future release.");
103+
102104
if (String.IsNullOrEmpty(Table) || String.IsNullOrEmpty(Policy)) return;
103105
bool success = RemoveAzureTableStoredAccessPolicy(Channel, Table, Policy);
104106
string result = string.Empty;

0 commit comments

Comments
 (0)