[Storage] fix issue in get blob by tag (#17724)

* [Storage] fix issue in get blob by tag

* add change log and revise code

Author: blueww

src/Storage/Storage.Management/ChangeLog.md

@@ -18,6 +18,8 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fixed get blob by tag failure on Powershell 7.2.2
+    -  `Get-AzStorageBlobByTag`
 
 ## Version 4.4.0
 * Updated examples in reference documentation for `Close-AzStorageFileHandle`

src/Storage/Storage/Blob/Cmdlet/GetAzureStorageBlob.cs

@@ -379,50 +379,6 @@ internal async Task ListBlobsByPrefix(long taskId, IStorageBlobManagement localC
             }
         }
 
-        /// <summary>
-        /// list blobs by blob Tag
-        /// </summary>
-        /// <param name="containerName">container name</param>
-        /// <param name="prefix">blob preifx</param>
-        /// <returns>An enumerable collection of IListBlobItem</returns>
-        internal async Task ListBlobsByTag(long taskId, IStorageBlobManagement localChannel, string tagFilterSqlExpression)
-        {
-
-            BlobServiceClient blobServiceClient = Util.GetTrack2BlobServiceClient(localChannel.StorageContext, ClientOptions);
-
-            int listCount = InternalMaxCount;
-            int MaxListCount = 5000;
-            int requestCount = MaxListCount;
-            int realListCount = 0;
-            BlobContinuationToken continuationToken = ContinuationToken;
-            string track2ContinuationToken = this.ContinuationToken is null ? null : this.ContinuationToken.NextMarker;
-
-            do
-            {
-                requestCount = Math.Min(listCount, MaxListCount);
-                realListCount = 0;
-                IAsyncEnumerator<Page<TaggedBlobItem>> enumerator = blobServiceClient.FindBlobsByTagsAsync(tagFilterSqlExpression, CmdletCancellationToken)
-                    .AsPages(track2ContinuationToken, requestCount)
-                    .GetAsyncEnumerator();
-
-                Page<TaggedBlobItem> page;
-                await enumerator.MoveNextAsync().ConfigureAwait(false);
-                page = enumerator.Current;
-                foreach (TaggedBlobItem item in page.Values)
-                {
-                    BlobContainerClient track2container = blobServiceClient.GetBlobContainerClient(item.BlobContainerName);
-                    OutputStream.WriteObject(taskId, GetAzureStorageBlob(item, track2container, localChannel.StorageContext, page.ContinuationToken, ClientOptions));
-                    realListCount++;
-                }
-                track2ContinuationToken = page.ContinuationToken;
-
-                if (InternalMaxCount != int.MaxValue)
-                {
-                    listCount -= realListCount;
-                }
-            } while (listCount > 0 && !string.IsNullOrEmpty(track2ContinuationToken));          
-        }
-
         public static AzureStorageBlob GetAzureStorageBlob(BlobItem blobItem, BlobContainerClient track2container, AzureStorageContext context, string continuationToken = null, BlobClientOptions options = null)
         {
             BlobBaseClient blobClient = Util.GetTrack2BlobClient(track2container, blobItem.Name, context, blobItem.VersionId, blobItem.IsLatestVersion, blobItem.Snapshot, options, blobItem.Properties.BlobType);

src/Storage/Storage/Blob/Cmdlet/GetAzureStorageBlobByTag.cs

@@ -90,7 +90,7 @@ public GetAzureStorageBlobByTagCommand(IStorageBlobManagement channel)
         /// <summary>
         /// list blobs by blob Tag
         /// </summary>
-        internal async Task ListBlobsByTag(long taskId, IStorageBlobManagement localChannel, string tagFilterSqlExpression)
+        internal void ListBlobsByTag(IStorageBlobManagement localChannel, string tagFilterSqlExpression)
         {
 
             BlobServiceClient blobServiceClient = Util.GetTrack2BlobServiceClient(localChannel.StorageContext, ClientOptions);
@@ -106,16 +106,16 @@ internal async Task ListBlobsByTag(long taskId, IStorageBlobManagement localChan
             {
                 requestCount = Math.Min(listCount, MaxListCount);
                 realListCount = 0;
-                IAsyncEnumerator<Page<TaggedBlobItem>> enumerator = blobServiceClient.FindBlobsByTagsAsync(tagFilterSqlExpression, CmdletCancellationToken)
+                IEnumerator<Page<TaggedBlobItem>> enumerator = blobServiceClient.FindBlobsByTags(tagFilterSqlExpression, CmdletCancellationToken)
                     .AsPages(track2ContinuationToken, requestCount)
-                    .GetAsyncEnumerator();
+                    .GetEnumerator();
 
                 Page<TaggedBlobItem> page;
-                await enumerator.MoveNextAsync().ConfigureAwait(false);
+                enumerator.MoveNext();
                 page = enumerator.Current;
                 foreach (TaggedBlobItem item in page.Values)
                 {
-                    OutputStream.WriteObject(taskId, new AzureStorageBlob(item, Channel.StorageContext, page.ContinuationToken, ClientOptions, this.GetBlobProperty.IsPresent));
+                    WriteObject(new AzureStorageBlob(item, Channel.StorageContext, page.ContinuationToken, ClientOptions, this.GetBlobProperty.IsPresent));
                     realListCount++;
                 }
                 track2ContinuationToken = page.ContinuationToken;
@@ -133,12 +133,9 @@ internal async Task ListBlobsByTag(long taskId, IStorageBlobManagement localChan
         [PermissionSet(SecurityAction.Demand, Name = "FullTrust")]
         public override void ExecuteCmdlet()
         {
-            Func<long, Task> taskGenerator = null;
             IStorageBlobManagement localChannel = Channel;
 
-            taskGenerator = (taskId) => ListBlobsByTag(taskId, localChannel, this.TagFilterSqlExpression);    
-
-            RunTask(taskGenerator);
+            ListBlobsByTag(localChannel, this.TagFilterSqlExpression);
         }
     }
 }