Skip to content

Commit 069bfa5

Browse files
authored
[Tools] Use type fullname to avoid issue from class renaming. (#14147)
* Optimize for CI filter. * Add support for TargetModule * Avoid the issue caused by renaming class. * Avoid the issue caused by renaming class. Co-authored-by: wyunchi-ms <[email protected]>
1 parent aeb124d commit 069bfa5

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

tools/StaticAnalysis/IssueChecker/IssueChecker.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ public class IssueChecker : IStaticAnalyzer
3030
{
3131
private readonly List<(string, string)> exceptionLogInfoList = new List<(string, string)>()
3232
{
33-
("BreakingChangeIssues.csv", "BreakingChangeIssues"),
34-
("AssemblyVersionConflict.csv", "AssemblyVersionConflict"),
35-
("SharedAssemblyConflict.csv", "SharedAssemblyConflict"),
36-
("MissingAssemblies.csv", "MissingAssembly"),
37-
("ExtraAssemblies.csv", "ExtraAssembly"),
33+
("BreakingChangeIssues.csv", typeof(BreakingChangeIssue).FullName),
34+
("AssemblyVersionConflict.csv", typeof(AssemblyVersionConflict).FullName),
35+
("SharedAssemblyConflict.csv", typeof(SharedAssemblyConflict).FullName),
36+
("MissingAssemblies.csv", typeof(MissingAssembly).FullName),
37+
("ExtraAssemblies.csv", typeof(ExtraAssembly).FullName),
3838
};
3939
public AnalysisLogger Logger { get; set; }
4040

tools/StaticAnalysis/ReportRecordFactory.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,23 +28,23 @@ public static class ReportRecordFactory
2828
{
2929
public static IReportRecord Create(string type)
3030
{
31-
if (type.Equals("BreakingChangeIssue"))
31+
if (type.Equals(typeof(BreakingChangeIssue).FullName))
3232
{
3333
return new BreakingChangeIssue();
3434
}
35-
if (type.Equals("AssemblyVersionConflict"))
35+
if (type.Equals(typeof(AssemblyVersionConflict).FullName))
3636
{
3737
return new AssemblyVersionConflict();
3838
}
39-
if (type.Equals("SharedAssemblyConflict"))
39+
if (type.Equals(typeof(SharedAssemblyConflict).FullName))
4040
{
4141
return new SharedAssemblyConflict();
4242
}
43-
if (type.Equals("MissingAssembly"))
43+
if (type.Equals(typeof(MissingAssembly).FullName))
4444
{
4545
return new MissingAssembly();
4646
}
47-
if (type.Equals("ExtraAssembly"))
47+
if (type.Equals(typeof(ExtraAssembly).FullName))
4848
{
4949
return new ExtraAssembly();
5050
}

0 commit comments

Comments
 (0)