Fix for bug 2239174: Fixing secondaryDNS server to make it non mandatory.

Author: Sankaranarayanan Mahadevan

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceDetails/SetAzureStorSimpleDevice.cs

@@ -94,7 +94,7 @@ public override void ExecuteCmdlet()
 
                 // If the device is being configured for the first time, validate that mandatory params 
                 // for first setup have been provided
-                if (!deviceDetails.DeviceProperties.IsConfigUpdated && !ValidParamsForFirstDeviceConfiguration(StorSimpleNetworkConfig, TimeZone, SecondaryDnsServer))
+                if (!deviceDetails.DeviceProperties.IsConfigUpdated && !ValidParamsForFirstDeviceConfiguration(StorSimpleNetworkConfig, TimeZone))
                 {
                     throw new ArgumentException(Resources.MandatoryParamsMissingForInitialDeviceConfiguration);
                 }

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.Designer.cs

@@ -415,7 +415,7 @@
     <value>Could not persist secret</value>
   </data>
   <data name="DeviceNotConfiguredMessage" xml:space="preserve">
-    <value>The device name is not fully configured. Please complete the configuration and retry.</value>
+    <value>The device with the specified device name is not fully configured. Please complete the configuration and retry.</value>
   </data>
   <data name="DeviceNotRegisteredMessage" xml:space="preserve">
     <value>No StorSimple device is currently registered with this resource. Please register at least one device with the resource and then rerun this command.</value>

src/ServiceManagement/StorSimple/Commands.StorSimple/Properties/Resources.resx

@@ -473,7 +473,7 @@ internal void TrySetIPAddress(string data, out IPAddress ipAddress, string param
         /// Validate that all mandatory data for the first Device Configuration has been provided.
         /// </summary>
         /// <returns>bool indicating whether all mandatory data is there or not.</returns>
-        internal bool ValidParamsForFirstDeviceConfiguration(NetworkConfig[] netConfigs, TimeZoneInfo timeZone, string secondaryDnsServer)
+        internal bool ValidParamsForFirstDeviceConfiguration(NetworkConfig[] netConfigs, TimeZoneInfo timeZone)
         {
             if (netConfigs == null)
             {
@@ -485,8 +485,8 @@ internal bool ValidParamsForFirstDeviceConfiguration(NetworkConfig[] netConfigs,
             {
                 return false;
             }
-            // Timezone and Secondary Dns Server are also mandatory
-            if (timeZone == null || string.IsNullOrEmpty(secondaryDnsServer))
+            // Timezone is also mandatory
+            if (timeZone == null)
             {
                 return false;
             }