Fix default parameter sets for HubBgpConnection cmdlets. Minor fixes to the help files for HubBgpConnection. (#15929)

Co-authored-by: Andrii Kalinichenko <[email protected]>

Author: AndriiKalinichenko

src/Network/Network/Cortex/HubBgpConnection/NewAzVirtualHubBgpConnectionCommand.cs

@@ -24,7 +24,7 @@ namespace Microsoft.Azure.Commands.Network
 
     [Cmdlet(VerbsCommon.New,
         ResourceManager.Common.AzureRMConstants.AzurePrefix + "VirtualHubBgpConnection",
-        DefaultParameterSetName = CortexParameterSetNames.ByVirtualHubName,
+        DefaultParameterSetName = CortexParameterSetNames.ByVirtualHubName + CortexParameterSetNames.ByHubVirtualNetworkConnectionObject,
         SupportsShouldProcess = true),
         OutputType(typeof(PSBgpConnection))]
     public class NewAzVirtualHubBgpConnectionCommand : HubBgpConnectionBaseCmdlet

src/Network/Network/Cortex/HubBgpConnection/UpdateAzVirtualHubBgpConnectionCommand.cs

@@ -26,7 +26,7 @@ namespace Microsoft.Azure.Commands.Network
 
     [Cmdlet("Update",
         ResourceManager.Common.AzureRMConstants.AzurePrefix + "VirtualHubBgpConnection",
-        DefaultParameterSetName = CortexParameterSetNames.ByVirtualHubName,
+        DefaultParameterSetName = CortexParameterSetNames.ByVirtualHubName + CortexParameterSetNames.ByHubVirtualNetworkConnectionObject,
         SupportsShouldProcess = true),
         OutputType(typeof(PSBgpConnection))]
     public class UpdateAzVirtualHubBgpConnectionCommand : HubBgpConnectionBaseCmdlet

src/Network/Network/help/Get-AzVirtualHubBgpConnection.md

@@ -86,7 +86,7 @@ This cmdlet lists all the Virtual WAN Hub BGP Connections starting with "test" u
 The credentials, account, tenant, and subscription used for communication with Azure.
 
 ```yaml
-Type: IAzureContextContainer
+Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
 Parameter Sets: (All)
 Aliases: AzContext, AzureRmContext, AzureCredential
 
@@ -101,7 +101,7 @@ Accept wildcard characters: False
 The resource name.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByVirtualHubName, ByVirtualHubObject
 Aliases: ResourceName, BgpConnectionName
 
@@ -116,7 +116,7 @@ Accept wildcard characters: True
 The resource group name.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByVirtualHubName
 Aliases:
 
@@ -131,7 +131,7 @@ Accept wildcard characters: False
 The resource id.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByHubBgpConnectionResourceId
 Aliases: BgpConnectionId
 
@@ -161,7 +161,7 @@ Accept wildcard characters: False
 The virtual hub name.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByVirtualHubName
 Aliases: ParentResourceName, ParentVirtualHubName
 

src/Network/Network/help/New-AzVirtualHubBgpConnection.md

@@ -12,13 +12,7 @@ The New-AzVirtualHubBgpConnection cmdlet creates a HubBgpConnection resource tha
 
 ## SYNTAX
 
-### ByVirtualHubName (Default)
-```
-New-AzVirtualHubBgpConnection -PeerIp <String> -PeerAsn <UInt32> -Name <String> [-AsJob]
- [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
-```
-
-### ByVirtualHubNameByHubVirtualNetworkConnectionObject
+### ByVirtualHubNameByHubVirtualNetworkConnectionObject (Default)
 ```
 New-AzVirtualHubBgpConnection -ResourceGroupName <String> -VirtualHubName <String> -PeerIp <String>
  -PeerAsn <UInt32> -Name <String> -VirtualHubVnetConnection <PSHubVirtualNetworkConnection> [-AsJob]

src/Network/Network/help/Remove-AzVirtualHubBgpConnection.md

@@ -69,7 +69,7 @@ The above will remove a Virtual WAN Hub BGP Connection using the BGP Connection
 Run cmdlet in the background
 
 ```yaml
-Type: SwitchParameter
+Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases:
 
@@ -80,26 +80,11 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -Confirm
-Prompts you for confirmation before running the cmdlet.
-
-```yaml
-Type: SwitchParameter
-Parameter Sets: (All)
-Aliases: cf
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### -DefaultProfile
 The credentials, account, tenant, and subscription used for communication with Azure.
 
 ```yaml
-Type: IAzureContextContainer
+Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
 Parameter Sets: (All)
 Aliases: AzContext, AzureRmContext, AzureCredential
 
@@ -114,7 +99,7 @@ Accept wildcard characters: False
 Do not ask for confirmation if you want to overwrite a resource
 
 ```yaml
-Type: SwitchParameter
+Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases:
 
@@ -129,7 +114,7 @@ Accept wildcard characters: False
 The virtual hub bgp connection resource.
 
 ```yaml
-Type: PSBgpConnection
+Type: Microsoft.Azure.Commands.Network.Models.PSBgpConnection
 Parameter Sets: ByHubBgpConnectionObject
 Aliases: VirtualHubBgpConnection
 
@@ -144,7 +129,7 @@ Accept wildcard characters: False
 The resource name.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByVirtualHubName, ByVirtualHubObject
 Aliases: ResourceName, BgpConnectionName
 
@@ -159,7 +144,7 @@ Accept wildcard characters: False
 Returns an object representing the item on which this operation is being performed.
 
 ```yaml
-Type: SwitchParameter
+Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases:
 
@@ -174,7 +159,7 @@ Accept wildcard characters: False
 The resource group name.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByVirtualHubName
 Aliases:
 
@@ -189,7 +174,7 @@ Accept wildcard characters: False
 The resource id.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByHubBgpConnectionResourceId
 Aliases: BgpConnectionId
 
@@ -219,7 +204,7 @@ Accept wildcard characters: False
 The virtual hub name.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: ByVirtualHubName
 Aliases: ParentResourceName, ParentVirtualHubName
 
@@ -230,12 +215,27 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
+### -Confirm
+Prompts you for confirmation before running the cmdlet.
+
+```yaml
+Type: System.Management.Automation.SwitchParameter
+Parameter Sets: (All)
+Aliases: cf
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -WhatIf
 Shows what would happen if the cmdlet runs.
 The cmdlet is not run.
 
 ```yaml
-Type: SwitchParameter
+Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases: wi