Adding warning for location being invalid.

Author: NehaRaje

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/PSRecoveryServicesClient/PSRecoveryServicesClientHelper.cs

@@ -111,11 +111,14 @@ public void ValidateSubscriptionAccountAssociation(string azureSubscriptionId)
         /// <param name="azureSubscription">Subscription ID</param>
         /// <param name="azureStorageAccount">Storage Account details</param>
         /// <param name="vaultLocation">Current Vault Location</param>
-        /// <returns>Validation successful</returns>
-        public bool ValidateStorageAccountAssociation(
+        /// <param name="validationSuccessful">Out variable to indicate if validation was successful</param>
+        /// <param name="locationValid">Out variable to indicate if location of storage account is valid</param>
+        public void ValidateStorageAccountAssociation(
             string azureSubscription,
             string azureStorageAccount,
-            string vaultLocation)
+            string vaultLocation,
+            out bool validationSuccessful,
+            out bool locationValid)
         {
             if (string.IsNullOrEmpty(azureSubscription))
             {
@@ -142,7 +145,7 @@ public bool ValidateStorageAccountAssociation(
             }
             catch (Exception)
             {
-                return false;
+                validationSuccessful = false;
             }
 
             foreach (var storage in azureStorageListResponse.StorageAccounts)
@@ -160,28 +163,25 @@ public bool ValidateStorageAccountAssociation(
 
             if (!associatedAccount)
             {
-                return false;
+                validationSuccessful = false;
             }
 
             // Validate that the Geo Location of the storage account is the same as that of the vault.
             if (string.IsNullOrEmpty(currentStorageAccount.Properties.Location))
             {
-                return false;
+                validationSuccessful = false;
             }
 
             if (0 != string.Compare(
                 currentStorageAccount.Properties.Location,
                 vaultLocation,
                 StringComparison.OrdinalIgnoreCase))
             {
-                throw new InvalidOperationException(
-                    string.Format(
-                    Properties.Resources.StorageIsNotInTheSameLocationAsVault,
-                    currentStorageAccount.Properties.Location,
-                    vaultLocation));
+                locationValid = true;
             }
 
-            return true;
+            validationSuccessful = true;
+            locationValid = true;
         }
     }
 }

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.Designer.cs

@@ -253,4 +253,7 @@ Please provide a storage account with the same location as that of the vault.</v
   <data name="StorageAccountValidationUnsuccessful" xml:space="preserve">
     <value>The Subscription or Storage account couldn’t be validated. For failovers to be successful, the Subscription should belong to your account, the Storage account to the Subscription and Storage account location must be the same as location of your Vault.</value>
   </data>
+  <data name="LocationInvalidWarning" xml:space="preserve">
+    <value>The Location couldn’t be validated. For failovers to be successful, Storage account location must be the same as location of your Vault.</value>
+  </data>
 </root>

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.resx

@@ -207,12 +207,26 @@ private void EnterpriseToAzureProtectionProfileObject()
             }
 
             // Verify whether the storage account is associated with the subscription or not.
-            bool validationSuccessful = RecoveryServicesClient.ValidateStorageAccountAssociation(
+            bool validationSuccessful;
+            bool locationValid;
+            RecoveryServicesClient.ValidateStorageAccountAssociation(
                 this.RecoveryAzureSubscription,
                 this.RecoveryAzureStorageAccount,
-                this.GetCurrentValutLocation());
+                this.GetCurrentValutLocation(),
+                out validationSuccessful,
+                out locationValid);
 
-            if (!validationSuccessful)
+            if (!locationValid)
+            {
+                this.WriteWarning(string.Format(Properties.Resources.StorageIsNotInTheSameLocationAsVault));
+                this.ConfirmAction(
+                    this.Force.IsPresent,
+                    string.Format(Properties.Resources.LocationInvalidWarning, this.targetName),
+                    string.Format(Properties.Resources.NewProtectionProfileObjectWhatIfMessage),
+                    this.targetName,
+                    new Action(this.ProceedToCreateProtectionProfileObject));
+            }
+            else if (!validationSuccessful)
             {
                 this.WriteWarning(string.Format(Properties.Resources.StorageAccountValidationUnsuccessful));