Adding support for -All for Import DC, Start Migration Plan and Confirm Migration status cmdlets (also, deprecating support for empty/NULL values of LegacyContainerNames parameter for the same).

Author: arramach

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/ConfirmAzureStorSimpleLegacyVolumeContainerStatus.cs

@@ -26,6 +26,9 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple.Cmdlets
     [Cmdlet(VerbsLifecycle.Confirm, "AzureStorSimpleLegacyVolumeContainerStatus")]
     public class ConfirmAzureStorSimpleLegacyVolumeContainerStatus : StorSimpleCmdletBase
     {
+        public const string AllContainers = "ALL";
+        public const string SpecificContainers = "DCSpecific";
+
         [Parameter(Mandatory = true, Position = 0, HelpMessage = StorSimpleCmdletHelpMessage.MigrationConfigId)]
         [ValidateNotNullOrEmpty]
         public string LegacyConfigId { get; set; }
@@ -34,20 +37,32 @@ public class ConfirmAzureStorSimpleLegacyVolumeContainerStatus : StorSimpleCmdle
         [ValidateSet("Commit", "Rollback", IgnoreCase = true)]
         public string MigrationOperation { get; set; }
 
-        [Parameter(Mandatory = false, Position = 2,
+        [Parameter(Mandatory = true, Position = 2, ParameterSetName = SpecificContainers,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationLegacyDataContainers)]
         public string[] LegacyContainerNames { get; set; }
 
+        [Parameter(Mandatory = true, Position = 2, ParameterSetName = AllContainers,
+            HelpMessage = StorSimpleCmdletHelpMessage.MigrationAllContainers)]
+        public SwitchParameter All { get; set; }
+
         public override void ExecuteCmdlet()
         {
             try
             {
                 var confirmMigrationRequest = new MigrationConfirmStatusRequest();
                 confirmMigrationRequest.Operation =
                     (MigrationOperation) Enum.Parse(typeof (MigrationOperation), MigrationOperation, true);
-                confirmMigrationRequest.DataContainerNameList = (null != LegacyContainerNames)
-                    ? new List<string>(LegacyContainerNames.ToList().Distinct(StringComparer.InvariantCultureIgnoreCase))
-                    : new List<string>();
+                if (All.IsPresent)
+                {
+                    confirmMigrationRequest.DataContainerNameList = new List<string>();
+                }
+                else
+                {
+                    confirmMigrationRequest.DataContainerNameList =
+                            new List<string>(LegacyContainerNames.ToList().Distinct(
+                                StringComparer.InvariantCultureIgnoreCase));
+                }
+
                 var status = StorSimpleClient.ConfirmLegacyVolumeContainerStatus(LegacyConfigId, confirmMigrationRequest);
                 MigrationCommonModelFormatter opFormatter = new MigrationCommonModelFormatter();
                 WriteObject(opFormatter.GetResultMessage(Resources.ConfirmMigrationSuccessMessage, status));

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/ImportAzureStorSimpleLegacyVolumeContainer.cs

@@ -25,14 +25,21 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple.Cmdlets
     [Cmdlet(VerbsData.Import, "AzureStorSimpleLegacyVolumeContainer")]
     public class ImportAzureStorSimpleLegacyVolumeContainer : StorSimpleCmdletBase
     {
+        public const string AllContainers = "ALL";
+        public const string SpecificContainers = "DCSpecific";
+
         [Parameter(Mandatory = true, Position = 0, HelpMessage = StorSimpleCmdletHelpMessage.MigrationConfigId)]
         [ValidateNotNullOrEmpty]
         public string LegacyConfigId { get; set; }
 
-        [Parameter(Mandatory = false, Position = 1,
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = SpecificContainers,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationLegacyDataContainers)]
         public string[] LegacyContainerNames { get; set; }
 
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = AllContainers,
+            HelpMessage = StorSimpleCmdletHelpMessage.MigrationAllContainers)]
+        public SwitchParameter All { get; set; }        
+
         [Parameter(Mandatory = false, Position = 2,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationImportDCWithSkipACRs)]
         public SwitchParameter SkipACRs { get; set; }
@@ -45,9 +52,17 @@ public override void ExecuteCmdlet()
             try
             {
                 var importDataContainerRequest = new MigrationImportDataContainerRequest();
-                importDataContainerRequest.DataContainerNames = (null != LegacyContainerNames)
-                    ? new List<string>(LegacyContainerNames.ToList().Distinct(StringComparer.InvariantCultureIgnoreCase))
-                    : new List<string>();
+                if(All.IsPresent)
+                {
+                    importDataContainerRequest.DataContainerNames = new List<string>();
+                }
+                else
+                {
+                    importDataContainerRequest.DataContainerNames =
+                            new List<string>(LegacyContainerNames.ToList().Distinct(
+                                StringComparer.InvariantCultureIgnoreCase));
+                }
+
                 importDataContainerRequest.ForceOnOtherDevice = Force.IsPresent;
                 importDataContainerRequest.SkipACRs = SkipACRs.IsPresent;
 

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Migration/StartAzureStorSimpleLegacyVolumeContainerMigrationPlan.cs

@@ -25,23 +25,37 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple.Cmdlets
     [Cmdlet(VerbsLifecycle.Start, "AzureStorSimpleLegacyVolumeContainerMigrationPlan")]
     public class StartAzureStorSimpleLegacyVolumeContainerMigrationPlan : StorSimpleCmdletBase
     {
+        public const string AllContainers = "ALL";
+        public const string SpecificContainers = "DCSpecific";
+
         [Parameter(Mandatory = true, Position = 0, HelpMessage = StorSimpleCmdletHelpMessage.MigrationConfigId)]
         [ValidateNotNullOrEmpty]
         public string LegacyConfigId { get; set; }
 
-        [Parameter(Mandatory = false, Position = 1,
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = SpecificContainers,
             HelpMessage = StorSimpleCmdletHelpMessage.MigrationLegacyDataContainers)]
         public string[] LegacyContainerNames { get; set; }
 
+        [Parameter(Mandatory = true, Position = 1, ParameterSetName = AllContainers,
+            HelpMessage = StorSimpleCmdletHelpMessage.MigrationAllContainers)]
+        public SwitchParameter All { get; set; }
+
         public override void ExecuteCmdlet()
         {
             try
             {
                 var startMigrationPlanRequest = new MigrationPlanStartRequest();
                 startMigrationPlanRequest.ConfigId = LegacyConfigId;
-                startMigrationPlanRequest.DataContainerNameList = (null != LegacyContainerNames)
-                    ? new List<string>(LegacyContainerNames.ToList().Distinct(StringComparer.InvariantCultureIgnoreCase))
-                    : new List<string>();
+                if (All.IsPresent)
+                {
+                    startMigrationPlanRequest.DataContainerNameList = new List<string>();
+                }
+                else
+                {
+                    startMigrationPlanRequest.DataContainerNameList =
+                            new List<string>(LegacyContainerNames.ToList().Distinct(
+                                StringComparer.InvariantCultureIgnoreCase));
+                }
 
                 var status = StorSimpleClient.StartLegacyVolumeContainerMigrationPlan(startMigrationPlanRequest);
                 MigrationCommonModelFormatter opFormatter = new MigrationCommonModelFormatter();

src/ServiceManagement/StorSimple/Commands.StorSimple/StorSimpleCmdletHelpMessage.cs

@@ -127,6 +127,7 @@ internal static class StorSimpleCmdletHelpMessage
         public const string MigrationTargetDevice = "The target appliance to which migration needs to be performed";
         public const string MigrationConfigDecryptionKey = "The key to decrypt the legacy appliance config file";
         public const string MigrationLegacyDataContainers = "Names of data containers to be migrated seperated by ','";
+        public const string MigrationAllContainers = "All data containers will be considered for migration";
         public const string MigrationConfigId = "Legacy config id";
         public const string MigrationOperation = "Commit or Rollback";
         public const string MigrationImportDCByForce = "Force import data container on a different device even if data container has been imported on a different device";