Skip to content

Commit 080880e

Browse files
committed
Resolve comments.
1 parent 06eaf39 commit 080880e

File tree

6 files changed

+29
-4
lines changed

6 files changed

+29
-4
lines changed

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Commands.Resources.Rest.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@
195195
<Compile Include="SdkModels\Deployments\PSDeploymentObject.cs" />
196196
<Compile Include="SdkModels\Deployments\PSDeploymentOperation.cs" />
197197
<Compile Include="SdkModels\Deployments\PSResourceGroupDeployment.cs" />
198+
<Compile Include="SdkModels\Deployments\PSTemplatePath.cs" />
198199
<Compile Include="SdkModels\Deployments\TemplateFile.cs" />
199200
<Compile Include="SdkModels\Deployments\TemplateFileParameterV1.cs" />
200201
<Compile Include="SdkModels\Deployments\TemplateFileParameterv2.cs" />

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Deployments/NewAzureDeploymentCmdlet.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class NewAzureDeploymentCmdlet : ResourceWithParameterCmdletBase, IDynami
4040
public string Location { get; set; }
4141

4242
[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The deployment debug log level.")]
43-
[ValidateSet("RequestContent", "ResponseContent", "All", "None", IgnoreCase = true)]
43+
[PSArgumentCompleter("RequestContent", "ResponseContent", "All", "None")]
4444
public string DeploymentDebugLogLevel { get; set; }
4545

4646
[Parameter(Mandatory = false, HelpMessage = "Run cmdlet in the background")]

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Deployments/RemoveAzureDeploymentCmdlet.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ public class RemoveAzureDeploymentCmdlet : ResourceManagerCmdletBase
5757
ValueFromPipeline = true, HelpMessage = "The deployment object.")]
5858
public PSDeployment InputObject { get; set; }
5959

60+
[Parameter(Mandatory = false, HelpMessage = "Run cmdlet in the background")]
61+
public SwitchParameter AsJob { get; set; }
62+
6063
public override void ExecuteCmdlet()
6164
{
6265
ConfirmAction(

src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Deployments/SaveAzureDeploymentTemplateCmdlet.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation
2323
/// Saves the deployment template to a file on disk.
2424
/// </summary>
2525
[Cmdlet(VerbsData.Save, "AzureRmDeploymentTemplate", SupportsShouldProcess = true,
26-
DefaultParameterSetName = SaveAzureDeploymentTemplateCmdlet.DeploymentNameParameterSet), OutputType(typeof(PSObject))]
26+
DefaultParameterSetName = SaveAzureDeploymentTemplateCmdlet.DeploymentNameParameterSet), OutputType(typeof(PSTemplatePath))]
2727
public class SaveAzureDeploymentTemplateCmdlet : ResourceManagerCmdletBase
2828
{
2929
/// <summary>
@@ -85,7 +85,7 @@ protected override void OnProcessRecord()
8585
overwrite: this.Force,
8686
shouldContinue: ShouldContinue);
8787

88-
WriteObject(PowerShellUtilities.ConstructPSObject(null, "Path", path));
88+
WriteObject(new PSTemplatePath() { Path = path });
8989
}
9090
}
9191
}
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
// ----------------------------------------------------------------------------------
2+
//
3+
// Copyright Microsoft Corporation
4+
// Licensed under the Apache License, Version 2.0 (the "License");
5+
// you may not use this file except in compliance with the License.
6+
// You may obtain a copy of the License at
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
// Unless required by applicable law or agreed to in writing, software
9+
// distributed under the License is distributed on an "AS IS" BASIS,
10+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
11+
// See the License for the specific language governing permissions and
12+
// limitations under the License.
13+
// ----------------------------------------------------------------------------------
14+
15+
namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels
16+
{
17+
public class PSTemplatePath
18+
{
19+
public string Path { get; set; }
20+
}
21+
}

src/ResourceManager/Resources/Commands.Resources/help/Save-AzureRmDeploymentTemplate.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable
192192
193193
## OUTPUTS
194194
195-
### System.Management.Automation.PSObject
195+
### System.Management.Automation.PSTemplatePath
196196
197197
## NOTES
198198

0 commit comments

Comments
 (0)