Reivew comments updated

Author: Ajit Navasare (MINDTREE LIMITED)

src/ResourceManager/Relay/Commands.Relay.Test/Commands.Relay.Test.csproj

@@ -29,9 +29,7 @@
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
-    <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
-    <DelaySign>true</DelaySign>
     <DebugType>pdbonly</DebugType>
     <Optimize>true</Optimize>
     <OutputPath>bin\Release\</OutputPath>
@@ -143,7 +141,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="ScenarioTests\OperationsListTest.cs" />
-    <Compile Include="ScenarioTests\CheckNameAvailabilityTests.cs" />
+    <Compile Include="ScenarioTests\TestAzureRmRelayNameTests.cs" />
     <Compile Include="ScenarioTests\Namespace.cs" />
     <Compile Include="ScenarioTests\RelayController.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
@@ -159,11 +157,10 @@
     <None Include="packages.config">
       <SubType>Designer</SubType>
     </None>
-    <None Include="ScenarioTests\Common.ps1" />
     <None Include="ScenarioTests\OperationsListTest.ps1">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Include="ScenarioTests\CheckNameAvailabilityTests.ps1">
+    <None Include="ScenarioTests\TestAzureRmRelayNameTests.ps1">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
     <None Include="ScenarioTests\RelayNamespaceTests.ps1">
@@ -178,9 +175,6 @@
     <None Include="ScenarioTests\WcfRelayTests.ps1">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Include="SessionRecords\Microsoft.Azure.Commands.Relay.Test.ScenarioTests.CheckNameAvailabilityTests\CheckNameAvailability.json">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Relay.Test.ScenarioTests.HybridConnectionsTests\HybridConnectionsAuthorizationRulesCRUD.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
@@ -199,6 +193,9 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Relay.Test.ScenarioTests.RelayNamespaceTests\RelayNamespaceCRUD.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Include="SessionRecords\Microsoft.Azure.Commands.Relay.Test.ScenarioTests.TestAzureRmRelayNameTests\CheckNameAvailability.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Relay.Test.ScenarioTests.WcfRelayTests\WcfRelayAuthorizationRulesCRUD.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

src/ResourceManager/Relay/Commands.Relay.Test/ScenarioTests/Common.ps1

@@ -360,13 +360,13 @@ function RelayAuthTests
 
 	# Cleanup
 	Write-Debug "Delete the created Namespace AuthorizationRule"
-    $result = Remove-AzureRmRelayAuthorizationRule -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $authRuleName
+    $result = Remove-AzureRmRelayAuthorizationRule -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $authRuleName -Force
 
 	Write-Debug "Delete the created WcfRelay AuthorizationRule"
-    $result = Remove-AzureRmRelayAuthorizationRule -ResourceGroupName $resourceGroupName -Namespace $namespaceName -WcfRelay $wcfRelayName -Name $WcfRelayAuthRuleName
+    $result = Remove-AzureRmRelayAuthorizationRule -ResourceGroupName $resourceGroupName -Namespace $namespaceName -WcfRelay $wcfRelayName -Name $WcfRelayAuthRuleName -Force
 
     Write-Debug "Delete the created HybridConnection AuthorizationRule"
-    $result = Remove-AzureRmRelayAuthorizationRule -ResourceGroupName $resourceGroupName -Namespace $namespaceName -HybridConnection $HybridConnectionsName -Name $HybirdConnectionAuthRuleName
+    $result = Remove-AzureRmRelayAuthorizationRule -ResourceGroupName $resourceGroupName -Namespace $namespaceName -HybridConnection $HybridConnectionsName -Name $HybirdConnectionAuthRuleName -Force
 
 
 	Write-Debug "Delete the WcfRelay"

src/ResourceManager/Relay/Commands.Relay.Test/ScenarioTests/RelayAuthorizationRulesTests.ps1

@@ -19,9 +19,9 @@ namespace Microsoft.Azure.Commands.Relay.Test.ScenarioTests
     using ServiceManagemenet.Common.Models;
     using Xunit;
     using Xunit.Abstractions;
-    public class CheckNameAvailabilityTests : RMTestBase
+    public class TestAzureRmRelayNameTests : RMTestBase
     {
-        public CheckNameAvailabilityTests(ITestOutputHelper output)
+        public TestAzureRmRelayNameTests(ITestOutputHelper output)
         {
             XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
         }
@@ -30,7 +30,7 @@ public CheckNameAvailabilityTests(ITestOutputHelper output)
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void CheckNameAvailability()
         {
-            RelayController.NewInstance.RunPsTest("CheckNameAvailabilityTests");
+            RelayController.NewInstance.RunPsTest("TestAzureRmRelayNameTests");
         }
     }
 }

src/ResourceManager/Relay/Commands.Relay.Test/ScenarioTests/CheckNameAvailabilityTests.cs renamed to src/ResourceManager/Relay/Commands.Relay.Test/ScenarioTests/TestAzureRmRelayNameTests.cs

@@ -53,7 +53,7 @@ function Get-AuthorizationRuleName
 .SYNOPSIS
 Tests Relay Namespace CheckNameAvailability operations.
 #>
-function CheckNameAvailabilityTests 
+function TestAzureRmRelayNameTests 
 {
 	# Setup    
 	$location = "West US"