Fixing a bug with import/export cmdlets not able to be used with v12 server.

Fixing a bug where some cultures would convert 12.0 to "12,0" causing failures.

Author: akromm-zz

src/ServiceManagement/Sql/Commands.SqlDatabase/Commands.SqlDatabase.csproj

@@ -196,6 +196,7 @@
     <Compile Include="Services\Common\SqlDatabaseExceptionHandler.cs" />
     <Compile Include="Services\Common\ManagementServiceExceptionInfo.cs" />
     <Compile Include="Services\Constants.cs" />
+    <Compile Include="Services\Server\ISqlServerConnectionInformation.cs" />
     <Compile Include="Services\Server\RecoverableDatabaseExtensions.cs" />
     <Compile Include="Services\Server\DatabaseCopyExtensions.cs" />
     <Compile Include="Services\ImportExport\ImportExportRequest.cs" />

src/ServiceManagement/Sql/Commands.SqlDatabase/Database/Cmdlet/StartAzureSqlDatabaseExport.cs

@@ -51,12 +51,13 @@ public class StartAzureSqlDatabaseExport : SqlDatabaseCmdletBase
         #region Parameters
 
         /// <summary>
-        /// Gets or sets the context for connecting to the server
+        /// Gets or sets the connection information for connecting to the server
         /// </summary>
         [Parameter(Mandatory = true, Position = 0,
-            HelpMessage = "The context for connecting to the server")]
+            HelpMessage = "The connection information for connecting to a server. " +
+            "This can be an Azure SQL Server connection context that uses username with password.")]
         [ValidateNotNullOrEmpty]
-        public ServerDataServiceSqlAuth SqlConnectionContext { get; set; }
+        public ISqlServerConnectionInformation SqlConnectionContext { get; set; }
 
         /// <summary>
         /// Gets or sets the destination storage container for the blob

src/ServiceManagement/Sql/Commands.SqlDatabase/Database/Cmdlet/StartAzureSqlDatabaseImport.cs

@@ -51,12 +51,13 @@ public class StartAzureSqlDatabaseImport : SqlDatabaseCmdletBase
         #region Parameters
 
         /// <summary>
-        /// Gets or sets the context for connecting to the server
+        /// Gets or sets the connection information for connecting to the server
         /// </summary>
         [Parameter(Mandatory = true, Position = 0,
-            HelpMessage = "The context for connecting to the server")]
+            HelpMessage = "The connection information for connecting to a server. " +
+            "This can be an Azure SQL Server connection context that uses username with password.")]
         [ValidateNotNullOrEmpty]
-        public ServerDataServiceSqlAuth SqlConnectionContext { get; set; }
+        public ISqlServerConnectionInformation SqlConnectionContext { get; set; }
 
         /// <summary>
         /// Gets or sets the storage container object containing the blob

src/ServiceManagement/Sql/Commands.SqlDatabase/Server/Cmdlet/NewAzureSqlDatabaseServer.cs

@@ -117,7 +117,7 @@ internal SqlDatabaseServerContext NewAzureSqlDatabaseServerProcess(
                     Location = location,
                     AdministratorUserName = adminLogin,
                     AdministratorPassword = adminLoginPassword,
-                    Version = version.HasValue ? version.Value.ToString("F1") : null
+                    Version = version.HasValue ? version.Value.ToString("F1", CultureInfo.InvariantCulture) : null
                 });
 
             var newServer = sqlManagementClient.Servers.List().Servers.Where(s => s.Name == response.ServerName).FirstOrDefault();

src/ServiceManagement/Sql/Commands.SqlDatabase/Services/Server/ISqlServerConnectionInformation.cs

@@ -0,0 +1,34 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using Microsoft.WindowsAzure.Commands.SqlDatabase.Services.Common;
+
+namespace Microsoft.WindowsAzure.Commands.SqlDatabase.Services.Server
+{
+    /// <summary>
+    /// Interface for defining information needed to connect to a server using SQL auth.
+    /// </summary>
+    public interface ISqlServerConnectionInformation
+    {
+        /// <summary>
+        /// The name of the server
+        /// </summary>
+        string ServerName { get; }
+
+        /// <summary>
+        /// The SQL authentication credentials.
+        /// </summary>
+        SqlAuthenticationCredentials SqlCredentials { get; }
+    }
+}

src/ServiceManagement/Sql/Commands.SqlDatabase/Services/Server/ServerDataServiceSqlAuth.cs

@@ -31,7 +31,7 @@ namespace Microsoft.WindowsAzure.Commands.SqlDatabase.Services.Server
     /// <summary>
     /// Implementation of the <see cref="IServerDataServiceContext"/> with Sql Authentication.
     /// </summary>
-    public partial class ServerDataServiceSqlAuth : ServerDataServiceContext, IServerDataServiceContext
+    public partial class ServerDataServiceSqlAuth : ServerDataServiceContext, IServerDataServiceContext, ISqlServerConnectionInformation
     {
         #region Constants
 

src/ServiceManagement/Sql/Commands.SqlDatabase/Services/Server/SqlAuthContextFactory.cs

@@ -92,8 +92,7 @@ public static IServerDataServiceContext GetContext(
                 context = new TSqlConnectionContext(
                     sessionActivityId,
                     manageUrl.Host,
-                    credentials.UserName,
-                    credentials.Password);
+                    credentials);
             }
             else
             {

src/ServiceManagement/Sql/Commands.SqlDatabase/Services/Server/TSqlConnectionContext.cs

@@ -12,6 +12,7 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------
 
+using Microsoft.WindowsAzure.Commands.SqlDatabase.Services.Common;
 using System;
 using System.Collections.Generic;
 using System.Data.Common;
@@ -22,7 +23,7 @@
 
 namespace Microsoft.WindowsAzure.Commands.SqlDatabase.Services.Server
 {
-    public class TSqlConnectionContext : IServerDataServiceContext
+    public class TSqlConnectionContext : IServerDataServiceContext, ISqlServerConnectionInformation
     {
         /// <summary>
         /// Timeout duration for commands
@@ -122,6 +123,17 @@ public string ServerName
             }
         }
 
+        /// <summary>
+        /// Gets the SQL credentials for connecting to the server.
+        /// </summary>
+        public SqlAuthenticationCredentials SqlCredentials
+        {
+            get
+            {
+                return credentials;
+            }
+        }
+
         /// <summary>
         /// Contains the connection string necessary to connect to the server
         /// </summary>
@@ -142,6 +154,11 @@ public string ServerName
         /// </summary>
         private string serverName;
 
+        /// <summary>
+        /// The sql connection credetials
+        /// </summary>
+        private SqlAuthenticationCredentials credentials;
+
         /// <summary>
         /// Helper function to generate the SqlConnectionStringBuilder
         /// </summary>
@@ -183,14 +200,14 @@ private DbConnection CreateConnection()
         /// <summary>
         /// Creates an instance of a SQLAuth to TSql class
         /// </summary>
-        /// <param name="fullyQualifiedServerName"></param>
-        /// <param name="username"></param>
-        /// <param name="password"></param>
-        public TSqlConnectionContext(Guid sessionActivityId, string fullyQualifiedServerName, string username, string password)
+        /// <param name="fullyQualifiedServerName">The full server name</param>
+        /// <param name="credentials">The login credentials for the server</param>
+        public TSqlConnectionContext(Guid sessionActivityId, string fullyQualifiedServerName, SqlAuthenticationCredentials credentials)
         {
             this.sessionActivityId = sessionActivityId;
             this.clientRequestId = SqlDatabaseCmdletBase.GenerateClientTracingId();
-            builder = GenerateSqlConnectionBuilder(fullyQualifiedServerName, username, password);
+            this.credentials = credentials;
+            builder = GenerateSqlConnectionBuilder(fullyQualifiedServerName, credentials.UserName, credentials.Password);
         }
 
         /// <summary>