removed position settings for restore

Author: siddharth7

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup.Models/CommonModels/Enums.cs

@@ -320,7 +320,7 @@ public enum ILRAction
     /// <summary>
     /// Options to resolve conflict for a file share
     /// </summary>
-    public enum RestoreFSResolveConfictOption
+    public enum RestoreFSResolveConflictOption
     {
         Overwrite,
         Skip

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup/Cmdlets/Restore/RestoreAzureRMRecoveryServicesBackupItem.cs

@@ -77,47 +77,47 @@ public class RestoreAzureRmRecoveryServicesBackupItem : RSBackupVaultCmdletBase
         /// <summary>
         /// Resolve conflict option
         /// </summary>
-        [Parameter(Mandatory = true, Position = 3, ParameterSetName = AzureFileParameterSet,
+        [Parameter(Mandatory = true, ParameterSetName = AzureFileParameterSet,
             HelpMessage = ParamHelpMsgs.RestoreFS.ResolveConflict)]
         [ValidateNotNullOrEmpty]
-        public RestoreFSResolveConfictOption ResolveConflict { get; set; }
+        public RestoreFSResolveConflictOption ResolveConflict { get; set; }
 
         /// <summary>
         /// Source File Path of the file to be recovered
         /// </summary>
-        [Parameter(Mandatory = false, Position = 4, ParameterSetName = AzureFileParameterSet,
+        [Parameter(Mandatory = false, ParameterSetName = AzureFileParameterSet,
             HelpMessage = ParamHelpMsgs.RestoreFS.SourceFilePath)]
         [ValidateNotNullOrEmpty]
         public string SourceFilePath { get; set; }
 
         /// <summary>
         /// Source File Type of the file to be recovered
         /// </summary>
-        [Parameter(Mandatory = false, Position = 5, ParameterSetName = AzureFileParameterSet,
+        [Parameter(Mandatory = false, ParameterSetName = AzureFileParameterSet,
             HelpMessage = ParamHelpMsgs.RestoreFS.SourceFilePath)]
         [ValidateNotNullOrEmpty]
         public SourceFileType? SourceFileType { get; set; }
 
         /// <summary>
         /// Target storage account name where the disks need to be recovered
         /// </summary>
-        [Parameter(Mandatory = false, Position = 6, ParameterSetName = AzureFileParameterSet,
+        [Parameter(Mandatory = false, ParameterSetName = AzureFileParameterSet,
             HelpMessage = ParamHelpMsgs.RestoreFS.TargetStorageAccountName)]
         [ValidateNotNullOrEmpty]
         public string TargetStorageAccountName { get; set; }
 
         /// <summary> 
         /// The target file share name to which the files are restored.
         /// </summary>
-        [Parameter(Mandatory = false, Position = 7, ParameterSetName = AzureFileParameterSet,
+        [Parameter(Mandatory = false, ParameterSetName = AzureFileParameterSet,
             HelpMessage = ParamHelpMsgs.RestoreFS.TargetFileShareName)]
         [ValidateNotNullOrEmpty]
         public string TargetFileShareName { get; set; }
 
         /// <summary> 
         /// The target folder name to which the files are restored.
         /// </summary>
-        [Parameter(Mandatory = false, Position = 8, ParameterSetName = AzureFileParameterSet,
+        [Parameter(Mandatory = false, ParameterSetName = AzureFileParameterSet,
             HelpMessage = ParamHelpMsgs.RestoreFS.TargetFolder)]
         [ValidateNotNullOrEmpty]
         public string TargetFolder { get; set; }

tools/StaticAnalysis/Exceptions/Az.RecoveryServices.Backup/SignatureIssues.csv

@@ -11,5 +11,4 @@
 "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.NewAzureRmRecoveryServicesBackupProtectionPolicy","New-AzureRmRecoveryServicesBackupProtectionPolicy","1","8420","Parameter set '__AllParameterSets' of cmdlet 'New-AzureRmRecoveryServicesBackupProtectionPolicy' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."
 "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.RemoveAzureRmRecoveryServicesBackupProtectionPolicy","Remove-AzureRmRecoveryServicesBackupProtectionPolicy","1","8600","Cmdlet 'Remove-AzureRmRecoveryServicesBackupProtectionPolicy' has no defined output type.","Add an OutputType attribute that declares the type of the object(s) returned by this cmdlet. If this cmdlet returns no output, please set the output type to 'bool' and make sure to implement the 'PassThru' parameter."
 "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Container.UnregisterAzureRmRecoveryServicesBackupManagementServer","Unregister-AzureRmRecoveryServicesBackupManagementServer","1","8600","Cmdlet 'Unregister-AzureRmRecoveryServicesBackupManagementServer' has no defined output type.","Add an OutputType attribute that declares the type of the object(s) returned by this cmdlet. If this cmdlet returns no output, please set the output type to 'bool' and make sure to implement the 'PassThru' parameter."
-"C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.GetAzureRmRecoveryServicesBackupItem","Get-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'GetItemsForPolicy' of cmdlet 'Get-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."
-"C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.RestoreAzureRmRecoveryServicesBackupItem","Restore-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'AzureFileParameterSet' of cmdlet 'Restore-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."
+"C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.GetAzureRmRecoveryServicesBackupItem","Get-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'GetItemsForPolicy' of cmdlet 'Get-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."

tools/StaticAnalysis/Exceptions/AzureRM.RecoveryServices.Backup/SignatureIssues.csv

@@ -11,5 +11,4 @@
 "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.NewAzureRmRecoveryServicesBackupProtectionPolicy","New-AzureRmRecoveryServicesBackupProtectionPolicy","1","8420","Parameter set '__AllParameterSets' of cmdlet 'New-AzureRmRecoveryServicesBackupProtectionPolicy' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."
 "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.RemoveAzureRmRecoveryServicesBackupProtectionPolicy","Remove-AzureRmRecoveryServicesBackupProtectionPolicy","1","8600","Cmdlet 'Remove-AzureRmRecoveryServicesBackupProtectionPolicy' has no defined output type.","Add an OutputType attribute that declares the type of the object(s) returned by this cmdlet. If this cmdlet returns no output, please set the output type to 'bool' and make sure to implement the 'PassThru' parameter."
 "C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Container.UnregisterAzureRmRecoveryServicesBackupManagementServer","Unregister-AzureRmRecoveryServicesBackupManagementServer","1","8600","Cmdlet 'Unregister-AzureRmRecoveryServicesBackupManagementServer' has no defined output type.","Add an OutputType attribute that declares the type of the object(s) returned by this cmdlet. If this cmdlet returns no output, please set the output type to 'bool' and make sure to implement the 'PassThru' parameter."
-"C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.GetAzureRmRecoveryServicesBackupItem","Get-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'GetItemsForPolicy' of cmdlet 'Get-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."
-"C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.RestoreAzureRmRecoveryServicesBackupItem","Restore-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'AzureFileParameterSet' of cmdlet 'Restore-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."
+"C:\azure-powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.RecoveryServices.Backup\Microsoft.Azure.Commands.RecoveryServices.Backup.dll","Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.GetAzureRmRecoveryServicesBackupItem","Get-AzureRmRecoveryServicesBackupItem","1","8420","Parameter set 'GetItemsForPolicy' of cmdlet 'Get-AzureRmRecoveryServicesBackupItem' contains at least one parameter with a position larger than four, which is discouraged.","Limit the number of positional parameters in a single parameter set to four or fewer."