Merge pull request #7291 from wastoresh/fixmetadata

[Storage] Fix copy blob/file won't overwrite metadata issue and update help

Author: cormacpayne

src/Storage/Commands.Storage/Blob/Cmdlet/StartAzureStorageBlobCopy.cs

@@ -567,6 +567,10 @@ private async Task StartCopyFromUri(long taskId, IStorageBlobManagement destChan
             if (!destExist || this.ConfirmOverwrite(srcUri.AbsoluteUri.ToString(), destBlob.Uri.ToString()))
             {
                 string copyId;
+
+                //Clean the Metadata of the destination Blob object, or the source metadata won't overwirte the dest blob metadata. See https://docs.microsoft.com/en-us/rest/api/storageservices/copy-blob
+                destBlob.Metadata.Clear();
+
                 if (pageBlobTier == null)
                 {
                     copyId = await destChannel.StartCopyAsync(destBlob, srcUri, null, null, this.RequestOptions, this.OperationContext, this.CmdletCancellationToken).ConfigureAwait(false);

src/Storage/Commands.Storage/ChangeLog.md

@@ -18,7 +18,10 @@
         - Additional information about change #1
 -->
 ## Current Release
-
+* Fix Copy Blob/File won't copy metadata when destination has metadata issue
+    - Start-AzureStorageBlobCopy
+    - Start-AzureStorageFileCopy
+	
 ## Version 4.6.0
 * Upgrade to Azure Storage Client Library 9.3.0 and Azure Storage DataMovement Library 0.8.1
 * Support create Storage Context with OAuth. 

src/Storage/Commands.Storage/File/Cmdlet/StartAzureStorageFileCopy.cs

@@ -366,6 +366,9 @@ private async Task StartAsyncCopy(long taskId, CloudFile destFile, Func<bool> ch
             try
             {
                 await destFile.FetchAttributesAsync(null, this.RequestOptions, this.OperationContext, this.CmdletCancellationToken).ConfigureAwait(false);
+
+                //Clean the Metadata of the destination file object, or the source metadata won't overwirte the dest file metadata. See https://docs.microsoft.com/en-us/rest/api/storageservices/copy-file
+                destFile.Metadata.Clear();
             }
             catch (StorageException ex)
             {

src/Storage/Commands.Storage/help/Get-AzureStorageContainer.md

@@ -87,7 +87,7 @@ Accept wildcard characters: False
 ### -Context
 Specifies the storage context.
 To create it, you can use the New-AzureStorageContext cmdlet.
-The cmdlet will fail when you use a storage context created from SAS Token because the cmdlet will query for container permissions which require Storage account key permission.
+The container permissions won't be retrieved when you use a storage context created from SAS Token, because query container permissions requires Storage account key permission.
 
 ```yaml
 Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.IStorageContext

src/Storage/Commands.Storage/help/Set-AzureStorageBlobContent.md

@@ -223,6 +223,7 @@ Accept wildcard characters: False
 ### -Context
 Specifies an Azure storage context.
 To obtain a storage context, use the New-AzureStorageContext cmdlet.
+To use a storage context created from a SAS Token without read permission, need add -Force parameter to skip check blob existance.
 
 ```yaml
 Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.IStorageContext