incorporated PR review comments

Author: sudhakar4171

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/Conversions/ConversionHelpers.cs

@@ -71,16 +71,16 @@ public static AzureRmRecoveryServicesPolicyBase GetPolicyModel(ProtectionPolicyR
                 if(((AzureIaaSVMProtectionPolicy)hydraResponse.Properties).RetentionPolicy.GetType() !=
                                                                            typeof(LongTermRetentionPolicy))
                 {
-                    Logger.Logger.WriteDebug(Resources.UpdateToNewAzurePowershellWarning);
-                    Logger.Logger.WriteWarning(Resources.UpdateToNewAzurePowershellWarning);
+                    Logger.Instance.WriteDebug(Resources.UpdateToNewAzurePowershellWarning);
+                    Logger.Instance.WriteWarning(Resources.UpdateToNewAzurePowershellWarning);
                     return null;
                 }
 
                 if (((AzureIaaSVMProtectionPolicy)hydraResponse.Properties).SchedulePolicy.GetType() != 
                                                                             typeof(SimpleSchedulePolicy))
                 {
-                    Logger.Logger.WriteDebug(Resources.UpdateToNewAzurePowershellWarning);
-                    Logger.Logger.WriteWarning(Resources.UpdateToNewAzurePowershellWarning);
+                    Logger.Instance.WriteDebug(Resources.UpdateToNewAzurePowershellWarning);
+                    Logger.Instance.WriteWarning(Resources.UpdateToNewAzurePowershellWarning);
                     return null;
                 }
 
@@ -98,8 +98,8 @@ public static AzureRmRecoveryServicesPolicyBase GetPolicyModel(ProtectionPolicyR
                 // trace warning message, ignore and return
                 // we will enter this case when service supports new workload and customer 
                 // still using old version of azure powershell
-                Logger.Logger.WriteDebug(Resources.UpdateToNewAzurePowershellWarning);
-                Logger.Logger.WriteWarning(Resources.UpdateToNewAzurePowershellWarning);
+                Logger.Instance.WriteDebug(Resources.UpdateToNewAzurePowershellWarning);
+                Logger.Instance.WriteWarning(Resources.UpdateToNewAzurePowershellWarning);
                 return null;
             }
 

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Logger/Commands.RecoveryServices.Backup.Logger.csproj

@@ -7,7 +7,7 @@
     <ProjectGuid>{5E675749-6139-464A-904C-59C0FFDFEC82}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>Microsoft.Azure.Commands.RecoveryServices.Backup.Logger</RootNamespace>
+    <RootNamespace>Microsoft.Azure.Commands.RecoveryServices.Backup</RootNamespace>
     <AssemblyName>Microsoft.Azure.Commands.RecoveryServices.Backup.Logger</AssemblyName>
     <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Logger/Logger.cs

@@ -1,41 +1,57 @@
-using System;
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System;
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
 using System.Collections.Generic;
 
-namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Logger
+namespace Microsoft.Azure.Commands.RecoveryServices.Backup
 {
     public class Logger
     {
-        private static Action<string> WriteWarningAction { get; set; }
+        private Action<string> writeWarningAction;
+
+        private Action<string> writeDebugAction;
 
-        private static Action<string> WriteDebugAction { get; set; }
+        private Action<string> writeVerboseAction;
 
-        private static Action<string> WriteVerboseAction { get; set; }
+        public static Logger Instance { get; set; }
 
         public Logger(Action<string> writeWarning,
                       Action<string> writeDebug,
                       Action<string> writeVerbose)
         {
-            WriteWarningAction = writeWarning;
-            WriteDebugAction = writeDebug;
-            WriteVerboseAction = writeVerbose;
+            writeWarningAction = writeWarning;
+            writeDebugAction = writeDebug;
+            writeVerboseAction = writeVerbose;
         }
 
-        public static void WriteVerbose(string text)
+        public void WriteVerbose(string text)
         {
-            WriteVerboseAction(text);
+            writeVerboseAction(text);
         }
 
-        public static void WriteDebug(string text)
+        public void WriteDebug(string text)
         {
-            WriteDebugAction(text);
+            writeDebugAction(text);
         }
 
-        public static void WriteWarning(string text)
+        public void WriteWarning(string text)
         {
-            WriteWarningAction(text);
+            writeWarningAction(text);
         }
     }
 }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Logger/Properties/AssemblyInfo.cs

@@ -1,4 +1,18 @@
-using System.Reflection;
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Commands.RecoveryServices.Backup.Models.csproj

@@ -7,7 +7,7 @@
     <ProjectGuid>{30B92759-50B3-494E-B9F0-EC9A2CE9D57B}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>Microsoft.Azure.Commands.RecoveryServices.Backup.Models</RootNamespace>
+    <RootNamespace>Microsoft.Azure.Commands.RecoveryServices.Backup</RootNamespace>
     <AssemblyName>Microsoft.Azure.Commands.RecoveryServices.Backup.Models</AssemblyName>
     <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.Designer.cs

@@ -40,7 +40,7 @@ protected void InitializeAzureBackupCmdlet()
         {
             var cloudServicesClient = AzureSession.ClientFactory.CreateClient<CloudServiceManagementClient>(DefaultContext, AzureEnvironment.Endpoint.ResourceManager);
             HydraAdapter = new HydraAdapterNS.HydraAdapter(cloudServicesClient.Credentials, cloudServicesClient.BaseUri);
-            new Logger.Logger(WriteWarning, WriteDebug, WriteVerbose);
+            Logger.Instance = new Logger(WriteWarning, WriteDebug, WriteVerbose);
         }
 
         protected void ExecutionBlock(Action action)