Skip to content

Commit 11ff082

Browse files
MiYanniMiYanni
committed
Required every netcore build to no longer contain warnings.
1 parent cbb0cae commit 11ff082

File tree

151 files changed

+747
-218
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

151 files changed

+747
-218
lines changed

‎src/Common/Commands.Common.Authentication.Abstractions/Common.Authentication.Abstractions.Netcore.csproj

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,20 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>
@@ -33,8 +37,8 @@
3337

3438
<ItemGroup>
3539
<Compile Update="Properties\Resources.Designer.cs">
36-
<DesignTime>True</DesignTime>
37-
<AutoGen>True</AutoGen>
40+
<DesignTime>true</DesignTime>
41+
<AutoGen>true</AutoGen>
3842
<DependentUpon>Resources.resx</DependentUpon>
3943
</Compile>
4044
</ItemGroup>

‎src/Common/Commands.Common.Authentication.Test/Commands.Common.Authentication.Test.Netcore.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@
1212
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
1313
<DelaySign>false</DelaySign>
1414
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
1517
</PropertyGroup>
1618

1719
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
1820
<SignAssembly>true</SignAssembly>
1921
<DelaySign>true</DelaySign>
2022
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
2123
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>

‎src/Common/Commands.Common.Authentication/Common.Authentication.Netcore.csproj

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,20 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>
@@ -45,8 +49,8 @@
4549

4650
<ItemGroup>
4751
<Compile Update="Properties\Resources.Designer.cs">
48-
<DesignTime>True</DesignTime>
49-
<AutoGen>True</AutoGen>
52+
<DesignTime>true</DesignTime>
53+
<AutoGen>true</AutoGen>
5054
<DependentUpon>Resources.resx</DependentUpon>
5155
</Compile>
5256
</ItemGroup>

‎src/Common/Commands.Common.Authorization/Common.Authorization.Netcore.csproj

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,20 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
18-
19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>
@@ -36,8 +40,8 @@
3640

3741
<ItemGroup>
3842
<Compile Update="Properties\Resources.Designer.cs">
39-
<DesignTime>True</DesignTime>
40-
<AutoGen>True</AutoGen>
43+
<DesignTime>true</DesignTime>
44+
<AutoGen>true</AutoGen>
4145
<DependentUpon>Resources.resx</DependentUpon>
4246
</Compile>
4347
</ItemGroup>

‎src/Common/Commands.Common.Compute.Tests/Commands.Common.Compute.Tests.Netcore.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@
1212
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
1313
<DelaySign>false</DelaySign>
1414
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
1517
</PropertyGroup>
1618

1719
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
1820
<SignAssembly>true</SignAssembly>
1921
<DelaySign>true</DelaySign>
2022
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
2123
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>

‎src/Common/Commands.Common.Compute/Commands.Common.Compute.Netcore.csproj

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,23 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
1726
</PropertyGroup>
1827

19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
22-
</PropertyGroup>
23-
24-
<ItemGroup >
28+
<ItemGroup>
2529
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
2630
<PackageReference Include="System.Reflection" Version="4.3.0" />
2731
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />

‎src/Common/Commands.Common.Graph.RBAC/Common.Rbac.Netcore.csproj

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,23 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
1726
</PropertyGroup>
1827

19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
22-
</PropertyGroup>
23-
24-
<ItemGroup >
28+
<ItemGroup>
2529
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
2630
<PackageReference Include="System.Reflection" Version="4.3.0" />
2731
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
@@ -36,8 +40,8 @@
3640

3741
<ItemGroup>
3842
<Compile Update="Properties\Resources.Designer.cs">
39-
<DesignTime>True</DesignTime>
40-
<AutoGen>True</AutoGen>
43+
<DesignTime>true</DesignTime>
44+
<AutoGen>true</AutoGen>
4145
<DependentUpon>Resources.resx</DependentUpon>
4246
</Compile>
4347
</ItemGroup>

‎src/Common/Commands.Common.Network/Common.Network.Netcore.csproj

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,23 @@
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
1111

12+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
13+
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
1219
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
1522
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
1623
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
1726
</PropertyGroup>
1827

19-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
21-
<DelaySign>false</DelaySign>
22-
</PropertyGroup>
23-
24-
<ItemGroup >
28+
<ItemGroup>
2529
<PackageReference Include="System.Collections.Specialized" Version="4.3.0" />
2630
<PackageReference Include="System.Reflection" Version="4.3.0" />
2731
<PackageReference Include="System.Security.SecureString" Version="4.3.0" />
@@ -36,8 +40,8 @@
3640

3741
<ItemGroup>
3842
<Compile Update="Properties\Resources.Designer.cs">
39-
<DesignTime>True</DesignTime>
40-
<AutoGen>True</AutoGen>
43+
<DesignTime>true</DesignTime>
44+
<AutoGen>true</AutoGen>
4145
<DependentUpon>Resources.resx</DependentUpon>
4246
</Compile>
4347
</ItemGroup>

‎src/Common/Commands.Common.Storage/Common.Storage.Netcore.csproj

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,21 @@
88
<RootNamespace>Microsoft.WindowsAzure.Commands.Common.Storage</RootNamespace>
99
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
1010
</PropertyGroup>
11-
12-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
13-
<SignAssembly>True</SignAssembly>
14-
<DelaySign>True</DelaySign>
15-
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
16-
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
17-
</PropertyGroup>
1811

1912
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
20-
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
2113
<DelaySign>false</DelaySign>
14+
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
17+
</PropertyGroup>
18+
19+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
20+
<SignAssembly>true</SignAssembly>
21+
<DelaySign>true</DelaySign>
22+
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
23+
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>
@@ -56,8 +60,8 @@
5660

5761
<ItemGroup>
5862
<Compile Update="Properties\Resources.Designer.cs">
59-
<DesignTime>True</DesignTime>
60-
<AutoGen>True</AutoGen>
63+
<DesignTime>true</DesignTime>
64+
<AutoGen>true</AutoGen>
6165
<DependentUpon>Resources.resx</DependentUpon>
6266
</Compile>
6367
</ItemGroup>

‎src/Common/Commands.Common.Tests/Commands.Common.Tests.Netcore.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
<PropertyGroup>
44
<TargetFramework>netcoreapp2.0</TargetFramework>
5-
65
<IsPackable>false</IsPackable>
76
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
7+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
8+
<WarningsAsErrors />
89
</PropertyGroup>
910

1011
<ItemGroup>

‎src/Common/Commands.Common/Common.Netcore.csproj

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,23 @@
1010
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
1111
</PropertyGroup>
1212

13-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
14-
<SignAssembly>True</SignAssembly>
15-
<DelaySign>True</DelaySign>
16-
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
17-
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
18-
</PropertyGroup>
19-
2013
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
2114
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
2215
<DelaySign>false</DelaySign>
16+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
17+
<WarningsAsErrors />
2318
</PropertyGroup>
2419

25-
<ItemGroup >
20+
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
21+
<SignAssembly>true</SignAssembly>
22+
<DelaySign>true</DelaySign>
23+
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
24+
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
25+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
26+
<WarningsAsErrors />
27+
</PropertyGroup>
28+
29+
<ItemGroup>
2630
<PackageReference Include="System.Collections.NonGeneric" Version="4.3.0" />
2731
<PackageReference Include="System.Net.WebHeaderCollection" Version="4.3.0" />
2832
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
@@ -34,8 +38,8 @@
3438

3539
<ItemGroup>
3640
<Compile Update="Properties\Resources.Designer.cs">
37-
<DesignTime>True</DesignTime>
38-
<AutoGen>True</AutoGen>
41+
<DesignTime>true</DesignTime>
42+
<AutoGen>true</AutoGen>
3943
<DependentUpon>Resources.resx</DependentUpon>
4044
</Compile>
4145
</ItemGroup>

‎src/ResourceManager/Aks/Commands.Aks.Test/Commands.Aks.Test.Netcore.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,17 @@
1212
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
1313
<DelaySign>false</DelaySign>
1414
<DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants>
15+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
16+
<WarningsAsErrors />
1517
</PropertyGroup>
1618

1719
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
1820
<SignAssembly>true</SignAssembly>
1921
<DelaySign>true</DelaySign>
2022
<AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
2123
<DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants>
24+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
25+
<WarningsAsErrors />
2226
</PropertyGroup>
2327

2428
<ItemGroup>

0 commit comments

Comments
 (0)