Removed custom extension and improved ConvertToDictionary hashtable management

Author: Leandro Wajswajn Pereyra

src/KeyVault/KeyVault/Commands/SetAzureKeyVaultSecret.cs

@@ -16,6 +16,7 @@
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using System;
 using System.Collections;
+using System.Collections.Generic;
 using System.Management.Automation;
 using System.Security;
 
@@ -141,7 +142,7 @@ public override void ExecuteCmdlet()
 
                 if (this.Tag != null)
                 {
-                    attributes.Tags = this.Tag.ConvertToStringHashtable();
+                    attributes.Tags = this.Tag.ConvertToDictionary().ConvertToHashtable();
                 }
 
                 var secret = DataServiceClient.SetSecret(VaultName, Name, SecretValue, attributes);

src/KeyVault/KeyVault/Models/TagsHelper.cs

@@ -22,16 +22,6 @@ namespace Microsoft.Azure.Commands.KeyVault.Models
 {
     public static class TagsHelper
     {
-        public static Hashtable ConvertToStringHashtable(this Hashtable tags) {
-            Hashtable tagsHashtable = new Hashtable();
-
-            foreach (string Key in tags.Keys) {
-                tagsHashtable.Add(Key, tags[Key].ToString());
-            }
-
-            return tagsHashtable;
-        }
-
         public static Dictionary<string, string> ConvertToDictionary(this Hashtable tags)
         {
             Dictionary<string, string> tagsDictionary = new Dictionary<string, string>();
@@ -41,9 +31,7 @@ public static Dictionary<string, string> ConvertToDictionary(this Hashtable tags
                 if (string.IsNullOrWhiteSpace(key))
                     throw new ArgumentException("Invalid tag name");
 
-                if (tag.Value != null && !(tag.Value is string))
-                    throw new ArgumentException("Tag has invalid value");
-                string value = (tag.Value == null) ? string.Empty : (string)tag.Value;
+                string value = (tag.Value == null) ? string.Empty : tag.Value.ToString();
                 tagsDictionary[key] = value;
             }