adding tests, fixing cmdlets

Author: rewongmicrosoft

src/Sql/Sql.Test/ScenarioTests/Common.ps1

@@ -190,20 +190,20 @@ Gets the values of the parameters used for ledger digest upload tests
 #>
 function Get-LedgerTestEnvironmentParameters ($testSuffix)
 {
-	$subscriptionId = (Get-AzContext).Subscription.Id
-	return @{ rgname = "ledger-cmdlet-test-rg" + $testSuffix;
+	return @{ subscriptionId = (Get-AzContext).Subscription.Id;
+			  rgname = "ledger-cmdlet-test-rg" + $testSuffix;
 			  serverName = "ledger-cmdlet-server" + $testSuffix;
 			  databaseName = "ledger-cmdlet-db" + $testSuffix;
 		}
 }
 
 <#
 .SYNOPSIS
-Creates the basic test environment needed to perform the Sql data security tests - resource group, server and database
+Creates the basic test environment used for the ledger tests - creates resource group, server, and database
 #>
 function Create-LedgerTestEnvironment ($params)
 {
-	$location = "West Europe"
+	$location = "eastus2euap"
 	$serverVersion = "12.0"
 	New-AzResourceGroup -Name $params.rgname -Location $location
 	$serverName = $params.serverName

src/Sql/Sql.Test/ScenarioTests/DatabaseCrudTests.cs

@@ -190,5 +190,12 @@ public void TestDatabaseGetWithBackupStorageRedundancy()
         {
             RunPowerShellTest("Test-GetDatabaseWithBackupStorageRedundancy");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestDatabaseCreateWithLedgerEnabled()
+        {
+            RunPowerShellTest("Test-DatabaseCreateWithLedgerEnabled");
+        }
     }
 }

src/Sql/Sql.Test/ScenarioTests/DatabaseCrudTests.ps1

@@ -973,6 +973,29 @@ function Test-GetDatabaseWithMaintenanceConfigurationId
 	}
 }
 
+<#
+	.SYNOPSIS
+	Tests creating a database with ledger enabled
+#>
+function Test-DatabaseCreateWithLedgerEnabled ($location = "eastus2euap")
+{
+	# Setup
+	$rg = Create-ResourceGroupForTest
+	$server = Create-ServerForTest $rg $location
+
+	# Create with ledger enabled
+	$databaseName = Get-DatabaseName
+	$db1 = New-AzSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName -EnableLedger -Force
+	Assert-AreEqual $db1.DatabaseName $databaseName
+	Assert-AreEqual	"True" $db1.EnableLedger
+
+	# Validate Get-AzSqlDatabase returns ledger property
+	$databaseFromGet = Get-AzSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName
+	Assert-AreEqual	"True" $databaseFromGet.EnableLedger
+
+	Remove-ResourceGroupForTest $rg
+}
+
 <#
 	.SYNOPSIS
 	Tests Deleting a database

src/Sql/Sql.Test/ScenarioTests/LedgerDigestUploadTests.ps1

@@ -23,7 +23,7 @@ function Test-GetDefaultLedgerDigestUpload
 	$params = Get-LedgerTestEnvironmentParameters $testSuffix
 	Create-LedgerTestEnvironment $params
 
-	$databaseResourceId = "/subscriptions/" + $subscriptionId + "/resourceGroups/" + $params.rgname + "/providers/Microsoft.Sql/servers/" + $params.serverName + "/databases/" + $params.databaseName 
+	$databaseResourceId = "/subscriptions/" + $params.subscriptionId + "/resourceGroups/" + $params.rgname + "/providers/Microsoft.Sql/servers/" + $params.serverName + "/databases/" + $params.databaseName 
 	$databaseObject = Get-AzSqlDatabase -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
 
 	try 
@@ -55,7 +55,7 @@ function Test-GetDefaultLedgerDigestUpload
 
 <#
 .SYNOPSIS
-Tests that when setting the storage account property's value in a database's blob auditing policy, that value is later fetched properly
+Tests enabling and disabling ledger digest uploading using named parameters
 #>
 function Test-SetLedgerDigestUploadByName
 {
@@ -76,7 +76,7 @@ function Test-SetLedgerDigestUploadByName
 
 		# Test get enabled settings
 		$ledgerDigestUploadEnabledGet = Get-AzSqlDatabaseLedgerDigestUpload -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
-		<#
+
 		# Assert
 		Assert-AreEqual $ledgerDigestUploadEnabledGet.State "Enabled"
 
@@ -91,7 +91,6 @@ function Test-SetLedgerDigestUploadByName
 
 		# Assert
 		Assert-AreEqual $ledgerDigestUploadDisabledGet.State "Disabled"
-		#>
 	}
 	finally
 	{
@@ -102,7 +101,7 @@ function Test-SetLedgerDigestUploadByName
 
 <#
 .SYNOPSIS
-Tests that when setting the storage account property's value in a database's blob auditing policy, that value is later fetched properly
+Tests enabling and disabling ledger digest uploading using the database object
 #>
 function Test-SetLedgerDigestUploadByDatabaseObject
 {
@@ -149,7 +148,7 @@ function Test-SetLedgerDigestUploadByDatabaseObject
 
 <#
 .SYNOPSIS
-Tests that when setting the storage account property's value in a database's blob auditing policy, that value is later fetched properly
+Tests enabling and disabling ledger digest uploading using the resource ID
 #>
 function Test-SetLedgerDigestUploadByResourceId
 {
@@ -158,7 +157,7 @@ function Test-SetLedgerDigestUploadByResourceId
 	$params = Get-LedgerTestEnvironmentParameters $testSuffix
 	Create-LedgerTestEnvironment $params
 	$endpoint = "https://test.confidential-ledger.azure.com"
-	$databaseResourceId = "/subscriptions/" + $subscriptionId + "/resourceGroups/" + $params.rgname + "/providers/Microsoft.Sql/servers/" + $params.serverName + "/databases/" + $params.databaseName 
+	$databaseResourceId = "/subscriptions/" + $params.subscriptionId + "/resourceGroups/" + $params.rgname + "/providers/Microsoft.Sql/servers/" + $params.serverName + "/databases/" + $params.databaseName 
 
 	try 
 	{
@@ -176,7 +175,7 @@ function Test-SetLedgerDigestUploadByResourceId
 		Assert-AreEqual $ledgerDigestUploadEnabledGet.State "Enabled"
 
 		# Test disabling 
-		$ledgerDigestUploadDisable = Disable-AzSqlDatabaseLedgerDigestUpload -InputObject $databaseObject
+		$ledgerDigestUploadDisable = Disable-AzSqlDatabaseLedgerDigestUpload -ResourceId $databaseResourceId
 
 		# Assert
 		Assert-AreEqual $ledgerDigestUploadDisable.State "Disabled"