Skip to content

Commit 190da02

Browse files
authored
Merge pull request #2965 from begoldsm/dev
ADL: Remove obsolete cmdlets and help
2 parents 642410e + 3fd6cf6 commit 190da02

File tree

20 files changed

+1807
-2359
lines changed

20 files changed

+1807
-2359
lines changed

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/Commands.DataLakeAnalytics.Test.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@
6767
<Private>True</Private>
6868
</Reference>
6969
<Reference Include="Microsoft.Azure.Management.DataLake.Store, Version=0.12.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
70-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Store.0.12.5-preview\lib\net45\Microsoft.Azure.Management.DataLake.Store.dll</HintPath>
70+
<SpecificVersion>False</SpecificVersion>
71+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Store.0.12.6-preview\lib\net45\Microsoft.Azure.Management.DataLake.Store.dll</HintPath>
7172
<Private>True</Private>
7273
</Reference>
7374
<Reference Include="Microsoft.Azure.Management.ResourceManager, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/packages.config

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
<package id="Microsoft.Azure.Gallery" version="2.6.2-preview" targetFramework="net45" />
77
<package id="Microsoft.Azure.Management.Authorization" version="2.0.0" targetFramework="net45" />
88
<package id="Microsoft.Azure.Management.DataLake.Analytics" version="0.11.5-preview" targetFramework="net45" />
9-
<package id="Microsoft.Azure.Management.DataLake.Store" version="0.12.2-preview" targetFramework="net45" />
9+
<package id="Microsoft.Azure.Management.DataLake.Store" version="0.12.6-preview" targetFramework="net45" />
1010
<package id="Microsoft.Azure.Management.ResourceManager" version="1.1.1-preview" targetFramework="net45" />
1111
<package id="Microsoft.Azure.Management.Resources" version="2.20.0-preview" targetFramework="net45" />
1212
<package id="Microsoft.Azure.Management.Storage" version="3.0.0" targetFramework="net45" />
1313
<package id="Microsoft.Azure.Test.Framework" version="1.0.6052.28118-prerelease" targetFramework="net45" />
14-
<package id="Microsoft.Azure.Test.HttpRecorder" version="1.6.7-preview" targetFramework="net45" />
14+
<package id="Microsoft.Azure.Test.HttpRecorder" version="1.6.7-preview" targetFramework="net45" />
1515
<package id="Microsoft.Bcl" version="1.1.9" targetFramework="net45" />
1616
<package id="Microsoft.Bcl.Async" version="1.0.168" targetFramework="net45" />
1717
<package id="Microsoft.Bcl.Build" version="1.0.14" targetFramework="net45" />
@@ -31,4 +31,4 @@
3131
<package id="xunit.extensibility.core" version="2.1.0" targetFramework="net45" />
3232
<package id="xunit.extensibility.execution" version="2.1.0" targetFramework="net45" />
3333
<package id="xunit.runner.visualstudio" version="2.1.0" targetFramework="net45" />
34-
</packages>
34+
</packages>

src/ResourceManager/DataLakeStore/AzureRM.DataLakeStore.psd1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
@{
1010

1111
# Version number of this module.
12-
ModuleVersion = '2.1.0'
12+
ModuleVersion = '3.0.0'
1313

1414
# ID used to uniquely identify this module
1515
GUID = '90dfd814-abce-4e1f-99b6-fe16760c079a'

src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/Commands.DataLakeStore.Test.csproj

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,13 @@
6363
<Private>True</Private>
6464
</Reference>
6565
<Reference Include="Microsoft.Azure.Management.DataLake.Store, Version=0.12.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
66-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Store.0.12.5-preview\lib\net45\Microsoft.Azure.Management.DataLake.Store.dll</HintPath>
66+
<SpecificVersion>False</SpecificVersion>
67+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Store.0.12.6-preview\lib\net45\Microsoft.Azure.Management.DataLake.Store.dll</HintPath>
6768
<Private>True</Private>
6869
</Reference>
6970
<Reference Include="Microsoft.Azure.Management.DataLake.StoreUploader, Version=0.10.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
70-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.StoreUploader.0.10.6-preview\lib\net45\Microsoft.Azure.Management.DataLake.StoreUploader.dll</HintPath>
71+
<SpecificVersion>False</SpecificVersion>
72+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.StoreUploader.0.10.7-preview\lib\net45\Microsoft.Azure.Management.DataLake.StoreUploader.dll</HintPath>
7173
<Private>True</Private>
7274
</Reference>
7375
<Reference Include="Microsoft.Azure.Management.ResourceManager, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">

src/ResourceManager/DataLakeStore/Commands.DataLakeStore.Test/ScenarioTests/AdlsAliasTests.ps1

Lines changed: 31 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -316,40 +316,51 @@ function Test-DataLakeStoreFileSystemPermissions
316316
$aceUserId = "027c28d5-c91d-49f0-98c5-d10134b169b3"
317317

318318
# Set and get all the permissions
319-
$result = Get-AdlStoreItemAcl -Account $accountName -path "/"
319+
$result = Get-AdlStoreItemAclEntry -Account $accountName -path "/"
320320
Assert-NotNull $result "Did not get any result from ACL get"
321-
Assert-True {$result.UserAces.count -ge 0} "UserAces is negative or null"
322-
$currentCount = $result.UserAces.Count
323-
324-
# use the new cmdlet and ensure the count is the same or large than the old count
325-
Assert-True {(Get-AdlStoreItemAclEntry -Account $accountName -path "/").Count -ge $result.UserAces.Count} "Get-AdlStoreItemAclEntry returned fewer results than Get-AdlStoreItemAcl"
321+
Assert-True {$result.Count -ge 0} "UserAces is negative or null"
322+
$currentCount = $result.Count
323+
$result.Add("user:$aceUserId`:rwx")
324+
$toRemove = $result[$result.Count -1]
325+
Assert-AreEqual $aceUserId $toRemove.Id
326326

327-
$result.UserAces.Add($aceUserId, "rwx")
328327
Set-AdlStoreItemAcl -Account $accountName -path "/" -Acl $result
329-
$result = Get-AdlStoreItemAcl -Account $accountName -path "/"
330-
Assert-AreEqual $($currentCount+1) $result.UserACes.Count
331-
$result.UserAces.Remove($aceUserId)
328+
$result = Get-AdlStoreItemAclEntry -Account $accountName -path "/"
329+
Assert-AreEqual $($currentCount+1) $result.Count
330+
$found = $false
331+
for($i = 0; $i -lt $result.Count; $i++)
332+
{
333+
if($result[$i].Id -like $aceUserId)
334+
{
335+
$found = $true
336+
$result.RemoveAt($i)
337+
break
338+
}
339+
}
340+
341+
Assert-True { $found } "Failed to remove the element: $($toRemove.Entry)"
342+
332343
# remove the account
333344
Set-AdlStoreItemAcl -Account $accountName -path "/" -Acl $result
334-
$result = Get-AdlStoreItemAcl -Account $accountName -path "/"
335-
Assert-AreEqual $currentCount $result.UserAces.Count
345+
$result = Get-AdlStoreItemAclEntry -Account $accountName -path "/"
346+
Assert-AreEqual $currentCount $result.Count
336347

337348
# Set and get a specific permission with friendly sets
338349
Set-AdlStoreItemAclEntry -Account $accountName -path "/" -AceType User -Id $aceUserId -Permissions All
339-
$result = Get-AdlStoreItemAcl -Account $accountName -path "/"
340-
Assert-AreEqual $($currentCount+1) $result.UserAces.Count
350+
$result = Get-AdlStoreItemAclEntry -Account $accountName -path "/"
351+
Assert-AreEqual $($currentCount+1) $result.Count
341352
# remove a specific permission with friendly remove
342353
Remove-AdlStoreItemAclEntry -Account $accountName -path "/" -AceType User -Id $aceUserId
343-
$result = Get-AdlStoreItemAcl -Account $accountName -path "/"
344-
Assert-AreEqual $currentCount $result.UserAces.Count
354+
$result = Get-AdlStoreItemAclEntry -Account $accountName -path "/"
355+
Assert-AreEqual $currentCount $result.Count
345356
# set and get a specific permission with the ACE string
346357
Set-AdlStoreItemAclEntry -Account $accountName -path "/" -Acl $([string]::Format("user:{0}:rwx", $aceUserId))
347-
$result = Get-AdlStoreItemAcl -Account $accountName -path "/"
348-
Assert-AreEqual $($currentCount+1) $result.UserAces.Count
358+
$result = Get-AdlStoreItemAclEntry -Account $accountName -path "/"
359+
Assert-AreEqual $($currentCount+1) $result.Count
349360
# remove a specific permission with the ACE string
350361
Remove-AdlStoreItemAclEntry -Account $accountName -path "/" -Acl $([string]::Format("user:{0}:---", $aceUserId))
351-
$result = Get-AdlStoreItemAcl -Account $accountName -path "/"
352-
Assert-AreEqual $currentCount $result.UserAces.Count
362+
$result = Get-AdlStoreItemAclEntry -Account $accountName -path "/"
363+
Assert-AreEqual $currentCount $result.Count
353364

354365
# Validate full ACL removal
355366
Remove-AdlStoreItemAcl -Account $accountName -Path "/" -Force -Default

0 commit comments

Comments
 (0)