Skip to content

Commit 1918a61

Browse files
committed
Make FileType enum nullable, add exceptions for static code analysis
1 parent efdd22f commit 1918a61

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/DataPlaneModels/DataLakeStoreItem.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public class DataLakeStoreItem
6969
/// Gets the type of the path object. Possible values include: 'FILE',
7070
/// 'DIRECTORY'
7171
/// </summary>
72-
public DataLakeStoreEnums.FileType Type { get; }
72+
public DataLakeStoreEnums.FileType? Type { get; }
7373

7474
/// <summary>Gets flag to indicate if extended acls are enabled</summary>
7575
public bool? AclBit { get; }

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -760,3 +760,9 @@
760760
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Batch\Microsoft.Azure.Commands.Batch.dll","Microsoft.Azure.Commands.Batch.GetBatchPoolCommand","Get-AzureBatchPool","0","3030","The generic type for 'property ResizeErrors' has been changed from 'System.Collections.Generic.IList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]' to 'System.Collections.Generic.IReadOnlyList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]'. ","Change the generic type for 'property ResizeErrors' back to 'System.Collections.Generic.IList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]'."
761761
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Batch\Microsoft.Azure.Commands.Batch.dll","Microsoft.Azure.Commands.Batch.SetBatchPoolCommand","Set-AzureBatchPool","0","3030","The generic type for 'property ResizeErrors' has been changed from 'System.Collections.Generic.IList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]' to 'System.Collections.Generic.IReadOnlyList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]'. ","Change the generic type for 'property ResizeErrors' back to 'System.Collections.Generic.IList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]'."
762762
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Batch\Microsoft.Azure.Commands.Batch.dll","Microsoft.Azure.Commands.Batch.GetBatchComputeNodeCommand","Get-AzureBatchComputeNode","0","3030","The generic type for 'property ResizeErrors' has been changed from 'System.Collections.Generic.IList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]' to 'System.Collections.Generic.IReadOnlyList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]'. ","Change the generic type for 'property ResizeErrors' back to 'System.Collections.Generic.IList`1[Microsoft.Azure.Commands.Batch.Models.PSResizeError]'."
763+
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","3000","The type of property 'Type' of type 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreItem' has changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType'.","Change the type of property 'Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."
764+
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","2100","The parameter 'Account' in cmdlet 'Set-AzureRmDataLakeStoreItemExpiry' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Account' back to the parameter set '__AllParameterSets'."
765+
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","2100","The parameter 'Path' in cmdlet 'Set-AzureRmDataLakeStoreItemExpiry' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Path' back to the parameter set '__AllParameterSets'."
766+
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","2100","The parameter 'Expiration' in cmdlet 'Set-AzureRmDataLakeStoreItemExpiry' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Expiration' back to the parameter set '__AllParameterSets'."
767+
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.GetAzureDataLakeStoreChildItem","Get-AzureRmDataLakeStoreChildItem","0","3000","The type of property 'Type' of type 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreItem' has changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType'.","Change the type of property 'Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."
768+
"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.GetAzureDataLakeStoreItem","Get-AzureRmDataLakeStoreItem","0","3000","The type of property 'Type' of type 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreItem' has changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType'.","Change the type of property 'Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."

0 commit comments

Comments
 (0)