Skip to content

Commit 1ac3532

Browse files
committed
Change ValidateRange from int to long, add check for json file not existing for new RPs
1 parent 565d070 commit 1ac3532

13 files changed

+14935
-6
lines changed

tools/StaticAnalysis/BreakingChangeAnalyzer/BreakingChangeAnalyzer.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,11 @@ public void Analyze(
139139
}
140140
else
141141
{
142+
if (!File.Exists(filePath))
143+
{
144+
continue;
145+
}
146+
142147
var oldModuleMetadata = DeserializeCmdlets(filePath);
143148

144149
if (cmdletFilter != null)

tools/StaticAnalysis/BreakingChangeAnalyzer/CmdletBreakingChangeLoader.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ public ModuleMetadata GetModuleMetadata(string assemblyPath)
104104
if (parameter.HasAttribute<ValidateRangeAttribute>())
105105
{
106106
var validateRange = parameter.GetAttribute<ValidateRangeAttribute>();
107-
parameterData.ValidateRangeMin = (int)validateRange.MinRange;
108-
parameterData.ValidateRangeMax = (int)validateRange.MaxRange;
107+
parameterData.ValidateRangeMin = Convert.ToInt64(validateRange.MinRange);
108+
parameterData.ValidateRangeMax = Convert.ToInt64(validateRange.MaxRange);
109109
}
110110

111111
parameterData.ValidateNotNullOrEmpty = parameter.HasAttribute<ValidateNotNullOrEmptyAttribute>();

tools/StaticAnalysis/BreakingChangeAnalyzer/ParameterMetadata.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@ public class ParameterMetadata
5050
/// If the parameter implements ValidateRange, specifies the minimum value
5151
/// in the range; otherwise, the value is null
5252
/// </summary>
53-
public int? ValidateRangeMin { get; set; }
53+
public long? ValidateRangeMin { get; set; }
5454

5555
/// <summary>
5656
/// If the parameter implements ValidateRange, specifies the maximum value
5757
/// in the range; otherwise, the value is null
5858
/// </summary>
59-
public int? ValidateRangeMax { get; set; }
59+
public long? ValidateRangeMax { get; set; }
6060

6161
/// <summary>
6262
/// Specifies if the parameter has the ValidateNotNullOrEmpty attribute

0 commit comments

Comments
 (0)