Skip to content

Commit 1ad2db5

Browse files
author
Maddie Clayton
authored
Merge pull request #5656 from v-Ajnava/SBProperties
ServiceBus: Added properties to queue and subscription
2 parents e4cb1dc + 2bc7a71 commit 1ad2db5

File tree

26 files changed

+4497
-3775
lines changed

26 files changed

+4497
-3775
lines changed

‎src/ResourceManager/ServiceBus/ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
- Additional information about change #1
2020
-->
2121
## Current Release
22+
* Added EnableBatchedOperations property to Queue
23+
* Added DeadLetteringOnFilterEvaluationExceptions property to Subscriptions
2224

2325
## Version 0.6.1
2426
* Added functionality fix for Remove-AzureRmServiceBusRule and Get-AzureRmServiceBusKey

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/Commands.ServiceBus.Test.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@
5555
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Authorization.1.0.2\lib\portable-net45+wp8+wpa81+win\Microsoft.Azure.Management.Authorization.dll</HintPath>
5656
</Reference>
5757
<Reference Include="Microsoft.Azure.Management.ServiceBus, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
58-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.ServiceBus.1.0.3\lib\net452\Microsoft.Azure.Management.ServiceBus.dll</HintPath>
58+
<SpecificVersion>False</SpecificVersion>
59+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.ServiceBus.1.1.0\lib\net452\Microsoft.Azure.Management.ServiceBus.dll</HintPath>
5960
<Private>True</Private>
6061
</Reference>
6162
<Reference Include="Microsoft.Azure.Test.HttpRecorder, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/ScenarioTests/ServiceBusQueueTests.ps1

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ function ServiceBusQueueTests
4646
$resultGetQueue.DeadLetteringOnMessageExpiration = $True
4747
$resultGetQueue.MaxDeliveryCount = 5
4848
$resultGetQueue.MaxSizeInMegabytes = 1024
49+
$resultGetQueue.EnableBatchedOperations = $True
4950

5051
$resltSetQueue = Set-AzureRmServiceBusQueue -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Name $resultGetQueue.Name -InputObject $resultGetQueue
5152
Assert-AreEqual $resltSetQueue.Name $resultGetQueue.Name "In GetQueue response, QueueName not found"

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/ScenarioTests/ServiceBusSubscriptionTests.ps1

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,18 @@ function ServiceBusSubscriptionTests
5858
Assert-True {$ResulListTopic.Count -gt 0} "no Topics were found in ListTopic"
5959

6060
#Create Topic
61-
Write-Debug " Create new SB Topic-Subscription"
62-
Write-Debug " SB Topic-Subscription Name : $subName"
63-
$resltNewSub = New-AzureRmServiceBusSubscription -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Topic $resultGetTopic.Name -Name $subName
61+
Write-Debug "Create new SB Topic-Subscription"
62+
Write-Debug "SB Topic-Subscription Name : $subName"
63+
$resltNewSub = New-AzureRmServiceBusSubscription -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Topic $nameTopic -Name $subName -DeadLetteringOnFilterEvaluationExceptions
6464
Assert-AreEqual $resltNewSub.Name $subName "Subscription created earlier is not found"
6565

6666
# Get Created Subscritpiton Name
67-
$resultGetSub = Get-AzureRmServiceBusSubscription -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Topic $resultGetTopic.Name -Name $subName
67+
$resultGetSub = Get-AzureRmServiceBusSubscription -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Topic $nameTopic -Name $subName
6868
Assert-AreEqual $resultGetSub.Name $subName "Get-Subscription: Subscription created earlier is not found"
69-
69+
Assert-True {$resultGetSub.DeadLetteringOnFilterEvaluationExceptions} "New-subscription: DeadLetteringOnFilterEvaluationExceptions not updated "
70+
7071
# Update the subscription.
71-
$resultSetSub = Set-AzureRmServiceBusSubscription -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Topic $resultGetTopic.Name -InputObject $resultGetSub
72-
72+
$resultSetSub = Set-AzureRmServiceBusSubscription -ResourceGroupName $resourceGroupName -Namespace $namespaceName -Topic $resultGetTopic.Name -InputObject $resultGetSub
7373
Assert-AreEqual $resultSetSub.Name $resultGetSub.Name "Subscription Updated earlier is not found"
7474

7575
# Delete the created/Updated Subscription

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusDRConfigurationTests/ServiceBusDRConfigurationsCURD.json

Lines changed: 1917 additions & 1715 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusQueueTests/ServiceBusQueueAuth_CURD.json

Lines changed: 336 additions & 258 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusQueueTests/ServiceBusQueue_CURD.json

Lines changed: 302 additions & 188 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusRuleTests/ServiceBusRule_CURD.json

Lines changed: 334 additions & 323 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusServiceTests/ServiceBusNameSpaceAuth_CURD_Tests.json

Lines changed: 231 additions & 180 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusServiceTests/ServiceBusNameSpace_CURD_Tests.json

Lines changed: 254 additions & 194 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusSubscriptionTests/ServiceBusSubscription_CURD.json

Lines changed: 278 additions & 279 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusTopicTests/ServiceBusTopicAuth_CURD.json

Lines changed: 332 additions & 311 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/SessionRecords/Microsoft.Azure.Commands.ServiceBus.Test.ScenarioTests.ServiceBusTopicTests/ServiceBusTopic_CURD.json

Lines changed: 234 additions & 177 deletions
Large diffs are not rendered by default.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus.Test/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<package id="Microsoft.Azure.Gallery" version="2.6.2-preview" targetFramework="net45" />
77
<package id="Microsoft.Azure.Management.Authorization" version="1.0.2" targetFramework="net452" />
88
<package id="Microsoft.Azure.Management.Resources" version="2.20.0-preview" targetFramework="net45" />
9-
<package id="Microsoft.Azure.Management.ServiceBus" version="1.0.3" targetFramework="net452" />
9+
<package id="Microsoft.Azure.Management.ServiceBus" version="1.1.0" targetFramework="net452" />
1010
<package id="Microsoft.Azure.Test.Framework" version="1.0.6179.26854-prerelease" targetFramework="net45" />
1111
<package id="Microsoft.Azure.Test.HttpRecorder" version="1.7.0" targetFramework="net45" />
1212
<package id="Microsoft.Bcl" version="1.1.10" targetFramework="net45" />

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Cmdlets/Queue/NewAzureServiceBusQueue.cs

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ public class NewAzureRmServiceBusQueue : AzureServiceBusCmdletBase
6868
[ValidateNotNullOrEmpty]
6969
public bool? DeadLetteringOnMessageExpiration { get; set; }
7070

71+
[Parameter(Mandatory = false, HelpMessage = "Enable Batched Operations - value that indicates whether server-side batched operations are enabled")]
72+
public SwitchParameter EnableBatchedOperations { get; set; }
73+
7174
[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "EnableExpress - a value that indicates whether Express Entities are enabled. An express queue holds a message in memory temporarily before writing it to persistent storage.")]
7275
[ValidateSet("TRUE", "FALSE", IgnoreCase = true)]
7376
[ValidateNotNullOrEmpty]
@@ -118,43 +121,48 @@ public override void ExecuteCmdlet()
118121
queueAttributes.EnablePartitioning = EnablePartitioning;
119122

120123
if (LockDuration != null)
121-
queueAttributes.LockDuration = LockDuration;
124+
{ queueAttributes.LockDuration = LockDuration; }
122125

123126
if (AutoDeleteOnIdle != null)
124-
queueAttributes.AutoDeleteOnIdle = AutoDeleteOnIdle;
127+
{ queueAttributes.AutoDeleteOnIdle = AutoDeleteOnIdle; }
125128

126129
if (DefaultMessageTimeToLive != null)
127-
queueAttributes.DefaultMessageTimeToLive = DefaultMessageTimeToLive;
130+
{ queueAttributes.DefaultMessageTimeToLive = DefaultMessageTimeToLive; }
128131

129132
if (DuplicateDetectionHistoryTimeWindow != null)
130-
queueAttributes.DuplicateDetectionHistoryTimeWindow = DuplicateDetectionHistoryTimeWindow;
133+
{ queueAttributes.DuplicateDetectionHistoryTimeWindow = DuplicateDetectionHistoryTimeWindow; }
131134

132135
if (DeadLetteringOnMessageExpiration != null)
133-
queueAttributes.DeadLetteringOnMessageExpiration = DeadLetteringOnMessageExpiration;
136+
{ queueAttributes.DeadLetteringOnMessageExpiration = DeadLetteringOnMessageExpiration; }
134137

135-
if (MaxSizeInMegabytes != null)
136-
queueAttributes.MaxSizeInMegabytes = (int?)MaxSizeInMegabytes;
138+
queueAttributes.EnableBatchedOperations = EnableBatchedOperations.IsPresent;
139+
140+
if (EnableExpress != null)
141+
{ queueAttributes.EnableExpress = EnableExpress; }
137142

138143
if (MaxDeliveryCount != null)
139-
queueAttributes.MaxDeliveryCount = MaxDeliveryCount;
144+
{ queueAttributes.MaxDeliveryCount = MaxDeliveryCount; }
145+
146+
if (MaxSizeInMegabytes != null)
147+
{ queueAttributes.MaxSizeInMegabytes = (int?)MaxSizeInMegabytes; }
140148

141149
if (MessageCount != null)
142-
queueAttributes.MessageCount = MessageCount;
150+
{ queueAttributes.MessageCount = MessageCount; }
143151

144152
if (RequiresDuplicateDetection != null)
145-
queueAttributes.RequiresDuplicateDetection = RequiresDuplicateDetection;
153+
{ queueAttributes.RequiresDuplicateDetection = RequiresDuplicateDetection; }
146154

147155
if (RequiresSession != null)
148-
queueAttributes.RequiresSession = RequiresSession;
156+
{ queueAttributes.RequiresSession = RequiresSession; }
149157

150158
if (SizeInBytes != null)
151-
queueAttributes.SizeInBytes = SizeInBytes;
159+
{ queueAttributes.SizeInBytes = SizeInBytes; }
152160

153161
if (ForwardTo != null)
154-
queueAttributes.ForwardTo = ForwardTo;
162+
{ queueAttributes.ForwardTo = ForwardTo; }
155163

156164
if (ForwardDeadLetteredMessagesTo != null)
157-
queueAttributes.ForwardDeadLetteredMessagesTo = ForwardDeadLetteredMessagesTo;
165+
{ queueAttributes.ForwardDeadLetteredMessagesTo = ForwardDeadLetteredMessagesTo; }
158166

159167

160168
if (ShouldProcess(target: Name, action: string.Format(Resources.CreateQueue, Name, Namespace)))

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Cmdlets/Subscription/NewAzureServiceBusSubscription.cs

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ public class NewAzureRmServiceBusSubscription : AzureServiceBusCmdletBase
5858
[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Dead Lettering On Message Expiration")]
5959
[ValidateSet("TRUE", "FALSE", IgnoreCase = true)]
6060
[ValidateNotNullOrEmpty]
61-
public bool? DeadLetteringOnMessageExpiration { get; set; }
61+
public bool? DeadLetteringOnMessageExpiration { get; set; }
62+
63+
[Parameter(Mandatory = false, HelpMessage = "Value that indicates whether a subscription has dead letter support on filter evaluation exceptions.")]
64+
public SwitchParameter DeadLetteringOnFilterEvaluationExceptions { get; set; }
6265

6366
[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Enable Batched Operations - value that indicates whether server-side batched operations are enabled")]
6467
[ValidateSet("TRUE", "FALSE", IgnoreCase = true)]
@@ -89,40 +92,37 @@ public override void ExecuteCmdlet()
8992
{
9093

9194
PSSubscriptionAttributes subAttributes = new PSSubscriptionAttributes();
92-
93-
PSNamespaceAttributes getNamespaceLoc = Client.GetNamespace(ResourceGroupName, Namespace);
94-
95+
9596
subAttributes.Name = Name;
9697

9798
if (AutoDeleteOnIdle != null)
98-
subAttributes.AutoDeleteOnIdle = AutoDeleteOnIdle;
99+
{ subAttributes.AutoDeleteOnIdle = AutoDeleteOnIdle; }
99100

100101
if (DefaultMessageTimeToLive != null)
101-
subAttributes.DefaultMessageTimeToLive = DefaultMessageTimeToLive;
102+
{ subAttributes.DefaultMessageTimeToLive = DefaultMessageTimeToLive; }
102103

103104
if (LockDuration != null)
104-
subAttributes.LockDuration = LockDuration;
105+
{ subAttributes.LockDuration = LockDuration; }
105106

106107
if (DeadLetteringOnMessageExpiration != null)
107-
subAttributes.DeadLetteringOnMessageExpiration = DeadLetteringOnMessageExpiration;
108+
{ subAttributes.DeadLetteringOnMessageExpiration = DeadLetteringOnMessageExpiration; }
108109

109-
if (EnableBatchedOperations != null)
110-
subAttributes.EnableBatchedOperations = EnableBatchedOperations;
110+
subAttributes.DeadLetteringOnFilterEvaluationExceptions = DeadLetteringOnFilterEvaluationExceptions.IsPresent;
111111

112-
if (DeadLetteringOnMessageExpiration != null)
113-
subAttributes.DeadLetteringOnMessageExpiration = DeadLetteringOnMessageExpiration;
112+
if (EnableBatchedOperations != null)
113+
{ subAttributes.EnableBatchedOperations = EnableBatchedOperations; }
114114

115115
if (MaxDeliveryCount != null)
116-
subAttributes.MaxDeliveryCount = MaxDeliveryCount;
116+
{ subAttributes.MaxDeliveryCount = MaxDeliveryCount; }
117117

118118
if (RequiresSession != null)
119-
subAttributes.RequiresSession = RequiresSession;
119+
{ subAttributes.RequiresSession = RequiresSession; }
120120

121121
if (ForwardTo != null)
122-
subAttributes.ForwardTo = ForwardTo;
122+
{ subAttributes.ForwardTo = ForwardTo; }
123123

124124
if (ForwardDeadLetteredMessagesTo != null)
125-
subAttributes.ForwardDeadLetteredMessagesTo = ForwardDeadLetteredMessagesTo;
125+
{ subAttributes.ForwardDeadLetteredMessagesTo = ForwardDeadLetteredMessagesTo; }
126126

127127
if (ShouldProcess(target: Name, action: string.Format(Resources.CreateSubscription, Name, Topic,Namespace)))
128128
{

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Cmdlets/Topic/NewAzureServiceBusTopic.cs

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -95,40 +95,35 @@ public override void ExecuteCmdlet()
9595

9696
topicAttributes.Name = Name;
9797

98-
if(EnablePartitioning != null)
99-
topicAttributes.EnablePartitioning = EnablePartitioning;
100-
98+
if (EnablePartitioning != null)
99+
{ topicAttributes.EnablePartitioning = EnablePartitioning; }
101100

102101
if (AutoDeleteOnIdle != null)
103-
topicAttributes.AutoDeleteOnIdle = AutoDeleteOnIdle;
102+
{ topicAttributes.AutoDeleteOnIdle = AutoDeleteOnIdle; }
104103

105104
if (DefaultMessageTimeToLive != null)
106-
topicAttributes.DefaultMessageTimeToLive = DefaultMessageTimeToLive;
105+
{ topicAttributes.DefaultMessageTimeToLive = DefaultMessageTimeToLive; }
107106

108107
if (DuplicateDetectionHistoryTimeWindow != null)
109-
topicAttributes.DuplicateDetectionHistoryTimeWindow = DuplicateDetectionHistoryTimeWindow;
110-
108+
{ topicAttributes.DuplicateDetectionHistoryTimeWindow = DuplicateDetectionHistoryTimeWindow; }
111109

112110
if (EnableBatchedOperations != null)
113-
topicAttributes.EnableBatchedOperations = EnableBatchedOperations;
114-
115-
111+
{ topicAttributes.EnableBatchedOperations = EnableBatchedOperations; }
116112

117113
if (EnableExpress != null)
118-
topicAttributes.EnableExpress = EnableExpress;
119-
114+
{ topicAttributes.EnableExpress = EnableExpress; }
120115

121116
if (MaxSizeInMegabytes != null)
122-
topicAttributes.MaxSizeInMegabytes = (int?)MaxSizeInMegabytes;
117+
{ topicAttributes.MaxSizeInMegabytes = (int?)MaxSizeInMegabytes; }
123118

124119
if (RequiresDuplicateDetection != null)
125-
topicAttributes.RequiresDuplicateDetection = RequiresDuplicateDetection;
120+
{ topicAttributes.RequiresDuplicateDetection = RequiresDuplicateDetection; }
126121

127122
if (SupportOrdering != null)
128-
topicAttributes.SupportOrdering = SupportOrdering;
123+
{ topicAttributes.SupportOrdering = SupportOrdering; }
129124

130125
if (SizeInBytes != null)
131-
topicAttributes.SizeInBytes = SizeInBytes;
126+
{ topicAttributes.SizeInBytes = SizeInBytes; }
132127

133128
if (ShouldProcess(target: Name, action: string.Format(Resources.CreateTopic, Name, Namespace)))
134129
{

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Cmdlets/Topic/SetAzureServiceBusTopic.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public override void ExecuteCmdlet()
5252
if (InputObject != null)
5353
{
5454
topicAttributes = InputObject;
55-
}
55+
}
5656

5757
if (ShouldProcess(target: Name, action: string.Format(Resources.UpdateTopic, Name, Namespace)))
5858
{

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Commands.ServiceBus.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@
4242
</PropertyGroup>
4343
<ItemGroup>
4444
<Reference Include="Microsoft.Azure.Management.ServiceBus, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
45-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.ServiceBus.1.0.3\lib\net452\Microsoft.Azure.Management.ServiceBus.dll</HintPath>
45+
<SpecificVersion>False</SpecificVersion>
46+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.ServiceBus.1.1.0\lib\net452\Microsoft.Azure.Management.ServiceBus.dll</HintPath>
4647
<Private>True</Private>
4748
</Reference>
4849
<Reference Include="System.Management.Automation" />

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Models/PSQueueAttributes.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public PSQueueAttributes(SBQueue quResource)
5050
UpdatedAt = quResource.UpdatedAt;
5151
ForwardTo = quResource.ForwardTo;
5252
ForwardDeadLetteredMessagesTo = quResource.ForwardDeadLetteredMessagesTo;
53+
EnableBatchedOperations = quResource.EnableBatchedOperations;
5354

5455
}
5556
}
@@ -178,6 +179,12 @@ public PSQueueAttributes(SBQueue quResource)
178179
/// </summary>
179180
public string ForwardDeadLetteredMessagesTo { get; set; }
180181

182+
/// <summary>
183+
/// Value that indicates whether server-side batched operations are
184+
/// enabled..
185+
/// </summary>
186+
public bool? EnableBatchedOperations { get; set; }
187+
181188

182189
}
183190
}

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Models/PSSubscriptionAttributes.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ public PSSubscriptionAttributes(SBSubscription subscriptionResource)
4545
Name = subscriptionResource.Name;
4646
ForwardTo = subscriptionResource.ForwardTo;
4747
ForwardDeadLetteredMessagesTo = subscriptionResource.ForwardDeadLetteredMessagesTo;
48+
DeadLetteringOnFilterEvaluationExceptions = subscriptionResource.DeadLetteringOnFilterEvaluationExceptions;
4849
}
4950
}
5051

@@ -137,5 +138,10 @@ public PSSubscriptionAttributes(SBSubscription subscriptionResource)
137138
/// </summary>
138139
public string ForwardDeadLetteredMessagesTo { get; set; }
139140

141+
/// <summary>
142+
/// Value that indicates whether a subscription has dead letter support on filter evaluation exceptions.
143+
/// </summary>
144+
public bool? DeadLetteringOnFilterEvaluationExceptions { get; set; }
145+
140146
}
141147
}

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Models/PSTopicAttributes.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,7 @@ public PSTopicAttributes(SBTopic topicResource)
5454
/// <summary>
5555
/// Queue name.
5656
/// </summary>
57-
public string Name { get; set; }
58-
59-
57+
public string Name { get; set; }
6058

6159
/// <summary>
6260
/// Id of the resource.

‎src/ResourceManager/ServiceBus/Commands.ServiceBus/Utilities/ServiceBusClient.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,8 @@ public PSQueueAttributes CreateUpdateQueue(string resourceGroupName, string name
221221
parameters.DeadLetteringOnMessageExpiration = queue.DeadLetteringOnMessageExpiration;
222222
if (queue.EnableExpress.HasValue)
223223
parameters.EnableExpress = queue.EnableExpress;
224+
if (queue.EnableBatchedOperations.HasValue)
225+
parameters.EnableBatchedOperations = queue.EnableBatchedOperations;
224226
if (queue.EnablePartitioning.HasValue)
225227
parameters.EnablePartitioning = queue.EnablePartitioning;
226228
if (queue.MaxDeliveryCount.HasValue)
@@ -456,6 +458,8 @@ public PSSubscriptionAttributes CreateUpdateSubscription(string resourceGroupNam
456458
parameters.LockDuration = (TimeSpan?)AzureServiceBusCmdletBase.ParseTimespan(subscription.LockDuration);
457459
if (subscription.DeadLetteringOnMessageExpiration.HasValue)
458460
parameters.DeadLetteringOnMessageExpiration = subscription.DeadLetteringOnMessageExpiration;
461+
if (subscription.DeadLetteringOnFilterEvaluationExceptions.HasValue)
462+
parameters.DeadLetteringOnFilterEvaluationExceptions = subscription.DeadLetteringOnFilterEvaluationExceptions;
459463
if (subscription.EnableBatchedOperations.HasValue)
460464
parameters.EnableBatchedOperations = subscription.EnableBatchedOperations;
461465
if (subscription.MaxDeliveryCount.HasValue)

0 commit comments

Comments
 (0)