Add build exceptions, Remove nullable type from parameter, MAke a parameter mandatory in SetExpiry

Author: rahuldutta90

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/DataPlaneCommands/SetAzureRmDataLakeStoreItemExpiry.cs

@@ -45,17 +45,17 @@ public class SetAzureRmDataLakeStoreItemExpiry : DataLakeStoreFileSystemCmdletBa
             HelpMessage =
                 "The expiration time for the specified file. If no value or set to MaxValue, the file will never expire.")]
         [ValidateNotNullOrEmpty]
-        public DateTimeOffset? Expiration { get; set; }
+        public DateTimeOffset Expiration { get; set; }
 
-        [Parameter(ValueFromPipelineByPropertyName = true, Position = 2,ParameterSetName = RelativeExpiryParameterSetName, Mandatory = false,
+        [Parameter(ValueFromPipelineByPropertyName = true, Position = 2,ParameterSetName = RelativeExpiryParameterSetName, Mandatory = true,
             HelpMessage = "Relative expiry options. RelativeToNow or RelativeToCreationDate are current options")]
         [ValidateNotNullOrEmpty]
-        public DataLakeStoreEnums.PathRelativeExpiryOptions? RelativeFileExpiryOption { get; set; }
+        public DataLakeStoreEnums.PathRelativeExpiryOptions RelativeFileExpiryOption { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 3, ParameterSetName = RelativeExpiryParameterSetName, Mandatory = false,
-            HelpMessage = "The relative time in milliseconds with respect to now or creation time")]
+            HelpMessage = "The relative time in milliseconds with respect to now or creation time. By default it will be zero.")]
         [ValidateNotNullOrEmpty]
-        public long? RelativeTime { get; set; }
+        public long RelativeTime { get; set; }
 
         public override void ExecuteCmdlet()
         {
@@ -72,21 +72,21 @@ public override void ExecuteCmdlet()
                         ? ExpiryOption.RelativeToCreationDate
                         : ExpiryOption
                             .RelativeToNow;
-                tickValue = RelativeTime.Value;
+                tickValue = RelativeTime;
             }
             else
             {
-                if (!Expiration.HasValue)
+                if (!MyInvocation.BoundParameters.ContainsKey(nameof(Expiration)))
                 {
                     Expiration = DateTimeOffset.MaxValue;
                 }
-                tickValue = DataLakeStoreFileSystemClient.ToUnixTimeStampMs(Expiration.GetValueOrDefault());
+                tickValue = DataLakeStoreFileSystemClient.ToUnixTimeStampMs(Expiration);
             }
             ConfirmAction(
-                string.Format(Resources.SetFileExpiry, Path.OriginalPath, Expiration.GetValueOrDefault()),
+                string.Format(Resources.SetFileExpiry, Path.OriginalPath, ParameterSetName.Equals(RelativeExpiryParameterSetName) ? $"{exop} {RelativeTime}" : Expiration.ToString()),
                 Path.OriginalPath,
                 () =>
-                    WriteObject(new DataLakeStoreItem(DataLakeStoreFileSystemClient.SetExpiry(Path.TransformedPath, Account, tickValue,exop)))
+                    WriteObject(new DataLakeStoreItem(DataLakeStoreFileSystemClient.SetExpiry(Path.TransformedPath, Account, tickValue, exop)))
             );
         }
     }

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/DataPlaneModels/AdlsClientFactory.cs

@@ -5,6 +5,7 @@
 using System.Text.RegularExpressions;
 using Microsoft.Azure.DataLake.Store.MockAdlsFileSystem;
 using Microsoft.Rest;
+using Microsoft.WindowsAzure.Commands.Common;
 
 namespace Microsoft.Azure.Commands.DataLakeStore.Models
 {
@@ -55,6 +56,7 @@ internal static AdlsClient GetAdlsClient(string accntNm, IAzureContext context)
                         AzureEnvironment.Endpoint.AzureDataLakeStoreFileSystemEndpointSuffix);
                 }
                 var client=AdlsClient.CreateClient(accntNm,creds);
+                client.AddUserAgentSuffix(AzurePowerShell.UserAgentValue.ToString());
                 ClientFactory.Add(accntNm,client);
                 return client;
             }

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/help/Set-AzureRmDataLakeStoreItemExpiry.md

@@ -114,7 +114,7 @@ Parameter Sets: Set expiry as relative to creation or now
 Aliases: 
 Accepted values: RelativeToNow, RelativeToCreationDate
 
-Required: False
+Required: True
 Position: 2
 Default value: None
 Accept pipeline input: True (ByPropertyName)

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

@@ -766,9 +766,9 @@
 "d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Sql\Microsoft.Azure.Commands.Sql.dll","Microsoft.Azure.Commands.Sql.Database.Cmdlet.SetAzureSqlDatabase","Set-AzureRmSqlDatabase","0","2100","The parameter 'ElasticPoolName' in cmdlet 'Set-AzureRmSqlDatabase' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'ElasticPoolName' back to the parameter set '__AllParameterSets'."
 "d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Sql\Microsoft.Azure.Commands.Sql.dll","Microsoft.Azure.Commands.Sql.Database.Cmdlet.SetAzureSqlDatabase","Set-AzureRmSqlDatabase","0","2100","The parameter 'ReadScale' in cmdlet 'Set-AzureRmSqlDatabase' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'ReadScale' back to the parameter set '__AllParameterSets'."
 "d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.Sql\Microsoft.Azure.Commands.Sql.dll","Microsoft.Azure.Commands.Sql.Database.Cmdlet.SetAzureSqlDatabase","Set-AzureRmSqlDatabase","0","2100","The parameter 'Tags' in cmdlet 'Set-AzureRmSqlDatabase' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Tags' back to the parameter set '__AllParameterSets'."
-"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","3000","The type of property 'Type' of type 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreItem' has changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType'.","Change the type of property 'Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."
 "d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","2100","The parameter 'Account' in cmdlet 'Set-AzureRmDataLakeStoreItemExpiry' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Account' back to the parameter set '__AllParameterSets'."
 "d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","2100","The parameter 'Path' in cmdlet 'Set-AzureRmDataLakeStoreItemExpiry' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Path' back to the parameter set '__AllParameterSets'."
 "d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","2100","The parameter 'Expiration' in cmdlet 'Set-AzureRmDataLakeStoreItemExpiry' is no longer in the parameter set '__AllParameterSets'.","Add parameter 'Expiration' back to the parameter set '__AllParameterSets'."
-"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.GetAzureDataLakeStoreChildItem","Get-AzureRmDataLakeStoreChildItem","0","3000","The type of property 'Type' of type 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreItem' has changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType'.","Change the type of property 'Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."
-"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.GetAzureDataLakeStoreItem","Get-AzureRmDataLakeStoreItem","0","3000","The type of property 'Type' of type 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreItem' has changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType'.","Change the type of property 'Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.SetAzureRmDataLakeStoreItemExpiry","Set-AzureRmDataLakeStoreItemExpiry","0","3030","The generic type for 'property Type' has been changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'System.Nullable`1[Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType]'. ","Change the generic type for 'property Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.GetAzureDataLakeStoreChildItem","Get-AzureRmDataLakeStoreChildItem","0","3030","The generic type for 'property Type' has been changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'System.Nullable`1[Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType]'. ","Change the generic type for 'property Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."
+"d:\workspace\powershell\src\Package\Debug\ResourceManager\AzureResourceManager\AzureRM.DataLakeStore\Microsoft.Azure.Commands.DataLakeStore.dll","Microsoft.Azure.Commands.DataLakeStore.GetAzureDataLakeStoreItem","Get-AzureRmDataLakeStoreItem","0","3030","The generic type for 'property Type' has been changed from 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]' to 'System.Nullable`1[Microsoft.Azure.Commands.DataLakeStore.Models.DataLakeStoreEnums+FileType]'. ","Change the generic type for 'property Type' back to 'System.Nullable`1[Microsoft.Azure.Management.DataLake.Store.Models.FileType]'."