Skip to content

Commit 1c331ab

Browse files
authored
Merge pull request #4167 from nicolaszhang/auth-key-preview-branch2
Introduce gateway auth key feature
2 parents 2d3edf6 + ce38712 commit 1c331ab

21 files changed

+1404
-8
lines changed

src/ResourceManager/DataFactories/AzureRM.DataFactories.psd1

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ CmdletsToExport = 'Remove-AzureRmDataFactory', 'Get-AzureRmDataFactoryRun',
7878
'New-AzureRmDataFactoryEncryptValue',
7979
'Get-AzureRmDataFactoryGateway', 'New-AzureRmDataFactoryGateway',
8080
'New-AzureRmDataFactoryGatewayKey',
81+
'Get-AzureRmDataFactoryGatewayAuthkey', 'New-AzureRmDataFactoryGatewayAuthkey',
8182
'Remove-AzureRmDataFactoryGateway', 'Set-AzureRmDataFactoryGateway',
8283
'Get-AzureRmDataFactoryHub', 'New-AzureRmDataFactoryHub',
8384
'Remove-AzureRmDataFactoryHub',

src/ResourceManager/DataFactories/ChangeLog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
-->
2020
## Current Release
2121

22+
* Deprecate New-AzureRmDataFactoryGatewayKey
23+
* Introduce gateway auth key feature by adding New-AzureRmDataFactoryGatewayAuthKey and Get-AzureRmDataFactoryGatewayAuthKey
24+
2225
## Version 3.1.0
2326

2427
## Version 3.0.1

src/ResourceManager/DataFactories/Commands.DataFactories.Test/Commands.DataFactories.Test.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Authorization.2.0.0\lib\net40\Microsoft.Azure.Management.Authorization.dll</HintPath>
6666
</Reference>
6767
<Reference Include="Microsoft.Azure.Management.DataFactories">
68-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataFactories.4.11.1\lib\net45\Microsoft.Azure.Management.DataFactories.dll</HintPath>
68+
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataFactories.4.13.0\lib\net45\Microsoft.Azure.Management.DataFactories.dll</HintPath>
6969
</Reference>
7070
<Reference Include="Microsoft.Azure.ResourceManager, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
7171
<SpecificVersion>False</SpecificVersion>
@@ -249,6 +249,9 @@
249249
<None Include="SessionRecords\Microsoft.Azure.Commands.DataFactories.Test.DataFactoryGatewayTests\TestCreateDataFactoryGatewayWithDataFactoryParameter.json">
250250
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
251251
</None>
252+
<None Include="SessionRecords\Microsoft.Azure.Commands.DataFactories.Test.DataFactoryGatewayTests\TestDataFactoryGatewayAuthKey.json">
253+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
254+
</None>
252255
<None Include="SessionRecords\Microsoft.Azure.Commands.DataFactories.Test.DataFactoryGatewayTests\TestGetNonExistingDataFactoryGateway.json">
253256
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
254257
</None>

src/ResourceManager/DataFactories/Commands.DataFactories.Test/ScenarioTests/DataFactoryGatewayTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,13 @@ public void TestCreateDataFactoryGateway()
3737
RunPowerShellTest("Test-DataFactoryGateway");
3838
}
3939

40+
[Fact]
41+
[Trait(Category.AcceptanceType, Category.CheckIn)]
42+
public void TestDataFactoryGatewayAuthKey()
43+
{
44+
RunPowerShellTest("Test-DataFactoryGatewayAuthKey");
45+
}
46+
4047
[Fact(Skip = "test takes too long (more than 5 sec)")]
4148
[Trait(Category.AcceptanceType, Category.CheckIn)]
4249
public void TestCreateDataFactoryGatewayWithDataFactoryParameter()

src/ResourceManager/DataFactories/Commands.DataFactories.Test/ScenarioTests/DataFactoryGatewayTests.ps1

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function Test-DataFactoryGateway
5353
$actual = New-AzureRmDataFactoryGateway -ResourceGroupName $rgname -DataFactoryName $dfname -Name $gwname
5454
$expected = Get-AzureRmDataFactoryGateway -ResourceGroupName $rgname -DataFactoryName $dfname -Name $gwname
5555
Assert-AreEqual $actual.Name $expected.Name
56-
Assert-NotNull $actual.Key
56+
Assert-NotNull $actual.Key
5757

5858
$key = New-AzureRmDataFactoryGatewayKey -ResourceGroupName $rgname -DataFactoryName $dfname -GatewayName $gwname
5959
Assert-NotNull $key
@@ -70,6 +70,50 @@ function Test-DataFactoryGateway
7070
}
7171
}
7272

73+
<#
74+
.SYNOPSIS
75+
Create a gateway and then try to get auth keys and new auth keys.
76+
Delete the created gateway after test finishes.
77+
#>
78+
function Test-DataFactoryGatewayAuthKey
79+
{
80+
$dfname = Get-DataFactoryName
81+
$rgname = Get-ResourceGroupName
82+
$rglocation = Get-ProviderLocation ResourceManagement
83+
$dflocation = Get-ProviderLocation DataFactoryManagement
84+
85+
New-AzureRmResourceGroup -Name $rgname -Location $rglocation -Force
86+
87+
try
88+
{
89+
New-AzureRmDataFactory -ResourceGroupName $rgname -Name $dfname -Location $dflocation -Force
90+
91+
$gwname = "foo"
92+
$description = "description"
93+
94+
$actual = New-AzureRmDataFactoryGateway -ResourceGroupName $rgname -DataFactoryName $dfname -Name $gwname
95+
$expected = Get-AzureRmDataFactoryGateway -ResourceGroupName $rgname -DataFactoryName $dfname -Name $gwname
96+
Assert-AreEqual $actual.Name $expected.Name
97+
Assert-NotNull $actual.Key
98+
99+
$key = Get-AzureRmDataFactoryGatewayAuthKey -ResourceGroupName $rgname -DataFactoryName $dfname -GatewayName $gwname
100+
Assert-NotNull $key
101+
Assert-NotNull $key.Key1
102+
Assert-NotNull $key.Key2
103+
104+
$keyName = 'key2'
105+
$newKey = New-AzureRmDataFactoryGatewayAuthKey -ResourceGroupName $rgname -DataFactoryName $dfname -GatewayName $gwname -KeyName $keyName
106+
Assert-NotNull $key.Key2
107+
Assert-AreNotEqual $key.Key2 $newKey.Key2
108+
109+
Remove-AzureRmDataFactoryGateway -ResourceGroupName $rgname -DataFactoryName $dfname -Name $gwname -Force
110+
}
111+
finally
112+
{
113+
Clean-DataFactory $rgname $dfname
114+
}
115+
}
116+
73117
<#
74118
.SYNOPSIS
75119
Use the datafactory parameter to create a gateway and then do a Get to compare the result are identical.

0 commit comments

Comments
 (0)