Skip to content

Commit 1d460a1

Browse files
authored
Merge pull request #11035 from msJinLei/removeparamset
Fix "New-AzADServicePrincipal does not work with ApplicationObject param
2 parents bc7970d + aefff0c commit 1d460a1

File tree

71 files changed

+165
-140
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+165
-140
lines changed

src/Resources/Resources/ActiveDirectory/Cmdlets/NewAzureADServicePrincipalCommand.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ public class NewAzureADServicePrincipalCommand : ActiveDirectoryBaseCmdlet
6363
[ValidateNotNullOrEmpty]
6464
public string DisplayName { get; set; }
6565

66-
[Parameter(Mandatory = true, ValueFromPipeline = true, ParameterSetName = ParameterSet.ApplicationObjectWithoutCredential,
67-
HelpMessage = "The object representing the application for which the service principal is created.")]
6866
[Parameter(Mandatory = true, ValueFromPipeline = true, ParameterSetName = ParameterSet.ApplicationObjectWithPasswordPlain,
6967
HelpMessage = "The object representing the application for which the service principal is created.")]
7068
[Parameter(Mandatory = true, ValueFromPipeline = true, ParameterSetName = ParameterSet.ApplicationObjectWithPasswordCredential,

src/Resources/Resources/ActiveDirectory/Models/ParameterSet.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public static class ParameterSet
4242
public const string ApplicationWithPasswordCredential = "ApplicationWithPasswordCredentialParameterSet";
4343
public const string ApplicationWithKeyPlain = "ApplicationWithKeyPlainParameterSet";
4444
public const string ApplicationWithKeyCredential = "ApplicationWithKeyCredentialParameterSet";
45-
public const string ApplicationObjectWithoutCredential = "ApplicationObjectWithoutCredentialParameterSet";
4645
public const string ApplicationObjectWithPasswordPlain = "ApplicationObjectWithPasswordPlainParameterSet";
4746
public const string ApplicationObjectWithPasswordCredential = "ApplicationObjectWithPasswordCredentialParameterSet";
4847
public const string ApplicationObjectWithKeyPlain = "ApplicationObjectWithKeyPlainParameterSet";

src/Resources/Resources/ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
- Refactor *-AzDeployment cmdlets to work specificly at subscription scope
2525
- Created aliases *-AzSubscriptionDeployment for *-AzDeployment cmdlets
2626
* Fix `Update-AzADApplication` when parameter `AvailableToOtherTenants` is not set
27+
* Remove ApplicationObjectWithoutCredentialParameterSet to avoid AmbiguousParameterSetException.
28+
* Regenerate help files
2729

2830
## Version 1.10.0
2931
* Make -Scope optional in *-AzPolicyAssignment cmdlets with default to context subscription

src/Resources/Resources/help/Add-AzADGroupMember.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ Accept wildcard characters: False
217217
```
218218
219219
### CommonParameters
220-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
220+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
221221
222222
## INPUTS
223223

src/Resources/Resources/help/Export-AzResourceGroup.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ Captures a resource group as a template and saves it to a file.
1515

1616
```
1717
Export-AzResourceGroup -ResourceGroupName <String> [-Path <String>] [-IncludeParameterDefaultValue]
18-
[-IncludeComments] [-SkipResourceNameParameterization] [-SkipAllParameterization]
19-
[-Resource <String[]>] [-Force] [-ApiVersion <String>] [-Pre]
20-
[-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
18+
[-IncludeComments] [-SkipResourceNameParameterization] [-SkipAllParameterization] [-Resource <String[]>]
19+
[-Force] [-ApiVersion <String>] [-Pre] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
20+
[<CommonParameters>]
2121
```
2222

2323
## DESCRIPTION
@@ -161,33 +161,33 @@ Accept pipeline input: False
161161
Accept wildcard characters: False
162162
```
163163
164-
### -ResourceGroupName
165-
Specifies the name of the resource group to export.
164+
### -Resource
165+
A list of resourceIds to filter the results by.
166166
167167
```yaml
168-
Type: System.String
168+
Type: System.String[]
169169
Parameter Sets: (All)
170-
Aliases: ResourceGroup
170+
Aliases:
171171

172-
Required: True
172+
Required: False
173173
Position: Named
174174
Default value: None
175-
Accept pipeline input: True (ByPropertyName)
175+
Accept pipeline input: False
176176
Accept wildcard characters: False
177177
```
178178
179-
### -Resource
180-
A list of resourceIds to filter the results by.
179+
### -ResourceGroupName
180+
Specifies the name of the resource group to export.
181181
182182
```yaml
183-
Type: System.String[]
183+
Type: System.String
184184
Parameter Sets: (All)
185-
Aliases:
185+
Aliases: ResourceGroup
186186

187-
Required: False
187+
Required: True
188188
Position: Named
189189
Default value: None
190-
Accept pipeline input: False
190+
Accept pipeline input: True (ByPropertyName)
191191
Accept wildcard characters: False
192192
```
193193

src/Resources/Resources/help/Get-AzADAppCredential.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ Accept wildcard characters: False
134134
```
135135
136136
### CommonParameters
137-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
137+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
138138
139139
## INPUTS
140140

src/Resources/Resources/help/Get-AzADApplication.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ Accept wildcard characters: False
226226
```
227227
228228
### CommonParameters
229-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
229+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
230230
231231
## INPUTS
232232

src/Resources/Resources/help/Get-AzADGroup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ Accept wildcard characters: False
193193
```
194194
195195
### CommonParameters
196-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
196+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
197197
198198
## INPUTS
199199

src/Resources/Resources/help/Get-AzADGroupMember.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ Accept wildcard characters: False
168168
```
169169
170170
### CommonParameters
171-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
171+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
172172
173173
## INPUTS
174174

src/Resources/Resources/help/Get-AzADServicePrincipal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ Accept wildcard characters: False
253253
```
254254
255255
### CommonParameters
256-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
256+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
257257
258258
## INPUTS
259259

src/Resources/Resources/help/Get-AzADSpCredential.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ Accept wildcard characters: False
143143
```
144144
145145
### CommonParameters
146-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
146+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
147147
148148
## INPUTS
149149

src/Resources/Resources/help/Get-AzADUser.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ Accept wildcard characters: False
236236
```
237237
238238
### CommonParameters
239-
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see about_CommonParameters (http://go.microsoft.com/fwlink/?LinkID=113216).
239+
This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
240240
241241
## INPUTS
242242

0 commit comments

Comments
 (0)