Skip to content

Commit 1decdb5

Browse files
authored
Acr fix (#14177) (#14189)
* fix docker push issue: use refresh token to login * changelog * OOB release for Az.ContainerReigstry * resolve comments
1 parent 6a5d296 commit 1decdb5

File tree

6 files changed

+10
-16
lines changed

6 files changed

+10
-16
lines changed

src/ContainerRegistry/ContainerRegistry/Az.ContainerRegistry.psd1

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# RootModule = ''
1313

1414
# Version number of this module.
15-
ModuleVersion = '2.2.0'
15+
ModuleVersion = '2.2.1'
1616

1717
# Supported PSEditions
1818
CompatiblePSEditions = 'Core', 'Desktop'
@@ -132,16 +132,7 @@ PrivateData = @{
132132
# IconUri = ''
133133

134134
# ReleaseNotes of this module
135-
ReleaseNotes = '* Added cmdlets to supported repository, manifest, and tag operations:
136-
- ''Get-AzContainerRegistryRepository''
137-
- ''Update-AzContainerRegistryRepository''
138-
- ''Remove-AzContainerRegistryRepository''
139-
- ''Get-AzContainerRegistryManifest''
140-
- ''Update-AzContainerRegistryManifest''
141-
- ''Remove-AzContainerRegistryManifest''
142-
- ''Get-AzContainerRegistryTag''
143-
- ''Update-AzContainerRegistryTag''
144-
- ''Remove-AzContainerRegistryTag'''
135+
ReleaseNotes = 'Fixed authentication for `Connect-AzContainerRegistry`'
145136

146137
# Prerelease string of this module
147138
# Prerelease = ''

src/ContainerRegistry/ContainerRegistry/ChangeLog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
-->
2020
## Upcoming Release
2121

22+
## Version 2.2.1
23+
* Fixed authentication for `Connect-AzContainerRegistry`
24+
2225
## Version 2.2.0
2326
* Added cmdlets to supported repository, manifest, and tag operations:
2427
- `Get-AzContainerRegistryRepository`

src/ContainerRegistry/ContainerRegistry/Commands/ConnectAzureContainerRegistry.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public override void ExecuteCmdlet() {
5555
if (ParameterSetName.Equals(WithoutNameAndPasswordParameterSet))
5656
{
5757
this.UserName = new Guid().ToString();
58-
this.Password = this.RegistryDataPlaneClient.Authenticate();
58+
this.Password = this.RegistryDataPlaneClient.GetRefreshToken();
5959
}
6060

6161
string LoginScript = string.Format("'{2}' | docker login {0} -u {1} --password-stdin", this.RegistryDataPlaneClient.GetEndPoint(), this.UserName, this.Password);

src/ContainerRegistry/ContainerRegistry/Models/ContainerRegistryDataPlaneClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ private string GetArmAccessToken()
113113
.AccessToken;
114114
}
115115

116-
private string GetRefreshToken()
116+
public string GetRefreshToken()
117117
{
118118
return GetClient()
119119
.RefreshTokens

src/ContainerRegistry/ContainerRegistry/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
[assembly: ComVisible(false)]
2626
[assembly: CLSCompliant(false)]
2727
[assembly: Guid("FE330703-623A-4C08-9DA7-1C63B4058034")]
28-
[assembly: AssemblyVersion("2.2.0")]
29-
[assembly: AssemblyFileVersion("2.2.0")]
28+
[assembly: AssemblyVersion("2.2.1")]
29+
[assembly: AssemblyFileVersion("2.2.1")]
3030
#if !SIGN
3131
[assembly: InternalsVisibleTo("Microsoft.Azure.PowerShell.Cmdlets.ContainerRegistry.Test")]
3232
#endif

tools/Az/Az.psd1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ RequiredModules = @(@{ModuleName = 'Az.Accounts'; ModuleVersion = '2.2.5'; },
6666
@{ModuleName = 'Az.CognitiveServices'; RequiredVersion = '1.8.0'; },
6767
@{ModuleName = 'Az.Compute'; RequiredVersion = '4.9.0'; },
6868
@{ModuleName = 'Az.ContainerInstance'; RequiredVersion = '1.0.3'; },
69-
@{ModuleName = 'Az.ContainerRegistry'; RequiredVersion = '2.2.0'; },
69+
@{ModuleName = 'Az.ContainerRegistry'; RequiredVersion = '2.2.1'; },
7070
@{ModuleName = 'Az.CosmosDB'; RequiredVersion = '1.0.0'; },
7171
@{ModuleName = 'Az.DataBoxEdge'; RequiredVersion = '1.1.0'; },
7272
@{ModuleName = 'Az.Databricks'; RequiredVersion = '1.1.0'; },

0 commit comments

Comments
 (0)