Merge pull request #7664 from vinayada1/statsCmdletsPeeringMandatory

Make Peering Type as a mandatory parameter since these cmdlets work only on a specific peering

Author: markcowl

src/ResourceManager/Network/Commands.Network/ChangeLog.md

@@ -18,6 +18,13 @@
         - Additional information about change #1
 --->
 ## Current Release
+* Changed PeeringType to be a mandatory parameter for the following cmdlets:-
+    - Get-AzureRmExpressRouteCircuitRouteTable
+    - Get-AzureRmExpressRouteCircuitARPTable
+    - Get-AzureRmExpressRouteCircuitRouteTableSummary
+    - Get-AzureRMExpressRouteCrossConnectionArpTable
+    - Get-AzureRMExpressRouteCrossConnectionRouteTable
+    - Get-AzureRMExpressRouteCrossConnectionRouteTableSummary
 
 ## Version 6.9.1
 * Update cmdlet Test-AzureRmNetworkWatcherConnectivity, pass the protocol value to backend.

src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/Stats/GetAzureExpressRouteCircuitARPTableCommand.cs

@@ -52,7 +52,7 @@ public class GetAzureExpressRouteCircuitARPTableCommand : NetworkBaseCmdlet
          public string ExpressRouteCircuitName { get; set; }		
 
          [Parameter(		
-             Mandatory = false,		
+             Mandatory = true,		
              HelpMessage = "The PeeringType")]		
          [ValidateSet(		
             MNM.ExpressRoutePeeringType.AzurePrivatePeering,		

src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/Stats/GetAzureExpressRouteCircuitRouteTableCommand.cs

@@ -46,7 +46,7 @@ public class GetAzureRmExpressRouteCircuitRouteTable : NetworkBaseCmdlet
          public string ExpressRouteCircuitName { get; set; }		
 
          [Parameter(		
-             Mandatory = false,		
+             Mandatory = true,		
              HelpMessage = "The PeeringType")]		
          [ValidateSet(		
             MNM.ExpressRoutePeeringType.AzurePrivatePeering,		

src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/Stats/GetAzureExpressRouteCircuitRouteTableSummaryCommand.cs

@@ -46,7 +46,7 @@ public class GetAzureRmExpressRouteCircuitRouteTableSummaryCommand : NetworkBase
         public string ExpressRouteCircuitName { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "The PeeringType")]
         [ValidateSet(
            MNM.ExpressRoutePeeringType.AzurePrivatePeering,

src/ResourceManager/Network/Commands.Network/ExpressRouteCrossConnection/CrossConnectionPeeringStats/GetAzureRMExpressRouteCrossConnectionArpTableCommand.cs

@@ -54,7 +54,7 @@ public class GetAzureRMExpressRouteCrossConnectionArpTableCommand : ExpressRoute
         public PSExpressRouteCrossConnection ExpressRouteCrossConnection { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "The PeeringType")]
         [ValidateSet(
            MNM.ExpressRoutePeeringType.AzurePrivatePeering,

src/ResourceManager/Network/Commands.Network/ExpressRouteCrossConnection/CrossConnectionPeeringStats/GetAzureRMExpressRouteCrossConnectionRouteTableCommand.cs

@@ -53,7 +53,7 @@ public class GetAzureRMExpressRouteCrossConnectionRouteTableCommand : ExpressRou
         public PSExpressRouteCrossConnection ExpressRouteCrossConnection { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "The PeeringType")]
         [ValidateSet(
            MNM.ExpressRoutePeeringType.AzurePrivatePeering,

src/ResourceManager/Network/Commands.Network/ExpressRouteCrossConnection/CrossConnectionPeeringStats/GetAzureRMExpressRouteCrossConnectionRouteTableSummaryCommand.cs

@@ -53,7 +53,7 @@ public class GetAzureRMExpressRouteCrossConnectionRouteTableSummaryCommand : Exp
         public PSExpressRouteCrossConnection ExpressRouteCrossConnection { get; set; }
 
         [Parameter(
-            Mandatory = false,
+            Mandatory = true,
             HelpMessage = "The PeeringType")]
         [ValidateSet(
            MNM.ExpressRoutePeeringType.AzurePrivatePeering,

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmExpressRouteCircuitARPTable.md

@@ -89,7 +89,7 @@ Parameter Sets: (All)
 Aliases:
 Accepted values: AzurePrivatePeering, AzurePublicPeering, MicrosoftPeering
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmExpressRouteCircuitRouteTable.md

@@ -90,7 +90,7 @@ Parameter Sets: (All)
 Aliases:
 Accepted values: AzurePrivatePeering, AzurePublicPeering, MicrosoftPeering
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmExpressRouteCircuitRouteTableSummary.md

@@ -90,7 +90,7 @@ Parameter Sets: (All)
 Aliases:
 Accepted values: AzurePrivatePeering, AzurePublicPeering, MicrosoftPeering
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmExpressRouteCrossConnectionARPTable.md

@@ -89,7 +89,7 @@ Parameter Sets: (All)
 Aliases: 
 Accepted values: AzurePrivatePeering, AzurePublicPeering, MicrosoftPeering
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmExpressRouteCrossConnectionRouteTable.md

@@ -90,7 +90,7 @@ Parameter Sets: (All)
 Aliases: 
 Accepted values: AzurePrivatePeering, AzurePublicPeering, MicrosoftPeering
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmExpressRouteCrossConnectionRouteTableSummary.md

@@ -90,7 +90,7 @@ Parameter Sets: (All)
 Aliases: 
 Accepted values: AzurePrivatePeering, AzurePublicPeering, MicrosoftPeering
 
-Required: False
+Required: True
 Position: Named
 Default value: None
 Accept pipeline input: False

tools/StaticAnalysis/Exceptions/AzureRM.Network/BreakingChangeIssues.csv

@@ -58,3 +58,15 @@
 "Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewaySkuCommand","New-AzureRmApplicationGatewaySku","0","3000","The type of property 'Capacity' of type 'Microsoft.Azure.Commands.Network.Models.PSApplicationGatewaySku' has changed from 'System.Int32' to 'System.Nullable`1[System.Int32]'.","Change the type of property 'Capacity' back to 'System.Int32'."
 "Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewaySkuCommand","New-AzureRmApplicationGatewaySku","0","2020","The cmdlet 'New-AzureRmApplicationGatewaySku' no longer supports the type 'System.Int32' for parameter 'Capacity'.","Change the type for parameter 'Capacity' back to 'System.Int32'."
 "Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.SetAzureApplicationGatewaySkuCommand","Set-AzureRmApplicationGatewaySku","0","2020","The cmdlet 'Set-AzureRmApplicationGatewaySku' no longer supports the type 'System.Int32' for parameter 'Capacity'.","Change the type for parameter 'Capacity' back to 'System.Int32'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureExpressRouteCircuitARPTableCommand","Get-AzureRmExpressRouteCircuitARPTable","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCircuitARPTable' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzureRmExpressRouteCircuitARPTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRmExpressRouteCircuitRouteTable","Get-AzureRmExpressRouteCircuitRouteTable","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCircuitRouteTable' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzureRmExpressRouteCircuitRouteTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRmExpressRouteCircuitRouteTableSummaryCommand","Get-AzureRmExpressRouteCircuitRouteTableSummary","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCircuitRouteTableSummary' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzureRmExpressRouteCircuitRouteTableSummary'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionArpTableCommand","Get-AzureRmExpressRouteCrossConnectionArpTable","0","1050","The parameter set 'SpecifyByParameterValues' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionArpTable' has been removed.","Add parameter set 'SpecifyByParameterValues' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionArpTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionArpTableCommand","Get-AzureRmExpressRouteCrossConnectionArpTable","0","1050","The parameter set 'SpecifyByReference' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionArpTable' has been removed.","Add parameter set 'SpecifyByReference' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionArpTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionArpTableCommand","Get-AzureRmExpressRouteCrossConnectionArpTable","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionArpTable' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionArpTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionRouteTableCommand","Get-AzureRmExpressRouteCrossConnectionRouteTable","0","1050","The parameter set 'SpecifyByParameterValues' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTable' has been removed.","Add parameter set 'SpecifyByParameterValues' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionRouteTableCommand","Get-AzureRmExpressRouteCrossConnectionRouteTable","0","1050","The parameter set 'SpecifyByReference' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTable' has been removed.","Add parameter set 'SpecifyByReference' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionRouteTableCommand","Get-AzureRmExpressRouteCrossConnectionRouteTable","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTable' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTable'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionRouteTableSummaryCommand","Get-AzureRmExpressRouteCrossConnectionRouteTableSummary","0","1050","The parameter set 'SpecifyByParameterValues' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTableSummary' has been removed.","Add parameter set 'SpecifyByParameterValues' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTableSummary'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionRouteTableSummaryCommand","Get-AzureRmExpressRouteCrossConnectionRouteTableSummary","0","1050","The parameter set 'SpecifyByReference' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTableSummary' has been removed.","Add parameter set 'SpecifyByReference' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTableSummary'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRMExpressRouteCrossConnectionRouteTableSummaryCommand","Get-AzureRmExpressRouteCrossConnectionRouteTableSummary","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTableSummary' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzureRmExpressRouteCrossConnectionRouteTableSummary'."