Merge pull request #10258 from mudit794/master

Add operational excellence category to validate set of input

Author: msJinLei

src/Advisor/Advisor/ChangeLog.md

@@ -19,6 +19,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Added new category "Operational Excellence" to Get-AzAdvisorRecommendation cmdlet.
 
 ## Version 1.0.1
 * Fixed miscellaneous typos across module

src/Advisor/Advisor/Cmdlets/GetAzAdvisorRecommendation.cs

@@ -52,7 +52,7 @@ public class GetAzAdvisorRecommendation : ResourceAdvisorBaseCmdlet
         /// </summary>
         [Parameter(ParameterSetName = "IdParameterSet", Mandatory = false, HelpMessage = "Category of the recommendation")]
         [Parameter(ParameterSetName = "NameParameterSet", Mandatory = false, HelpMessage = "Category of the recommendation")]
-        [ValidateSet("Cost", "HighAvailability", "Performance", "Security")]
+        [ValidateSet("Cost", "HighAvailability", "OperationalExcellence", "Performance", "Security")]
         public string Category { get; set; }
 
         /// <summary>
@@ -96,4 +96,4 @@ public override void ExecuteCmdlet()
             this.WriteObject(results, true);
         }
     }
-}
+}

src/Advisor/Advisor/Cmdlets/Utilities/RecommendationHelper.cs

@@ -51,8 +51,8 @@ public static List<PsAzureAdvisorResourceRecommendationBase> RecommendationFilte
 
             List<PsAzureAdvisorResourceRecommendationBase> filteredList = new List<PsAzureAdvisorResourceRecommendationBase>();
 
-            // Filter by category only if its a valid input
-            if (Category.Cost.Equals(category) || Category.HighAvailability.Equals(category) || Category.Performance.Equals(category) || Category.Security.Equals(category))
+            // Filter by category
+            if (!string.IsNullOrEmpty(category))
             {
                 // If resourceGroup filtering is as well specified 
                 if (!string.IsNullOrEmpty(resourceGroup))

src/Advisor/Advisor/help/Get-AzAdvisorRecommendation.md

@@ -80,7 +80,7 @@ Category of the recommendation
 Type: String
 Parameter Sets: (All)
 Aliases:
-Accepted values: Cost, HighAvailability, Performance, Security
+Accepted values: Cost, HighAvailability, Performance, Security, OperationalExcellence
 
 Required: False
 Position: Named