[Resource]Add parameters breaking change warnings for IdentifierUri and DisplayName. (#14660)

* [Resource]Add parameter breaking change for IdentifierUri and DisplayName.

* [Resource] updated ChangeLog.md

* [Resource]Added upcoming breaking change warnings in ChangeLog.md.

Co-authored-by: Beisi Zhou <[email protected]>

Author: LucasYao93

src/Resources/Resources/ActiveDirectory/Cmdlets/NewAzureADApplicationCommand.cs

@@ -13,6 +13,7 @@
 // ----------------------------------------------------------------------------------
 
 using Microsoft.WindowsAzure.Commands.Common;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using System;
 using System.Management.Automation;
@@ -39,6 +40,7 @@ public class NewAzureADApplicationCommand : ActiveDirectoryBaseCmdlet
         [ValidateNotNullOrEmpty]
         public string DisplayName { get; set; }
 
+        [CmdletParameterBreakingChange("IdentifierUris", ChangeDescription = "The value will be considered valid only if it exists as a verified domain in a tenant.")]
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ApplicationWithoutCredential,
             HelpMessage = "The URIs that identify the application.")]
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ApplicationWithPasswordPlain,

src/Resources/Resources/ActiveDirectory/Cmdlets/NewAzureADServicePrincipalCommand.cs

@@ -48,6 +48,7 @@ public class NewAzureADServicePrincipalCommand : ActiveDirectoryBaseCmdlet
         [Parameter(Mandatory = false, ParameterSetName = SimpleParameterSet, HelpMessage = "The application id for which service principal is created.")]
         public Guid ApplicationId { get; set; }
 
+        [CmdletParameterBreakingChange("DisplayName", ChangeDescription = "DisplayName is used as the IdentifierUri of created application. The value will be considered valid only if it exists as a verified domain in a tenant.")]
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.DisplayNameWithoutCredential,
             HelpMessage = "The display name for the application.")]
         [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.DisplayNameWithPasswordPlain,

src/Resources/Resources/ActiveDirectory/Cmdlets/UpdateAzureADApplicationCommand.cs

@@ -13,6 +13,7 @@
 // ----------------------------------------------------------------------------------
 
 using Microsoft.Azure.Graph.RBAC.Models;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using System;
 using System.Management.Automation;
@@ -56,6 +57,7 @@ public class UpdateAzureADApplicationCommand : ActiveDirectoryBaseCmdlet
         [ValidateNotNullOrEmpty]
         public string HomePage { get; set; }
 
+        [CmdletParameterBreakingChange("IdentifierUri", ChangeDescription = "The value will be considered valid only if it exists as a verified domain in a tenant.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ApplicationObjectIdWithUpdateParams,
             HelpMessage = "The URIs that identify the application.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ApplicationIdWithUpdateParams,

src/Resources/Resources/ActiveDirectory/Cmdlets/UpdateAzureADServicePrincipalCommand.cs

@@ -18,6 +18,7 @@
 using System.Linq;
 using System.Collections.Generic;
 using System.Management.Automation;
+using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
 
 namespace Microsoft.Azure.Commands.ActiveDirectory
 {
@@ -47,6 +48,7 @@ public class UpdateAzureADServicePrincipalCommand : ActiveDirectoryBaseCmdlet
         [ValidateNotNullOrEmpty]
         public PSADServicePrincipal InputObject { get; set; }
 
+        [CmdletParameterBreakingChange("DisplayName", ChangeDescription = "DisplayName is used as the IdentifierUris of created application. The value will be considered valid only if it exists as a verified domain in a tenant.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.SpObjectIdWithDisplayName, HelpMessage = "The display name for the service principal.")]
         [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.SPNWithDisplayName, HelpMessage = "The display name for the service principal.")]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet.InputObjectWithDisplayName, HelpMessage = "The display name for the service principal.")]
@@ -56,6 +58,7 @@ public class UpdateAzureADServicePrincipalCommand : ActiveDirectoryBaseCmdlet
         [Parameter(Mandatory = false, HelpMessage = "The homepage for the service principal.")]
         public string Homepage { get; set; }
 
+        [CmdletParameterBreakingChange("IdentifierUri", ChangeDescription = "The value will be considered valid only if it exists as a verified domain in a tenant.")]
         [Parameter(Mandatory = false, HelpMessage = "The identifier URI(s) for the service principal.")]
         public string[] IdentifierUri { get; set; }
 

src/Resources/Resources/ChangeLog.md

@@ -19,6 +19,11 @@
 -->
 
 ## Upcoming Release
+* Added upcoming breaking change warnings on below cmdlets, because the value of IdentifierUri parameter will need verified domain.
+  - `New-AzADApplication` 
+  - `Update-AzADApplication`
+  - `New-AzADServicePrincipal`
+  - `Update-AzADServicePrincipal`
 * Ignored bicep warning message in error stream if exitcode equals zero.
 
 ## Version 3.4.0