Merge pull request #10649 from erich-wang/fix-null-context

Fix null ref in generated cmdlets when context is not set

Author: VeryEarly

src/Accounts/Accounts/ChangeLog.md

@@ -20,6 +20,7 @@
 ## Upcoming Release
 * Update references in .psd1 to use relative path
 * Set correct UserAgent for client-side telemetry for Az 4.0 preview
+* Display user friendly error message when context is null in Az 4.0
 
 ## Version 1.6.4
 * Add a deprecation message for `Resolve-Error` alias.

src/Accounts/Accounts/CommonModule/ContextAdapter.cs

@@ -25,6 +25,7 @@
 using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
 using System.Linq;
 using System.Management.Automation;
+using Microsoft.Azure.Commands.Profile.Properties;
 
 namespace Microsoft.Azure.Commands.Common
 {
@@ -170,6 +171,11 @@ internal Func<HttpRequestMessage, CancellationToken, Action, SignalDelegate, Nex
         /// <returns></returns>
         internal async Task AuthorizeRequest(IAzureContext context, string resourceId, HttpRequestMessage request, CancellationToken outerToken)
         {
+            if (context == null || context.Account == null || context.Environment == null)
+            {
+                throw new InvalidOperationException(Resources.InvalidAzureContext);
+            }
+
             await Task.Run(() =>
             {
                 resourceId = context?.Environment?.GetAudienceFromRequestUri(request.RequestUri) ?? resourceId;

src/Accounts/Accounts/Properties/Resources.Designer.cs

@@ -465,4 +465,7 @@
   <data name="SovereignProfileDescription" xml:space="preserve">
     <value>A snapshot of the service API versiosn available in Azure Sovereign Clouds and the Azure Global Cloud.</value>
   </data>
+  <data name="InvalidAzureContext" xml:space="preserve">
+    <value>The context is invalid. Please login using Connect-AzAccount.</value>
+  </data>
 </root>