Skip to content

Commit 2c1f786

Browse files
bganapabganapa
committed
Addressing review comments
1 parent 48db966 commit 2c1f786

File tree

4 files changed

+2
-293
lines changed

4 files changed

+2
-293
lines changed

‎src/StackAdmin/Dns/Commands.Dns.Test/Commands.Dns.Test.csproj

Lines changed: 1 addition & 144 deletions
Original file line numberDiff line numberDiff line change
@@ -44,131 +44,11 @@
4444
<RunCodeAnalysis>false</RunCodeAnalysis>
4545
</PropertyGroup>
4646
<ItemGroup>
47-
<!-- <Reference Include="Hyak.Common">
48-
<HintPath>..\..\..\..\packages\Hyak.Common.1.0.3\lib\net45\Hyak.Common.dll</HintPath>
49-
</Reference>
50-
<Reference Include="Microsoft.Azure.Common, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
51-
<SpecificVersion>False</SpecificVersion>
52-
<HintPath>..\..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.dll</HintPath>
53-
</Reference>
54-
<Reference Include="Microsoft.Azure.Gallery, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
55-
<SpecificVersion>False</SpecificVersion>
56-
<HintPath>..\..\..\..\packages\Microsoft.Azure.Gallery.2.6.2-preview\lib\net40\Microsoft.Azure.Gallery.dll</HintPath>
57-
</Reference>
58-
<Reference Include="Microsoft.Azure.Management.Authorization, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
59-
<SpecificVersion>False</SpecificVersion>
60-
<HintPath>..\..\..\..\packages\Microsoft.Azure.Management.Authorization.2.0.0\lib\net40\Microsoft.Azure.Management.Authorization.dll</HintPath>
61-
<Private>True</Private>
62-
</Reference> -->
6347
<Reference Include="Microsoft.Azure.Management.Dns, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
6448
<SpecificVersion>False</SpecificVersion>
65-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Dns.1.7.2-preview\lib\net45\Microsoft.Azure.Management.Dns.dll</HintPath>
66-
<Private>True</Private>
67-
</Reference>
68-
<!-- <Reference Include="Microsoft.Azure.Management.ResourceManager, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
69-
<SpecificVersion>False</SpecificVersion>
70-
<HintPath>..\..\..\..\packages\Microsoft.Azure.Management.ResourceManager.1.1.1-preview\lib\net45\Microsoft.Azure.Management.ResourceManager.dll</HintPath>
71-
<Private>True</Private>
72-
</Reference>
73-
<Reference Include="Microsoft.Azure.Test.Framework">
74-
<SpecificVersion>False</SpecificVersion>
75-
<HintPath>..\..\..\..\packages\Microsoft.Azure.Test.Framework.1.0.6179.26854-prerelease\lib\net45\Microsoft.Azure.Test.Framework.dll</HintPath>
76-
</Reference>
77-
<Reference Include="Microsoft.Azure.Test.HttpRecorder, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
78-
<SpecificVersion>False</SpecificVersion>
79-
<HintPath>..\..\..\..\packages\Microsoft.Azure.Test.HttpRecorder.1.6.7-preview\lib\net45\Microsoft.Azure.Test.HttpRecorder.dll</HintPath>
80-
<Private>True</Private>
81-
</Reference>
82-
<Reference Include="Microsoft.IdentityModel.Clients.ActiveDirectory, Version=2.28.3.860, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
83-
<SpecificVersion>False</SpecificVersion>
84-
<HintPath>..\..\..\..\packages\Microsoft.IdentityModel.Clients.ActiveDirectory.2.28.3\lib\net45\Microsoft.IdentityModel.Clients.ActiveDirectory.dll</HintPath>
85-
<Private>True</Private>
86-
</Reference>
87-
<Reference Include="Microsoft.IdentityModel.Clients.ActiveDirectory.WindowsForms, Version=2.28.3.860, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
88-
<HintPath>..\..\..\..\packages\Microsoft.IdentityModel.Clients.ActiveDirectory.2.28.3\lib\net45\Microsoft.IdentityModel.Clients.ActiveDirectory.WindowsForms.dll</HintPath>
89-
<Private>True</Private>
90-
</Reference>
91-
<Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
92-
<HintPath>..\..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.5\lib\net45\Microsoft.Rest.ClientRuntime.dll</HintPath>
93-
<Private>True</Private>
94-
</Reference>
95-
<Reference Include="Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
96-
<SpecificVersion>False</SpecificVersion>
97-
<HintPath>..\..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.5\lib\net45\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath>
98-
<Private>True</Private>
99-
</Reference>
100-
<Reference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
101-
<SpecificVersion>False</SpecificVersion>
102-
<HintPath>..\..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.Authentication.2.2.9-preview\lib\net45\Microsoft.Rest.ClientRuntime.Azure.Authentication.dll</HintPath>
103-
<Private>True</Private>
104-
</Reference>
105-
<Reference Include="Microsoft.Rest.ClientRuntime.Azure.TestFramework">
106-
<HintPath>..\..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.TestFramework.1.5.0-preview\lib\net45\Microsoft.Rest.ClientRuntime.Azure.TestFramework.dll</HintPath>
107-
<Private>True</Private>
108-
</Reference>
109-
<Reference Include="Microsoft.Azure.ResourceManager, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
110-
<SpecificVersion>False</SpecificVersion>
111-
<HintPath>..\..\..\..\packages\Microsoft.Azure.Management.Resources.2.20.0-preview\lib\net40\Microsoft.Azure.ResourceManager.dll</HintPath>
112-
</Reference>
113-
<Reference Include="Microsoft.Threading.Tasks, Version=1.0.12.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
114-
<SpecificVersion>False</SpecificVersion>
115-
<HintPath>..\..\..\..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.dll</HintPath>
116-
</Reference>
117-
<Reference Include="Microsoft.Threading.Tasks.Extensions, Version=1.0.12.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
118-
<SpecificVersion>False</SpecificVersion>
119-
<HintPath>..\..\..\..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.dll</HintPath>
120-
</Reference>
121-
<Reference Include="Microsoft.Threading.Tasks.Extensions.Desktop, Version=1.0.168.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
122-
<SpecificVersion>False</SpecificVersion>
123-
<HintPath>..\..\..\..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.Desktop.dll</HintPath>
124-
</Reference>
125-
<Reference Include="Moq, Version=4.2.1510.2205, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
126-
<SpecificVersion>False</SpecificVersion>
127-
<HintPath>..\..\..\..\packages\Moq.4.2.1510.2205\lib\net40\Moq.dll</HintPath>
128-
</Reference>
129-
<Reference Include="Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
130-
<SpecificVersion>False</SpecificVersion>
131-
<HintPath>..\..\..\..\packages\Newtonsoft.Json.6.0.8\lib\net45\Newtonsoft.Json.dll</HintPath>
132-
</Reference>
133-
<Reference Include="System" />
134-
<Reference Include="System.Core" />
135-
<Reference Include="System.Management.Automation, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
136-
<SpecificVersion>False</SpecificVersion>
137-
<HintPath>C:\Windows\Microsoft.NET\assembly\GAC_MSIL\System.Management.Automation\v4.0_3.0.0.0__31bf3856ad364e35\System.Management.Automation.dll</HintPath>
138-
</Reference>
139-
<Reference Include="System.Net" />
140-
<Reference Include="System.Net.Http" />
141-
<Reference Include="System.Net.Http.Extensions, Version=2.2.28.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
142-
<SpecificVersion>False</SpecificVersion>
143-
<HintPath>..\..\..\..\packages\Microsoft.Net.Http.2.2.28\lib\net45\System.Net.Http.Extensions.dll</HintPath>
144-
</Reference>
145-
<Reference Include="System.Net.Http.Primitives, Version=4.2.28.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
146-
<SpecificVersion>False</SpecificVersion>
147-
<HintPath>..\..\..\..\packages\Microsoft.Net.Http.2.2.28\lib\net45\System.Net.Http.Primitives.dll</HintPath>
148-
</Reference>
149-
<Reference Include="System.Net.Http.WebRequest" />
150-
<Reference Include="System.Runtime.Serialization" />
151-
<Reference Include="System.Xml.Linq" />
152-
<Reference Include="System.Data.DataSetExtensions" />
153-
<Reference Include="Microsoft.CSharp" />
154-
<Reference Include="System.Data" />
155-
<Reference Include="System.Xml" />
156-
<Reference Include="xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
157-
<HintPath>..\..\..\..\packages\xunit.abstractions.2.0.0\lib\net35\xunit.abstractions.dll</HintPath>
158-
<Private>True</Private>
159-
</Reference>
160-
<Reference Include="xunit.assert, Version=2.1.0.3179, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
161-
<HintPath>..\..\..\..\packages\xunit.assert.2.1.0\lib\portable-net45+win8+wp8+wpa81\xunit.assert.dll</HintPath>
49+
<HintPath>$(LibraryNugetPackageFolder)\Microsoft.Azure.Management.Dns.1.7.2-preview\lib\net45\Microsoft.Azure.Management.Dns.dll</HintPath>
16250
<Private>True</Private>
16351
</Reference>
164-
<Reference Include="xunit.core, Version=2.1.0.3179, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
165-
<HintPath>..\..\..\..\packages\xunit.extensibility.core.2.1.0\lib\portable-net45+win8+wp8+wpa81\xunit.core.dll</HintPath>
166-
<Private>True</Private>
167-
</Reference>
168-
<Reference Include="xunit.execution.desktop, Version=2.1.0.3179, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
169-
<HintPath>..\..\..\..\packages\xunit.extensibility.execution.2.1.0\lib\net45\xunit.execution.desktop.dll</HintPath>
170-
<Private>True</Private>
171-
</Reference> -->
17252
</ItemGroup>
17353
<ItemGroup>
17454
<Compile Include="Properties\AssemblyInfo.cs" />
@@ -182,26 +62,6 @@
18262
<Compile Include="ScenarioTests\DnsTestsBase.cs" />
18363
</ItemGroup>
18464
<ItemGroup>
185-
<ProjectReference Include="..\..\..\..\Common\Commands.Common.Authentication.Abstractions\Commands.Common.Authentication.Abstractions.csproj">
186-
<Project>{70527617-7598-4aef-b5bd-db9186b8184b}</Project>
187-
<Name>Commands.Common.Authentication.Abstractions</Name>
188-
</ProjectReference>
189-
<ProjectReference Include="..\..\..\..\Common\Commands.Common.Authentication\Commands.Common.Authentication.csproj">
190-
<Project>{d3804b64-c0d3-48f8-82ec-1f632f833c9e}</Project>
191-
<Name>Commands.Common.Authentication</Name>
192-
</ProjectReference>
193-
<ProjectReference Include="..\..\..\..\Common\Commands.Common\Commands.Common.csproj">
194-
<Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
195-
<Name>Commands.Common</Name>
196-
</ProjectReference>
197-
<ProjectReference Include="..\..\..\Common\Commands.ResourceManager.Common\Commands.ResourceManager.Common.csproj">
198-
<Project>{3819d8a7-c62c-4c47-8ddd-0332d9ce1252}</Project>
199-
<Name>Commands.ResourceManager.Common</Name>
200-
</ProjectReference>
201-
<ProjectReference Include="..\..\..\Common\Commands.ScenarioTests.ResourceManager.Common\Commands.ScenarioTests.ResourceManager.Common.csproj">
202-
<Project>{3436a126-edc9-4060-8952-9a1be34cdd95}</Project>
203-
<Name>Commands.ScenarioTests.ResourceManager.Common</Name>
204-
</ProjectReference>
20565
<ProjectReference Include="..\..\..\Resources\Commands.Resources\Commands.Resources.csproj">
20666
<Project>{e1f5201d-6067-430e-b303-4e367652991b}</Project>
20767
<Name>Commands.Resources</Name>
@@ -215,9 +75,6 @@
21575
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
21676
</ItemGroup>
21777
<ItemGroup>
218-
<!-- <None Include="..\..\..\Common\Commands.ScenarioTests.ResourceManager.Common\AzureRM.Resources.ps1">
219-
<Link>ScenarioTests\AzureRM.Resources.ps1</Link>
220-
</None> -->
22178
<None Include="MSSharedLibKey.snk" />
22279
<None Include="packages.config">
22380
<SubType>Designer</SubType>

‎src/StackAdmin/Dns/Commands.Dns.Test/packages.config

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,3 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="Hyak.Common" version="1.0.3" targetFramework="net45" />
4-
<package id="Microsoft.Azure.Common" version="2.1.0" targetFramework="net45" />
5-
<package id="Microsoft.Azure.Gallery" version="2.6.2-preview" targetFramework="net45" />
6-
<package id="Microsoft.Azure.Common.Dependencies" version="1.0.0" targetFramework="net45" />
7-
<package id="Microsoft.Azure.Management.Authorization" version="2.0.0" targetFramework="net45" />
8-
<package id="Microsoft.Azure.Management.Dns" version="1.7.2-preview" targetFramework="net45" />
9-
<package id="Microsoft.Azure.Management.ResourceManager" version="1.1.1-preview" targetFramework="net45" />
10-
<package id="Microsoft.Azure.Management.Resources" version="2.20.0-preview" targetFramework="net45" />
11-
<package id="Microsoft.Azure.Test.HttpRecorder" version="1.6.7-preview" targetFramework="net45" />
12-
<package id="Microsoft.Azure.Test.Framework" version="1.0.6179.26854-prerelease" targetFramework="net45" />
13-
<package id="Microsoft.Bcl" version="1.1.9" targetFramework="net45" />
14-
<package id="Microsoft.Bcl.Async" version="1.0.168" targetFramework="net45" />
15-
<package id="Microsoft.Bcl.Build" version="1.0.14" targetFramework="net45" />
16-
<package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net45" />
17-
<package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net45" />
18-
<package id="Microsoft.Rest.ClientRuntime" version="2.3.5" targetFramework="net45" />
19-
<package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.5" targetFramework="net45" />
20-
<package id="Microsoft.Rest.ClientRuntime.Azure.TestFramework" version="1.5.0-preview" targetFramework="net45" />
21-
<package id="Microsoft.Rest.ClientRuntime.Azure.Authentication" version="2.2.9-preview" targetFramework="net45" />
22-
<package id="Moq" version="4.2.1510.2205" targetFramework="net45" />
23-
<package id="Newtonsoft.Json" version="6.0.8" targetFramework="net45" />
24-
<package id="xunit" version="2.1.0" targetFramework="net45" />
25-
<package id="xunit.abstractions" version="2.0.0" targetFramework="net45" />
26-
<package id="xunit.assert" version="2.1.0" targetFramework="net45" />
27-
<package id="xunit.core" version="2.1.0" targetFramework="net45" />
28-
<package id="xunit.extensibility.core" version="2.1.0" targetFramework="net45" />
29-
<package id="xunit.extensibility.execution" version="2.1.0" targetFramework="net45" />
30-
<package id="xunit.runner.visualstudio" version="2.1.0" targetFramework="net45" />
313
</packages>

‎src/StackAdmin/Dns/Commands.Dns/Commands.Dns.csproj

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -91,24 +91,10 @@
9191
<ItemGroup>
9292
<Reference Include="Microsoft.Azure.Management.Dns, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
9393
<SpecificVersion>False</SpecificVersion>
94-
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Dns.1.7.2-preview\lib\net45\Microsoft.Azure.Management.Dns.dll</HintPath>
94+
<HintPath>$(LibraryNugetPackageFolder)\Microsoft.Azure.Management.Dns.1.7.2-preview\lib\net45\Microsoft.Azure.Management.Dns.dll</HintPath>
9595
</Reference>
9696
<Reference Include="System.Configuration.Install" />
9797
</ItemGroup>
98-
<!-- <ItemGroup>
99-
<ProjectReference Include="..\..\..\..\Common\Commands.Common.Authentication.Abstractions\Commands.Common.Authentication.Abstractions.csproj">
100-
<Project>{70527617-7598-4aef-b5bd-db9186b8184b}</Project>
101-
<Name>Commands.Common.Authentication.Abstractions</Name>
102-
</ProjectReference>
103-
<ProjectReference Include="..\..\..\..\Common\Commands.Common\Commands.Common.csproj">
104-
<Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
105-
<Name>Commands.Common</Name>
106-
</ProjectReference>
107-
<ProjectReference Include="..\..\..\Common\Commands.ResourceManager.Common\Commands.ResourceManager.Common.csproj">
108-
<Project>{3819d8a7-c62c-4c47-8ddd-0332d9ce1252}</Project>
109-
<Name>Commands.ResourceManager.Common</Name>
110-
</ProjectReference>
111-
</ItemGroup>-->
11298
<ItemGroup>
11399
<WCFMetadata Include="Service References\" />
114100
</ItemGroup>

0 commit comments

Comments
 (0)