Merge branch 'master' into 7679

Author: cormacpayne

.github/ISSUE_TEMPLATE.md

@@ -7,7 +7,7 @@ If this issue is a bug report:
     - You can also install the latest version from the Releases section
         - https://github.com/Azure/azure-powershell/releases
 - Ensure that you repro the issue with $DebugPreference = "Continue" to receive the debug stream
-- If this bug involves an exception being thrown, please run Resolve-AzureRmError to receive extended information on the error
+- If this bug involves an exception being thrown, please run Resolve-AzError to receive extended information on the error
 - Fill out the below template
 
 If this issue is not a bug report, please remove the below template

.travis.yml

@@ -25,7 +25,6 @@ before_install:
  # https://github.com/travis-ci/travis-ci/issues/1066#issuecomment-383489298
 script:
  - sudo dotnet msbuild build.proj /t:BuildNetcore /p:Configuration=$CONFIG || travis_terminate 1
- - sudo dotnet src/Package/StaticAnalysis/StaticAnalysis.Netcore.dll -p $TRAVIS_BUILD_DIR/src/Package/$CONFIG -r $TRAVIS_BUILD_DIR/src/Package/StaticAnalysis -u || travis_terminate 1
  - sudo pwsh -NonInteractive -NoLogo -NoProfile -File tools/TestModuleLoading.ps1 || travis_terminate 1
  - sudo dotnet pack src/TestPrerequisites/Common.TestPrerequisites.sln --configuration $CONFIG || travis_terminate 1
  - sudo dotnet test src/Azure.PowerShell.Netcore.Test.sln --filter "AcceptanceType=CheckIn&RunType!=DesktopOnly" --configuration $CONFIG --framework netcoreapp2.0

Azure.PowerShell.Netcore.sln

@@ -1,6 +1,6 @@
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.27130.2027
+VisualStudioVersion = 15.0.27130.2020
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.Profile.Netcore", "src\ResourceManager\Profile\Commands.Profile\Commands.Profile.Netcore.csproj", "{31044C50-5F29-4CB4-9E7C-8E0123FA6B77}"
 EndProject
@@ -148,8 +148,14 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.SignalR.Netcore",
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.DevSpaces.Netcore", "src\ResourceManager\DevSpaces\Commands.DevSpaces\Commands.DevSpaces.Netcore.csproj", "{6EBD1E1B-12D1-451D-B284-ED35A91D6C8C}"
 EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.FrontDoor.Netcore", "src\ResourceManager\FrontDoor\Commands.FrontDoor\Commands.FrontDoor.Netcore.csproj", "{9207944C-6E48-4845-BC58-85C7EFAA0E28}"
+EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.IotCentral.Netcore", "src\ResourceManager\IotCentral\Commands.IotCentral\Commands.IotCentral.Netcore.csproj", "{18B8B354-6920-4329-AB6B-DC98790B7A5A}"
 EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.Security.Netcore", "src\ResourceManager\Security\Commands.Security\Commands.Security.Netcore.csproj", "{FA322448-E646-4221-9FEA-3C1C8CC81B99}"
+EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Commands.StorageSync.Netcore", "src\ResourceManager\StorageSync\Commands.StorageSync\Commands.StorageSync.Netcore.csproj", "{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -1035,6 +1041,18 @@ Global
 		{6EBD1E1B-12D1-451D-B284-ED35A91D6C8C}.Release|x64.Build.0 = Release|Any CPU
 		{6EBD1E1B-12D1-451D-B284-ED35A91D6C8C}.Release|x86.ActiveCfg = Release|Any CPU
 		{6EBD1E1B-12D1-451D-B284-ED35A91D6C8C}.Release|x86.Build.0 = Release|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Debug|x64.Build.0 = Debug|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Debug|x86.Build.0 = Debug|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Release|Any CPU.Build.0 = Release|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Release|x64.ActiveCfg = Release|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Release|x64.Build.0 = Release|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Release|x86.ActiveCfg = Release|Any CPU
+		{9207944C-6E48-4845-BC58-85C7EFAA0E28}.Release|x86.Build.0 = Release|Any CPU
 		{18B8B354-6920-4329-AB6B-DC98790B7A5A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{18B8B354-6920-4329-AB6B-DC98790B7A5A}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{18B8B354-6920-4329-AB6B-DC98790B7A5A}.Debug|x64.ActiveCfg = Debug|Any CPU
@@ -1047,6 +1065,30 @@ Global
 		{18B8B354-6920-4329-AB6B-DC98790B7A5A}.Release|x64.Build.0 = Release|Any CPU
 		{18B8B354-6920-4329-AB6B-DC98790B7A5A}.Release|x86.ActiveCfg = Release|Any CPU
 		{18B8B354-6920-4329-AB6B-DC98790B7A5A}.Release|x86.Build.0 = Release|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Debug|x64.Build.0 = Debug|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Debug|x86.Build.0 = Debug|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Release|Any CPU.Build.0 = Release|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Release|x64.ActiveCfg = Release|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Release|x64.Build.0 = Release|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Release|x86.ActiveCfg = Release|Any CPU
+		{FA322448-E646-4221-9FEA-3C1C8CC81B99}.Release|x86.Build.0 = Release|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Debug|x64.Build.0 = Debug|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Debug|x86.Build.0 = Debug|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Release|Any CPU.Build.0 = Release|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Release|x64.ActiveCfg = Release|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Release|x64.Build.0 = Release|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Release|x86.ActiveCfg = Release|Any CPU
+		{4C2F89E4-A0E0-4ECB-A5DA-A583EDF1ED62}.Release|x86.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

ChangeLog.md

@@ -1,4 +1,72 @@
-## 6.12.0 - November 2018
+## 6.13.0 - November 2018
+#### AzureRM.Profile
+* Update common code to use latest version of ClientRuntime
+
+#### AzureRM.ApiManagement
+* Update dependencies for type mapping issue
+
+#### AzureRM.Automation
+* Swagger based Azure Automation cmdlets
+* Added Update Management cmdlets
+* Added Source Control cmdlets
+* Added Remove-AzureRmAutomationHybridWorkerGroup cmdlet
+* Fixed the DSC Register Node command
+
+#### AzureRM.Compute
+* Fixed identity issue for SystemAssigned identity
+* Update dependencies for type mapping issue
+
+#### AzureRM.ContainerInstance
+* Update dependencies for type mapping issue
+
+#### AzureRM.MarketplaceOrdering
+* update the examples description for marketplace cmdlets
+
+#### AzureRM.Network
+* Added cmdlet New-AzureRmApplicationGatewayCustomError, Add-AzureRmApplicationGatewayCustomError, Get-AzureRmApplicationGatewayCustomError, Set-AzureRmApplicationGatewayCustomError, Remove-AzureRmApplicationGatewayCustomError, Add-AzureRmApplicationGatewayHttpListenerCustomError, Get-AzureRmApplicationGatewayHttpListenerCustomError, Set-AzureRmApplicationGatewayHttpListenerCustomError, Remove-AzureRmApplicationGatewayHttpListenerCustomError
+* Added ICMP back to supported AzureFirewall Network Protocols
+* Update cmdlet Test-AzureRmNetworkWatcherConnectivity, add validation on destination id, address and port. 
+* Fix issues with memory usage in VirtualNetwork map
+
+#### AzureRM.RecoveryServices.Backup
+* Fix for modifying policy for a protected file share.
+* Converted policy timezone to uppercase.
+
+#### AzureRM.RecoveryServices.SiteRecovery
+* Corrected example in New-AzureRmRecoveryServicesAsrProtectableItem
+* Update dependencies for type mapping issue
+
+#### AzureRM.Relay
+* Added optional Parameter -KeyValue to New-AzureRmRelayKey cmdlet, which enables user to provide KeyValue.
+
+#### AzureRM.Resources
+* Update help documentation for resource identity related parameters in `New-AzureRmPolicyAssignment` and `Set-AzureRmPolicyAssignment`
+* Add an example for New-AzureRmPolicyDefinition that uses -Metadata
+* Fix to allow case preservation in Tag keys in NetStandard: #7678 #7703
+
+#### AzureRM.ServiceFabric
+* Add deprecation messages for upcoming breaking changes
+
+#### AzureRM.Sql
+* Added new cmdlets for CRUD operations on Azure Sql Database Managed Instance and Azure Sql Managed Database
+	- Get-AzureRmSqlInstance
+	- New-AzureRmSqlInstance
+	- Set-AzureRmSqlInstance
+	- Remove-AzureRmSqlInstance
+	- Get-AzureRmSqlInstanceDatabase
+	- New-AzureRmSqlInstanceDatabase
+	- Restore-AzureRmSqlInstanceDatabase
+	- Remove-AzureRmSqlInstanceDatabase
+* Enabled Extended Auditing Policy management on a server or a database.
+	- New parameter (PredicateExpression) was added to enable filtering of audit logs.
+	- Cmdlets were modified to use SQL clients instead of Legacy clients.
+	- Set-AzureRmSqlServerAuditing.
+	- Get-AzureRmSqlServerAuditing.
+	- Set-AzureRmSqlDatabaseAuditing.
+	- Get-AzureRmSqlDatabaseAuditing.
+* Fixed issue with using Update-AzureRmSqlDatabaseVulnerabilityAssessmentSettings with storage account name parameter set
+
+## 6.12.0 - November 2018
 #### AzureRM.Profile
 * Update common code to use latest version of ClientRuntime
 * Rename param TenantId in cmdlet Connect-AzureRmAccount to Tenant and add an alias for TenantId

README.md

@@ -67,53 +67,53 @@ For more detailed instructions on using Azure PowerShell, please refer to the [g
 
 ### Log in to Azure
 
-To connect to Azure, use the [`Connect-AzureRmAccount`](https://docs.microsoft.com/en-us/powershell/module/azurerm.profile/connect-azurermaccount) cmdlet.
+To connect to Azure, use the [`Connect-AzAccount`](https://docs.microsoft.com/en-us/powershell/module/azurerm.profile/connect-Azaccount) cmdlet.
 
 ```powershell
 # Interactive login - you will get a dialog box asking for your Azure credentials
-Connect-AzureRmAccount
+Connect-AzAccount
 
 # Non-interactive login - you will need to use a service principal
-Connect-AzureRmAccount -ServicePrincipal -ApplicationId "http://my-app" -Credential $PSCredential -TenantId $TenantId
+Connect-AzAccount -ServicePrincipal -ApplicationId "http://my-app" -Credential $PSCredential -TenantId $TenantId
 ```
 
 To log into a specific cloud (_AzureChinaCloud_, _AzureCloud_, _AzureGermanCloud_, _AzureUSGovernment_), use the `Environment` parameter:
 
 ```powershell
 # Log into a specific cloud - in this case, the Azure China cloud
-Connect-AzureRmAccount -Environment AzureChinaCloud
+Connect-AzAccount -Environment AzureChinaCloud
 ```
 
 ### Getting and setting your session context
 
-To view the context you are using in the current session, which contains the subscription and tenant, use the [`Get-AzureRmContext`](https://docs.microsoft.com/en-us/powershell/module/azurerm.profile/get-azurermcontext) cmdlet:
+To view the context you are using in the current session, which contains the subscription and tenant, use the [`Get-AzContext`](https://docs.microsoft.com/en-us/powershell/module/azurerm.profile/get-Azcontext) cmdlet:
 
 ```powershell
 # Get the context you are currently using
-Get-AzureRmContext
+Get-AzContext
 
 # List all available contexts in the current session
-Get-AzureRmContext -ListAvailable
+Get-AzContext -ListAvailable
 ```
 
-To get the subscriptions in a tenant, use the [`Get-AzureRmSubscription`](https://docs.microsoft.com/en-us/powershell/module/azurerm.profile/get-azurermsubscription) cmdlet:
+To get the subscriptions in a tenant, use the [`Get-AzSubscription`](https://docs.microsoft.com/en-us/powershell/module/azurerm.profile/get-azurermsubscription) cmdlet:
 
 ```powershell
 # Get all of the subscriptions in your current tenant
-Get-AzureRmSubscription
+Get-AzSubscription
 
 # Get all of the subscriptions in a specific tenant
-Get-AzureRmSubscription -TenantId $TenantId
+Get-AzSubscription -TenantId $TenantId
 ```
 
-To change the subscription that you are using for your current context, use the [`Set-AzureRmContext`]() cmdlet:
+To change the subscription that you are using for your current context, use the [`Set-AzContext`]() cmdlet:
 
 ```powershell
 # Set the context to a specific subscription
-Set-AzureRmContext -Subscription $SubscriptionName -Name "MyContext"
+Set-AzContext -Subscription $SubscriptionName -Name "MyContext"
 
 # Set the context using piping
-Get-AzureRmSubscription -SubscriptionName $SubscriptionName | Set-AzureRmContext -Name "MyContext"
+Get-AzSubscription -SubscriptionName $SubscriptionName | Set-AzContext -Name "MyContext"
 ```
 
 ### Discovering cmdlets
@@ -136,17 +136,17 @@ Get-Command -Module AzureRM.Compute -Name "*VM*"
 To view the help content for a cmdlet, use the `Get-Help` cmdlet:
 
 ```powershell
-# View the basic help content for Get-AzureRmSubscription
-Get-Help -Name Get-AzureRmSubscription
+# View the basic help content for Get-AzSubscription
+Get-Help -Name Get-AzSubscription
 
-# View the examples for Get-AzureRmSubscription
-Get-Help -Name Get-AzureRmSubscription -Examples
+# View the examples for Get-AzSubscription
+Get-Help -Name Get-AzSubscription -Examples
 
-# View the full help content for Get-AzureRmSubscription
-Get-Help -Name Get-AzureRmSubscription -Full
+# View the full help content for Get-AzSubscription
+Get-Help -Name Get-AzSubscription -Full
 
-# View the help content for Get-AzureRmSubscription on https://docs.microsoft.com
-Get-Help -Name Get-AzureRmSubscription -Online
+# View the help content for Get-AzSubscription on https://docs.microsoft.com
+Get-Help -Name Get-AzSubscription -Online
 ```
 
 ## Reporting Issues and Feedback

build.proj

@@ -88,6 +88,7 @@
     <LocalBuildTasks  Include="$(LibraryToolsFolder)\RepoTasks\RepoTasks.sln" Condition="'$(NetCore)' == 'false'" />
     <StackSolution    Include="$(LibrarySourceFolder)\StackAdmin\Stack.sln" Condition="'$(Scope)' == 'All' or '$(Scope)' == 'Stack'" />
     <StaticAnalysis   Include=".\tools\StaticAnalysis\StaticAnalysis.sln" />
+    <StaticAnalysisNetcore   Include=".\tools\StaticAnalysis\StaticAnalysisNetcore.sln" />
     <LocalBuildTasks  Include="$(LibraryToolsFolder)\BuildPackagesTask\Microsoft.Azure.Build.Tasks.sln" />
     <LocalBuildTasks  Include="$(LibraryToolsFolder)\RepoTasks\RepoTasks.sln" Condition="'$(NetCore)' == 'false'" />
   </ItemGroup>
@@ -268,9 +269,9 @@
               Condition="'$(Scope)' == 'All' or '$(Scope)' == 'Stack'"
               ContinueOnError="false" />
 
-    <Exec Command="$(PowerShellCommandPrefix) &quot;$ProgressPreference = 'SilentlyContinue';. $(LibraryToolsFolder)\GenerateHelp.ps1 -ValidateMarkdownHelp -GenerateMamlHelp -BuildConfig $(Configuration) -FilteredModules '@(ModulesChanged)' &quot;"
+    <!--<Exec Command="$(PowerShellCommandPrefix) &quot;$ProgressPreference = 'SilentlyContinue';. $(LibraryToolsFolder)\GenerateHelp.ps1 -ValidateMarkdownHelp -GenerateMamlHelp -BuildConfig $(Configuration) -FilteredModules '@(ModulesChanged)' &quot;"
           Condition="'$(SkipHelp)' == 'false'"
-          ContinueOnError="false"/>
+          ContinueOnError="false"/>-->
 
     <Exec Command="$(PowerShellCommandPrefix) &quot;. $(LibraryToolsFolder)\UpdateModules.ps1 -BuildConfig $(Configuration) -Scope $(Scope) &quot;"
           Condition="'$(CodeSign)' == 'false'"/>
@@ -281,9 +282,9 @@
       Command="&quot;$(PowerShellCommand)&quot; -NonInteractive -NoLogo -NoProfile -Command &quot; . $(LibraryToolsFolder)\NewOutputTypeIndex.ps1 -OutputFile $(PackageDirectory)\outputtypes.json -BuildConfig $(Configuration) &quot;"
       Condition="('$(Scope)' == 'All' or '$(Scope)' == 'Latest') and $(CodeSign) == 'true'" />
 
-    <Message Importance="high" Text="Running Static Analyser" />
+    <!--<Message Importance="high" Text="Running Static Analyser" />
     <CallTarget targets="DependencyAnalysis" ContinueOnError="ErrorAndContinue" />
-    <Exec Command="$(PowerShellCommandPrefix) &quot;. $(LibraryToolsFolder)\CheckAssemblies.ps1 -BuildConfig $(Configuration) &quot;" />
+    <Exec Command="$(PowerShellCommandPrefix) &quot;. $(LibraryToolsFolder)\CheckAssemblies.ps1 -BuildConfig $(Configuration) &quot;" />-->
     <Exec Command="$(PowerShellCommandPrefix) &quot;. $(LibraryToolsFolder)\CleanupBuild.ps1 -BuildConfig $(Configuration) &quot;" />
 
     <Exec ContinueOnError="false"
@@ -355,9 +356,12 @@
           ContinueOnError="false" />
     <!-- Generate the Help -->
     <Exec Command="$(PowerShellCoreCommandPrefix) &quot;Set-Variable -Name ProgressPreference -Value 'SilentlyContinue';. $(LibraryToolsFolder)\GenerateHelp.ps1 -ValidateMarkdownHelp -GenerateMamlHelp -BuildConfig $(Configuration) &quot;"
-          Condition="'$(SkipHelp)' == 'false'"
+          Condition="'$(SkipHelp)' == 'false' And '$(RunStaticAnalysis)' == 'true'"
           ContinueOnError="false"/>
 
+    <CallTarget targets="DependencyAnalysisNetcore" ContinueOnError="ErrorAndContinue" Condition="'$(RunStaticAnalysis)' == 'true'" />
+    <Exec Command="$(PowerShellCommandPrefix) &quot;. $(LibraryToolsFolder)\CheckAssemblies.ps1 -BuildConfig $(Configuration) &quot;" Condition="'$(RunStaticAnalysis)' == 'true'" />
+
     <!-- Cleanup extraneous files. -->
     <Exec Command="$(PowerShellCoreCommandPrefix) &quot;. $(LibraryToolsFolder)\CleanupBuild.ps1 -BuildConfig $(Configuration) &quot;" />
 
@@ -548,6 +552,25 @@
     <OnError ExecuteTargets="StaticAnalysisErrorMessage"/>
   </Target>
 
+  <!-- Run Validation -->
+  <Target Name="DependencyAnalysisNetcore"
+          Condition="'$(SkipDependencyAnalysis)' == 'false'">
+
+    <MSBuild  Projects="@(StaticAnalysisNetcore)"
+              Targets="Build"
+              Properties="Configuration=Debug;Platform=Any CPU"
+              ContinueOnError="false" />
+
+    <Message Importance="high" Text="Running dependency analysis..." />
+
+    <PropertyGroup>
+        <SkipHelpValue Condition=" '$(SkipHelp)' == 'true' ">-s</SkipHelpValue>
+    </PropertyGroup>
+    <Exec Command="dotnet $(MSBuildProjectDirectory)\src\Package\StaticAnalysis.Netcore.dll -p $(MSBuildProjectDirectory)\src\Package\$(Configuration) -r $(MSBuildProjectDirectory)\src\Package $(SkipHelpValue) -u -m @(ModulesChanged)" />
+
+    <OnError ExecuteTargets="StaticAnalysisErrorMessage"/>
+  </Target>
+
   <Target Name="StaticAnalysisErrorMessage">
     <Error Text="StaticAnalysis has failed.  Please follow the instructions on this doc: https://github.com/Azure/azure-powershell/blob/preview/documentation/Debugging-StaticAnalysis-Errors.md"/>
   </Target>

documentation/breaking-changes/breaking-changes-tool-help.md

@@ -59,8 +59,8 @@ To add an alias to the original cmdlet name, use the `Alias` attribute for the c
 If you need to, you can add multiple aliases for cmdlets that need to be renamed twice.
 
 ```cs
-[Cmdlet(VerbsCommunications.Connect, "AzureRmAccount")]
-[Alias("Login-AzureRmAccount", "Login-AzAccount", "Add-AzureRmAccount")]
+[Cmdlet(VerbsCommunications.Connect, "AzAccount")]
+[Alias("Login-AzAccount", "Add-AzAccount")]
 public class ConnectAzureRmAccount : Cmdlet
 {
     protected override void BeginProcessing()