unit testing fixes for policy

Author: sudhakar4171

src/ResourceManager/RecoveryServices.Backup/Cmdlets/ProtectionPolicy/GetAzureRmRecoveryServicesBackupRetentionPolicyObject.cs

@@ -24,7 +24,7 @@
 namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
 {
     [Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupRetentionPolicyObject"), OutputType(typeof(AzureRmRecoveryServicesRetentionPolicyBase))]
-    class GetAzureRmRecoveryServicesBackupRetentionPolicyObject : RecoveryServicesBackupCmdletBase
+    public class GetAzureRmRecoveryServicesBackupRetentionPolicyObject : RecoveryServicesBackupCmdletBase
     {
         [Parameter(Mandatory = true, HelpMessage = "Temp Help message. Need to update it")]
         [ValidateNotNullOrEmpty]

src/ResourceManager/RecoveryServices.Backup/Cmdlets/ProtectionPolicy/GetAzureRmRecoveryServicesSchedulePolicyObject.cs

@@ -24,7 +24,7 @@
 namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
 {
     [Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesSchedulePolicyObject"), OutputType(typeof(AzureRmRecoveryServicesSchedulePolicyBase))]
-    class GetAzureRmRecoveryServicesSchedulePolicyObject : RecoveryServicesBackupCmdletBase
+    public class GetAzureRmRecoveryServicesSchedulePolicyObject : RecoveryServicesBackupCmdletBase
     {
         [Parameter(Mandatory = true, HelpMessage = "Temp Help message. Need to update it")]
         [ValidateNotNullOrEmpty]

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/Conversions/RetentionPolicyConversions.cs

@@ -419,8 +419,7 @@ private static HydraModels.MonthlyRetentionSchedule GetHydraLTRMonthlySchedule(M
             };
             hydraMonthly.RetentionTimes = psMonthly.RetentionTimes;
 
-            hydraMonthly.RetentionScheduleFormatType = Enum.Parse(typeof(HydraModels.RetentionScheduleFormat),
-                                                                  psMonthly.RetentionScheduleFormatType.ToString()).ToString();
+            hydraMonthly.RetentionScheduleFormatType = psMonthly.RetentionScheduleFormatType.ToString();
             if (psMonthly.RetentionScheduleFormatType == RetentionScheduleFormat.Daily)
             {
                 hydraMonthly.RetentionScheduleDaily = GetHydraLTRDailyRetentionFormat(psMonthly.RetentionScheduleDaily);
@@ -449,8 +448,7 @@ private static HydraModels.YearlyRetentionSchedule GetHydraLTRYearlySchedule(Yea
             };
             hydraYearly.RetentionTimes = psYearly.RetentionTimes;
 
-            hydraYearly.RetentionScheduleFormatType = Enum.Parse(typeof(HydraModels.RetentionScheduleFormat),
-                                                                  psYearly.RetentionScheduleFormatType.ToString()).ToString();
+            hydraYearly.RetentionScheduleFormatType = psYearly.RetentionScheduleFormatType.ToString();
             if (psYearly.RetentionScheduleFormatType == RetentionScheduleFormat.Daily)
             {
                 hydraYearly.RetentionScheduleDaily = GetHydraLTRDailyRetentionFormat(psYearly.RetentionScheduleDaily);

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Providers/Providers/IaasVmPsBackupProvider.cs

@@ -398,6 +398,8 @@ public AzureRmRecoveryServicesRetentionPolicyBase GetDefaultRetentionPolicyObjec
             defaultRetention.IsMonthlyScheduleEnabled = true;
             defaultRetention.MonthlySchedule = new Models.MonthlyRetentionSchedule();
             defaultRetention.MonthlySchedule.DurationCountInMonths = 60; //tbd: make it const
+            defaultRetention.MonthlySchedule.RetentionTimes = new List<DateTime>();
+            defaultRetention.MonthlySchedule.RetentionTimes.Add(retentionTime);
             defaultRetention.MonthlySchedule.RetentionScheduleFormatType = Models.RetentionScheduleFormat.Weekly;
 
             //Initialize day based schedule
@@ -410,6 +412,8 @@ public AzureRmRecoveryServicesRetentionPolicyBase GetDefaultRetentionPolicyObjec
             defaultRetention.IsYearlyScheduleEnabled = true;
             defaultRetention.YearlySchedule = new Models.YearlyRetentionSchedule();
             defaultRetention.YearlySchedule.DurationCountInYears = 10;
+            defaultRetention.YearlySchedule.RetentionTimes = new List<DateTime>();
+            defaultRetention.YearlySchedule.RetentionTimes.Add(retentionTime);
             defaultRetention.YearlySchedule.RetentionScheduleFormatType = Models.RetentionScheduleFormat.Weekly;
             defaultRetention.YearlySchedule.MonthsOfYear = new List<Models.Month>();
             defaultRetention.YearlySchedule.MonthsOfYear.Add(Models.Month.January);
@@ -666,17 +670,17 @@ private void CopyScheduleTimeToRetentionTimes(AzureRmRecoveryServicesLongTermRet
 
             if (retPolicy.IsWeeklyScheduleEnabled && retPolicy.WeeklySchedule != null)
             {
-                retPolicy.DailySchedule.RetentionTimes = schPolicy.ScheduleRunTimes;
+                retPolicy.WeeklySchedule.RetentionTimes = schPolicy.ScheduleRunTimes;
             }
 
             if (retPolicy.IsMonthlyScheduleEnabled && retPolicy.MonthlySchedule != null)
             {
-                retPolicy.DailySchedule.RetentionTimes = schPolicy.ScheduleRunTimes;
+                retPolicy.MonthlySchedule.RetentionTimes = schPolicy.ScheduleRunTimes;
             }
 
             if (retPolicy.IsYearlyScheduleEnabled && retPolicy.YearlySchedule != null)
             {
-                retPolicy.DailySchedule.RetentionTimes = schPolicy.ScheduleRunTimes;
+                retPolicy.YearlySchedule.RetentionTimes = schPolicy.ScheduleRunTimes;
             }
         }
 

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Test/Commands.RecoveryServices.Backup.Test.csproj

@@ -91,6 +91,10 @@
       <Project>{3436a126-edc9-4060-8952-9a1be34cdd95}</Project>
       <Name>Commands.ScenarioTests.ResourceManager.Common</Name>
     </ProjectReference>
+    <ProjectReference Include="..\..\RecoveryServices\Commands.RecoveryServices\Commands.RecoveryServices.csproj">
+      <Project>{604260dc-b392-4cf4-81ec-34b14591e2d2}</Project>
+      <Name>Commands.RecoveryServices</Name>
+    </ProjectReference>
     <ProjectReference Include="..\Commands.RecoveryServices.Backup.Cmdlets.csproj">
       <Project>{3b3e879a-f856-46bf-aff9-8ad6760cf7b9}</Project>
       <Name>Commands.RecoveryServices.Backup.Cmdlets</Name>