address comments

Author: dihan0604

src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/Stats/GetAzureExpressRouteCircuitARPTableCommand.cs

@@ -27,8 +27,8 @@ namespace Microsoft.Azure.Commands.Network
  {
      public enum DevicePathEnum		
      {		
-        primary, 		
-        secondary		
+        Primary, 		
+        Secondary		
      }		
 
      [Cmdlet(VerbsCommon.Get, "AzureRmExpressRouteCircuitARPTable"),OutputType(typeof(PSExpressRouteCircuitArpTable))]		
@@ -69,25 +69,21 @@ public class GetAzureExpressRouteCircuitARPTableCommand : NetworkBaseCmdlet
          [Parameter(		
              Mandatory = true,		
              HelpMessage = "The DevicePath, can be either Primary or Secondary")]		
-         [ValidateNotNullOrEmpty]		
-         public string DevicePath { get; set; }		
+         [ValidateNotNullOrEmpty]
+         public DevicePathEnum DevicePath { get; set; }		
 
          public override void ExecuteCmdlet()		
          {		
              base.ExecuteCmdlet();		
-             DevicePathEnum path;		
-             if (Enum.TryParse(DevicePath, true, out path))		
-             {		
-                 var arpTables = this.NetworkClient.NetworkManagementClient.ExpressRouteCircuits.ListArpTable
-                     (ResourceGroupName, ExpressRouteCircuitName, PeeringType, DevicePath).Value.Cast<object>().ToList();       		
-                 var psARPs = new List<PSExpressRouteCircuitArpTable>();		
-                 foreach (var arpTable in arpTables)		
-                 {		
-                     var psARP = Mapper.Map<PSExpressRouteCircuitArpTable>(arpTable);		
-                     psARPs.Add(psARP);		
-                 }		
-                 WriteObject(psARPs, true);		
-             }		
+             var arpTables = this.NetworkClient.NetworkManagementClient.ExpressRouteCircuits.ListArpTable
+                     (ResourceGroupName, ExpressRouteCircuitName, PeeringType, DevicePath.ToString()).Value.Cast<object>().ToList();
+             var psARPs = new List<PSExpressRouteCircuitArpTable>();
+             foreach (var arpTable in arpTables)
+             {
+                 var psARP = Mapper.Map<PSExpressRouteCircuitArpTable>(arpTable);
+                 psARPs.Add(psARP);
+             }
+             WriteObject(psARPs, true);
          }		
      }		
 

src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/Stats/GetAzureExpressRouteCircuitRouteTableCommand.cs

@@ -24,11 +24,7 @@
  using System.Linq;
 
  namespace Microsoft.Azure.Commands.Network		
- {		
-		
- 		
-	
- 		
+ {			
      [Cmdlet(VerbsCommon.Get, "AzureRmExpressRouteCircuitRouteTable"),OutputType(typeof(PSExpressRouteCircuitRoutesTable))]
      public class GetAzureRmExpressRouteCircuitRouteTable : NetworkBaseCmdlet		
      {		
@@ -62,30 +58,26 @@ public class GetAzureRmExpressRouteCircuitRouteTable : NetworkBaseCmdlet
             MNM.ExpressRouteCircuitPeeringType.AzurePublicPeering,		
             MNM.ExpressRouteCircuitPeeringType.MicrosoftPeering,		
             IgnoreCase = true)]		
-         public string PeeringType { get; set; }		
- 		
-         [Parameter(		
-             Mandatory = true,		
-             HelpMessage = "The DevicePath, can be either Primary or Secondary")]		
-         [ValidateNotNullOrEmpty]		
-         public string DevicePath { get; set; }		
+         public string PeeringType { get; set; }
+
+         [Parameter(
+                      Mandatory = true,
+                      HelpMessage = "The DevicePath, can be either Primary or Secondary")]
+         [ValidateNotNullOrEmpty]
+         public DevicePathEnum DevicePath { get; set; }			
 
          public override void ExecuteCmdlet()		
          {		
-             base.ExecuteCmdlet();		
-             DevicePathEnum path;		
-             if (Enum.TryParse(DevicePath, true, out path))		
-             {		
-                 var routeTables = this.NetworkClient.NetworkManagementClient.ExpressRouteCircuits.ListRoutesTable
-                     (ResourceGroupName, ExpressRouteCircuitName, PeeringType, DevicePath).Value.Cast<object>().ToList();
-                 var psRoutes = new List<PSExpressRouteCircuitRoutesTable>();
-                 foreach (var routeTable in routeTables)		
-                 {
-                     var psRoute = Mapper.Map<PSExpressRouteCircuitRoutesTable>(routeTable);
-                     psRoutes.Add(psRoute);		
-                 }
-                 WriteObject(psRoutes, true);		
-             }		
+             base.ExecuteCmdlet();
+             var routeTables = this.NetworkClient.NetworkManagementClient.ExpressRouteCircuits.ListRoutesTable
+                 (ResourceGroupName, ExpressRouteCircuitName, PeeringType, DevicePath.ToString()).Value.Cast<object>().ToList();
+             var psRoutes = new List<PSExpressRouteCircuitRoutesTable>();
+             foreach (var routeTable in routeTables)
+             {
+                 var psRoute = Mapper.Map<PSExpressRouteCircuitRoutesTable>(routeTable);
+                 psRoutes.Add(psRoute);
+             }
+             WriteObject(psRoutes, true);
          }		
      }		
 

src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/Stats/GetAzureExpressRouteCircuitRouteTableSummaryCommand.cs

@@ -25,8 +25,6 @@
 
 namespace Microsoft.Azure.Commands.Network
 {
-
-
     [Cmdlet(VerbsCommon.Get, "AzureRmExpressRouteCircuitRouteTableSummary"), OutputType(typeof(PSExpressRouteCircuitRoutesTableSummary))]
     public class GetAzureRmExpressRouteCircuitRouteTableSummaryCommand : NetworkBaseCmdlet
     {
@@ -63,27 +61,23 @@ public class GetAzureRmExpressRouteCircuitRouteTableSummaryCommand : NetworkBase
         public string PeeringType { get; set; }
 
         [Parameter(
-            Mandatory = true,
-            HelpMessage = "The DevicePath, can be either Primary or Secondary")]
+                     Mandatory = true,
+                     HelpMessage = "The DevicePath, can be either Primary or Secondary")]
         [ValidateNotNullOrEmpty]
-        public string DevicePath { get; set; }
+        public DevicePathEnum DevicePath { get; set; }		
 
         public override void ExecuteCmdlet()
         {
             base.ExecuteCmdlet();
-            DevicePathEnum path;
-            if (Enum.TryParse(DevicePath, true, out path))
+            var arpTables = this.NetworkClient.NetworkManagementClient.ExpressRouteCircuits.ListRoutesTableSummary
+                    (ResourceGroupName, ExpressRouteCircuitName, PeeringType, DevicePath.ToString()).Value.Cast<object>().ToList();
+            var psARPs = new List<PSExpressRouteCircuitRoutesTableSummary>();
+            foreach (var arpTable in arpTables)
             {
-                var arpTables = this.NetworkClient.NetworkManagementClient.ExpressRouteCircuits.ListRoutesTableSummary
-                    (ResourceGroupName, ExpressRouteCircuitName, PeeringType, DevicePath).Value.Cast<object>().ToList();
-                var psARPs = new List<PSExpressRouteCircuitRoutesTableSummary>();
-                foreach (var arpTable in arpTables)
-                {
-                    var psARP = Mapper.Map<PSExpressRouteCircuitRoutesTableSummary>(arpTable);
-                    psARPs.Add(psARP);
-                }
-                WriteObject(psARPs, true);
+                var psARP = Mapper.Map<PSExpressRouteCircuitRoutesTableSummary>(arpTable);
+                psARPs.Add(psARP);
             }
+            WriteObject(psARPs, true);
         }
     }