Get Container Filters

Author: dragonfly91

src/ResourceManager/RecoveryServices.Backup/Cmdlets/Container/GetAzureRmRecoveryServicesContainer.cs

@@ -47,7 +47,7 @@ public class GetAzureRmRecoveryServicesContainer : RecoveryServicesBackupCmdletB
         [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
 
-        [Parameter(Mandatory = false, HelpMessage = ParamHelpMsg.Container.Get.Status)]
+        [Parameter(Mandatory = true, HelpMessage = ParamHelpMsg.Container.Get.Status)]
         [ValidateNotNullOrEmpty]
         public ContainerRegistrationStatus Status { get; set; }
 
@@ -56,16 +56,28 @@ public override void ExecuteCmdlet()
             base.ExecuteCmdlet();
 
             ProtectionContainerListQueryParams queryParams = new ProtectionContainerListQueryParams();
+
+            // 1. Filter by Name
             queryParams.FriendlyName = Name;
-            
-            // TODO: Removing hardcoding of ProviderType
-            queryParams.ProviderType = ProviderType.AzureIaasVM.ToString();
+
+            // 2. Filter by ContainerType
+            queryParams.ProviderType = HydraHelpers.GetHydraProviderType(ContainerType);
+
+            // 3. Filter by Status
             queryParams.RegistrationStatus = Status.ToString();
+
             var listResponse = HydraAdapter.ListContainers(Vault.Name, Vault.ResouceGroupName, queryParams);
 
-            // TODO: Filter the response
+            List<AzureRmRecoveryServicesContainerBase> containerModels = ConversionHelpers.GetContainerModelList(listResponse);
+
+            // 4. Filter by RG Name
+            if (ContainerType == Models.ContainerType.AzureVM)
+            {
+                containerModels.RemoveAll(containerModel =>
+                    (containerModel as AzureRmRecoveryServicesIaasVmContainer).ResourceGroupName == ResourceGroupName);
+            }
 
-            WriteObject((ConversionHelpers.GetContainerModelList(listResponse)));
+            WriteObject(containerModels);
         }
     }
 }

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/Commands.RecoveryServices.Backup.Helpers.csproj

@@ -43,6 +43,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="ConversionHelpers.cs" />
+    <Compile Include="HydraHelpers.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
   </ItemGroup>
   <ItemGroup>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Helpers/HydraHelpers.cs

@@ -0,0 +1,43 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models;
+using Microsoft.Azure.Management.RecoveryServices.Backup.Models;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Helpers
+{
+    public class HydraHelpers
+    {
+        public static string GetHydraProviderType(ContainerType containerType)
+        {
+            string providerType = string.Empty;
+
+            switch (containerType)
+            {
+                case ContainerType.AzureVM:
+                    providerType = ProviderType.AzureIaasVM.ToString();
+                    break;
+                default:
+                    break;
+            }
+
+            return providerType;
+        }
+    }
+}