Skip to content

Commit 324d57e

Browse files
author
cormacpayne
authored
Remove the tags deprecation message from all cmdlets (#2669)
* Remove the tags deprecation message from all cmdlets * Added necessary warning messages that were deleted * Fixed styling in two files
1 parent 6767e15 commit 324d57e

File tree

50 files changed

+53
-164
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+53
-164
lines changed

‎src/ResourceManager/AzureBatch/Commands.Batch/Accounts/GetBatchAccountCommand.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -35,9 +35,6 @@ public class GetBatchAccountCommand : BatchCmdletBase
3535

3636
public override void ExecuteCmdlet()
3737
{
38-
WriteWarning("WARNING: The usage of the Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags " +
39-
"for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494 ");
40-
4138
if (string.IsNullOrEmpty(this.AccountName))
4239
{
4340
foreach (BatchAccountContext context in BatchClient.ListAccounts(Tag, this.ResourceGroupName))

‎src/ResourceManager/AzureBatch/Commands.Batch/Accounts/NewBatchAccountCommand.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -46,9 +46,6 @@ public class NewBatchAccountCommand : BatchCmdletBase
4646

4747
public override void ExecuteCmdlet()
4848
{
49-
WriteWarning("WARNING: The usage of the Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags " +
50-
"for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494 ");
51-
5249
BatchAccountContext context = BatchClient.CreateAccount(this.ResourceGroupName, this.AccountName, this.Location, this.Tag, this.AutoStorageAccountId);
5350
WriteObject(context);
5451
}

‎src/ResourceManager/AzureBatch/Commands.Batch/Accounts/SetBatchAccountCommand.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -41,9 +41,6 @@ public class SetBatchAccountCommand : BatchCmdletBase
4141

4242
public override void ExecuteCmdlet()
4343
{
44-
WriteWarning("WARNING: The usage of the Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags " +
45-
"for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494 ");
46-
4744
BatchAccountContext context = BatchClient.UpdateAccount(this.ResourceGroupName, this.AccountName, this.Tag, this.AutoStorageAccountId);
4845
WriteObject(context);
4946
}

‎src/ResourceManager/Compute/Commands.Compute/Properties/Resources.Designer.cs

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/ResourceManager/Compute/Commands.Compute/Properties/Resources.resx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -511,9 +511,6 @@ The file needs to be a PowerShell script (.ps1 or .psm1) or a ZIP archive (.zip)
511511
<value>Error occurred when choosing existing standard storage account for boot diagnostics: {0}</value>
512512
<comment>{0} = an error message</comment>
513513
</data>
514-
<data name="TagFixWarningMessage" xml:space="preserve">
515-
<value>The usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494</value>
516-
</data>
517514
<data name="DisableDiskEncryptionAction" xml:space="preserve">
518515
<value>Disable disk encryption</value>
519516
</data>

‎src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ public class NewAzureVMCommand : VirtualMachineBaseCmdlet
7575

7676
public override void ExecuteCmdlet()
7777
{
78-
WriteWarning(Properties.Resources.TagFixWarningMessage);
79-
8078
base.ExecuteCmdlet();
8179

8280
if (this.VM.DiagnosticsProfile == null)

‎src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/UpdateAzureVMCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ public override void ExecuteCmdlet()
4444
{
4545
ExecuteClientAction(() =>
4646
{
47-
WriteWarning(Properties.Resources.TagFixWarningMessage);
4847
var parameters = new VirtualMachine
4948
{
5049
DiagnosticsProfile = this.VM.DiagnosticsProfile,

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/NewAzureRmDataLakeAnalyticsAccount.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,6 @@ public class NewAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase
5656

5757
public override void ExecuteCmdlet()
5858
{
59-
if (Tags != null && Tags.Length > 0)
60-
{
61-
WriteWarningWithTimestamp(Properties.Resources.TagsWarning);
62-
}
63-
6459
try
6560
{
6661
if (DataLakeAnalyticsClient.GetAccount(ResourceGroupName, Name) != null)

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/SetAzureRmDataLakeAnalyticsAccount.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,6 @@ public class SetAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase
4848

4949
public override void ExecuteCmdlet()
5050
{
51-
if (Tags != null && Tags.Length > 0)
52-
{
53-
WriteWarningWithTimestamp(Properties.Resources.TagsWarning);
54-
}
55-
5651
DataLakeStoreAccountInfo defaultAccount = null;
5752
if (!string.IsNullOrEmpty(DefaultDataLakeStore))
5853
{

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Properties/Resources.Designer.cs

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Properties/Resources.resx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,4 @@
204204
<data name="RemovingDataLakeAnalyticsCatalogSecrets" xml:space="preserve">
205205
<value>Are you sure you want to remove ALL Data Lake Analytics catalog secrets in database '{0}'?</value>
206206
</data>
207-
<data name="TagsWarning" xml:space="preserve">
208-
<value>The usage of 'Tags' parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494</value>
209-
</data>
210207
</root>

‎src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/NewAzureRmDataLakeStoreAccount.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ public class NewAzureDataLakeStoreAccount : DataLakeStoreCmdletBase
5858

5959
public override void ExecuteCmdlet()
6060
{
61-
if(Tags != null && Tags.Length > 0)
62-
{
63-
WriteWarningWithTimestamp(Resources.TagsWarning);
64-
}
65-
6661
try
6762
{
6863
if (DataLakeStoreClient.GetAccount(ResourceGroupName, Name) != null)

‎src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/SetAzureRmDataLakeStoreAccount.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,6 @@ public class SetAzureDataLakeStoreAccount : DataLakeStoreCmdletBase
4949

5050
public override void ExecuteCmdlet()
5151
{
52-
if (Tags != null && Tags.Length > 0)
53-
{
54-
WriteWarningWithTimestamp(Properties.Resources.TagsWarning);
55-
}
56-
5752
var currentAccount = DataLakeStoreClient.GetAccount(ResourceGroupName, Name);
5853
var location = currentAccount.Location;
5954

‎src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Properties/Resources.Designer.cs

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Properties/Resources.resx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,6 @@
229229
<data name="SettingDataLakeStoreItemOwner" xml:space="preserve">
230230
<value>Are you sure you want to replace the existing owning group or user at the Data Lake item at path: '{0}'?</value>
231231
</data>
232-
<data name="TagsWarning" xml:space="preserve">
233-
<value>The usage of 'Tags' parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494</value>
234-
</data>
235232
<data name="TaskCancelledMessage" xml:space="preserve">
236233
<value>The operation is being cancelled, please wait...</value>
237234
</data>

‎src/ResourceManager/Dns/Commands.Dns/Zones/NewAzureDnsZone.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -39,7 +39,7 @@ public class NewAzureDnsZone : DnsBaseCmdlet
3939

4040
public override void ExecuteCmdlet()
4141
{
42-
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
42+
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
4343

4444
if (this.Name.EndsWith("."))
4545
{

‎src/ResourceManager/Dns/Commands.Dns/Zones/SetAzureDnsZone.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -46,7 +46,7 @@ public class SetAzureDnsZone : DnsBaseCmdlet
4646

4747
public override void ExecuteCmdlet()
4848
{
49-
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
49+
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
5050

5151
DnsZone result = null;
5252
DnsZone zoneToUpdate = null;

‎src/ResourceManager/KeyVault/Commands.KeyVault/Commands/GetAzureKeyVault.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -75,8 +75,6 @@ public class GetAzureKeyVault : KeyVaultManagementCmdletBase
7575
#endregion
7676
public override void ExecuteCmdlet()
7777
{
78-
WriteWarning("The usage of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
79-
8078
switch (ParameterSetName)
8179
{
8280
case GetVaultParameterSet:
@@ -103,4 +101,4 @@ public override void ExecuteCmdlet()
103101
}
104102
}
105103
}
106-
}
104+
}

‎src/ResourceManager/KeyVault/Commands.KeyVault/Commands/NewAzureKeyVault.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -94,8 +94,6 @@ public class NewAzureKeyVault : KeyVaultManagementCmdletBase
9494

9595
public override void ExecuteCmdlet()
9696
{
97-
WriteWarning("The usage of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
98-
9997
if (VaultExistsInCurrentSubscription(this.VaultName))
10098
{
10199
throw new ArgumentException(PSKeyVaultProperties.Resources.VaultAlreadyExists);

‎src/ResourceManager/Network/Commands.Network/ApplicationGateway/NewAzureApplicationGatewayCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -132,7 +132,7 @@ public override void ExecuteCmdlet()
132132
{
133133
base.ExecuteCmdlet();
134134

135-
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
135+
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
136136
var present = this.IsApplicationGatewayPresent(this.ResourceGroupName, this.Name);
137137
ConfirmAction(
138138
Force.IsPresent,

‎src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/NewAzureExpressRouteCircuitCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -114,7 +114,7 @@ public class NewAzureExpressRouteCircuitCommand : ExpressRouteCircuitBaseCmdlet
114114

115115
public override void Execute()
116116
{
117-
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
117+
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
118118
var present = this.IsExpressRouteCircuitPresent(this.ResourceGroupName, this.Name);
119119
ConfirmAction(
120120
Force.IsPresent,

‎src/ResourceManager/Network/Commands.Network/LoadBalancer/NewAzureLoadBalancerCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -100,7 +100,7 @@ public class NewAzureLoadBalancerCommand : LoadBalancerBaseCmdlet
100100
public override void Execute()
101101
{
102102
base.Execute();
103-
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
103+
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
104104
var present = this.IsLoadBalancerPresent(this.ResourceGroupName, this.Name);
105105
ConfirmAction(
106106
Force.IsPresent,

‎src/ResourceManager/Network/Commands.Network/LocalNetworkGateway/NewAzureLocalNetworkGatewayCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ----------------------------------------------------------------------------------
1+
// ----------------------------------------------------------------------------------
22
//
33
// Copyright Microsoft Corporation
44
// Licensed under the Apache License, Version 2.0 (the "License");
@@ -94,7 +94,7 @@ public class NewAzureLocalNetworkGatewayCommand : LocalNetworkGatewayBaseCmdlet
9494
public override void Execute()
9595
{
9696
base.Execute();
97-
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
97+
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
9898
var present = this.IsLocalNetworkGatewayPresent(this.ResourceGroupName, this.Name);
9999
ConfirmAction(
100100
Force.IsPresent,

‎src/ResourceManager/Network/Commands.Network/NetworkInterface/NewAzureNetworkInterfaceCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-

1+
22

33
// ----------------------------------------------------------------------------------
44
//
@@ -220,7 +220,7 @@ public class NewAzureNetworkInterfaceCommand : NetworkInterfaceBaseCmdlet
220220
public override void Execute()
221221
{
222222
base.Execute();
223-
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
223+
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
224224
var present = this.IsNetworkInterfacePresent(this.ResourceGroupName, this.Name);
225225
ConfirmAction(
226226
Force.IsPresent,

0 commit comments

Comments
 (0)