Merge pull request #8094 from maddieclayton/rcbc2

Breaking changes for Az.RecoveryServices.SiteRecovery

Author: markcowl

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.SiteRecovery.Test/ScenarioTests/B2A/AsrB2ATests.ps1

@@ -154,7 +154,7 @@ function Test-CreatePolicy
 
     # Import Azure RecoveryServices Vault Settings File
     Import-AzureRmRecoveryServicesAsrVaultSettingsFile -Path $vaultSettingsFilePath
-    $currentJob = New-AzureRmRecoveryServicesAsrPolicy -Name $ProtectionProfileName -ReplicationProvider HyperVReplicaAzure -ReplicationFrequencyInSeconds 30 -RecoveryPoints 1 -ApplicationConsistentSnapshotFrequencyInHours 0 -RecoveryAzureStorageAccountId $StorageAccountID -Encryption Disable
+    $currentJob = New-AzureRmRecoveryServicesAsrPolicy -Name $ProtectionProfileName -ReplicationProvider HyperVReplicaAzure -ReplicationFrequencyInSeconds 30 -RecoveryPoints 1 -ApplicationConsistentSnapshotFrequencyInHours 0 -RecoveryAzureStorageAccountId $StorageAccountID
     WaitForJobCompletion -JobId $currentJob.Name
     $ProtectionProfile = Get-AzureRmRecoveryServicesAsrPolicy -Name $ProtectionProfileName
     $ProtectionProfile

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.SiteRecovery.Test/ScenarioTests/E2A/AsrE2ATests.ps1

@@ -167,7 +167,7 @@ function Test-SiteRecoveryCreatePolicy
 	Import-AzureRmRecoveryServicesAsrVaultSettingsFile -Path $vaultSettingsFilePath
 
 	# Create profile
-	$Job =  New-AzureRmRecoveryServicesAsrPolicy -Name $PolicyName -ReplicationProvider HyperVReplicaAzure -ReplicationFrequencyInSeconds 30 -RecoveryPoints 1 -ApplicationConsistentSnapshotFrequencyInHours 0 -Encryption Disable -RecoveryAzureStorageAccountId $RecoveryAzureStorageAccountId
+	$Job =  New-AzureRmRecoveryServicesAsrPolicy -Name $PolicyName -ReplicationProvider HyperVReplicaAzure -ReplicationFrequencyInSeconds 30 -RecoveryPoints 1 -ApplicationConsistentSnapshotFrequencyInHours 0  -RecoveryAzureStorageAccountId $RecoveryAzureStorageAccountId
 	WaitForJobCompletion -JobId $Job.Name -JobQueryWaitTimeInSeconds $JobQueryWaitTimeInSeconds
 
 	# Get a profile created (with name ppAzure)

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.SiteRecovery/ChangeLog.md

@@ -19,5 +19,7 @@
 -->
 ## Current Release
 
+
 ## Version 1.0.0
-* General availability of `Az.RecoveryServices` module
+* General availability of `Az.RecoveryServices` module
+* Remove -Encryption parameter from New/Set-AzRecoveryServicesAsrPolicy

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.SiteRecovery/Policy/NewAzureRmRecoveryServicesAsrPolicy.cs

@@ -211,18 +211,6 @@ public class NewAzureRmRecoveryServicesAsrPolicy : SiteRecoveryCmdletBase
         [ValidateNotNullOrEmpty]
         public string RecoveryAzureStorageAccountId { get; set; }
 
-        /// <summary>
-        ///     Gets or sets if encryption should be enabled or disabled.
-        ///  todo : vipin add in breaking changes list.Mark obsolete for now.
-        /// </summary>
-        [Parameter(ParameterSetName = ASRParameterSets.HyperVToAzure)]
-        [DefaultValue(Constants.Disable)]
-        [Obsolete("cmdlet parameter will be removed in upcoming breaking release")]
-        [ValidateSet(
-            Constants.Enable,
-            Constants.Disable)]
-        public string Encryption { get; set; }
-
         /// <summary>
         ///     Gets or sets the multiVm sync status for the policy.
         /// </summary>

src/ResourceManager/RecoveryServices/Commands.RecoveryServices.SiteRecovery/Policy/UpdateAzureRmRecoveryServicesAsrPolicy.cs

@@ -194,19 +194,6 @@ public class UpdateAzureRmRecoveryServicesAsrPolicy : SiteRecoveryCmdletBase
         [ValidateNotNullOrEmpty]
         public string RecoveryAzureStorageAccountId { get; set; }
 
-        /// <summary>
-        ///     Gets or sets encryption should be enabled or disabled.
-        /// </summary>
-        
-        [Parameter(ParameterSetName = ASRParameterSets.HyperVToAzure)]
-        [Parameter(ParameterSetName = ASRParameterSets.Default)]
-        [Obsolete("cmdlet parameter will be removed in upcoming breaking release")]
-        [ValidateNotNullOrEmpty]
-        [ValidateSet(
-            Constants.Enable,
-            Constants.Disable)]
-        public string Encryption { get; set; }
-
         /// <summary>
         ///     Gets or sets multiVm sync status for the policy.
         /// </summary>
@@ -352,8 +339,6 @@ private void HyperVToAzurePolicyObject()
             {
                 ApplicationConsistentSnapshotFrequencyInHours =
                     this.applicationConsistentSnapshotFrequencyInHours,
-// encryption is removed from latest API . Service is setting the default vault internally.
-// todo :: Warning.
                 OnlineReplicationStartTime = this.replicationStartTime.ToString(),
                 RecoveryPointHistoryDuration = this.recoveryPoints,
                 ReplicationInterval = this.replicationFrequencyInSeconds

src/ResourceManager/RecoveryServices/Commands.RecoveryServices/help/New-AzRecoveryServicesAsrPolicy.md

@@ -17,7 +17,7 @@ Creates an Azure Site Recovery replication policy.
 New-AzRecoveryServicesAsrPolicy [-HyperVToAzure] -Name <String> -ReplicationProvider <String>
  -ReplicationFrequencyInSeconds <String> [-NumberOfRecoveryPointsToRetain <Int32>]
  [-ApplicationConsistentSnapshotFrequencyInHours <Int32>] [-ReplicationStartTime <TimeSpan>]
- [-RecoveryAzureStorageAccountId <String>] [-Encryption <String>] [-DefaultProfile <IAzureContextContainer>]
+ [-RecoveryAzureStorageAccountId <String>] [-DefaultProfile <IAzureContextContainer>]
  [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
@@ -219,22 +219,6 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -Encryption
-{{Fill Encryption Description}}
-
-```yaml
-Type: System.String
-Parameter Sets: HyperVToAzure
-Aliases:
-Accepted values: Enable, Disable
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### -HyperVToAzure
 Switch parameter to specify policy is to be used to replicate Hyper-V virtual machines to Azure
 

src/ResourceManager/RecoveryServices/Commands.RecoveryServices/help/Update-AzRecoveryServicesAsrPolicy.md

@@ -18,7 +18,7 @@ Update-AzRecoveryServicesAsrPolicy -InputObject <ASRPolicy> [-ReplicationMethod
  [-ReplicationFrequencyInSeconds <String>] [-NumberOfRecoveryPointsToRetain <Int32>]
  [-ApplicationConsistentSnapshotFrequencyInHours <Int32>] [-Compression <String>] [-ReplicationPort <UInt16>]
  [-Authentication <String>] [-ReplicationStartTime <TimeSpan>] [-ReplicaDeletion <String>]
- [-RecoveryAzureStorageAccountId <String>] [-Encryption <String>] [-DefaultProfile <IAzureContextContainer>]
+ [-RecoveryAzureStorageAccountId <String>] [-DefaultProfile <IAzureContextContainer>]
  [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
@@ -51,7 +51,7 @@ Update-AzRecoveryServicesAsrPolicy [-AzureToVMware] -InputObject <ASRPolicy>
 Update-AzRecoveryServicesAsrPolicy [-HyperVToAzure] -InputObject <ASRPolicy>
  [-ReplicationFrequencyInSeconds <String>] [-NumberOfRecoveryPointsToRetain <Int32>]
  [-ApplicationConsistentSnapshotFrequencyInHours <Int32>] [-ReplicationStartTime <TimeSpan>]
- [-RecoveryAzureStorageAccountId <String>] [-Encryption <String>] [-DefaultProfile <IAzureContextContainer>]
+ [-RecoveryAzureStorageAccountId <String>] [-DefaultProfile <IAzureContextContainer>]
  [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
@@ -185,22 +185,6 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -Encryption
-{{Fill Encryption Description}}
-
-```yaml
-Type: System.String
-Parameter Sets: Default, HyperVToAzure
-Aliases:
-Accepted values: Enable, Disable
-
-Required: False
-Position: Named
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### -HyperVToAzure
 Switch parameter indicating that the specfied policy is used to replicate Hyper-V virtual machines to Azure.