Merge pull request #2475 from DamirAinullin/dev

markcowl · web-flow · commit 36190d4d584c · 2016-06-23T09:44:14.000-07:00
fixes of obvious code mistakes
diff --git a/src/ResourceManager/Automation/Commands.Automation/Common/AutomationClient.cs b/src/ResourceManager/Automation/Commands.Automation/Common/AutomationClient.cs
@@ -867,7 +867,7 @@ public CredentialInfo CreateCredential(string resourceGroupName, string automati
 
             if (createdCredential == null || createdCredential.StatusCode != HttpStatusCode.Created)
             {
-                new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Create",
+                throw new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Create",
                     "credential", name, automationAccountName));
             }
             return new CredentialInfo(resourceGroupName, automationAccountName, createdCredential.Credential);
@@ -891,7 +891,7 @@ public CredentialInfo UpdateCredential(string resourceGroupName, string automati
 
             if (credential == null || credential.StatusCode != HttpStatusCode.OK)
             {
-                new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Update",
+                throw new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Update",
                     "credential", name, automationAccountName));
             }
 
diff --git a/src/ResourceManager/AzureBackup/Commands.AzureBackup/Cmdlets/Jobs/GetAzureRMBackupJob.cs b/src/ResourceManager/AzureBackup/Commands.AzureBackup/Cmdlets/Jobs/GetAzureRMBackupJob.cs
@@ -90,7 +90,6 @@ public override void ExecuteCmdlet()
                         throw new Exception(Resources.AzureBackupJobArguementException);
                     }
                     WriteDebug(Resources.SettingStartTime);
-                    From = new DateTime();
                     From = AzureBackupJobHelper.MinimumAllowedDate;
                 }
 
@@ -112,7 +111,6 @@ public override void ExecuteCmdlet()
                     else
                     {
                         WriteDebug(Resources.SettingEndTime);
-                        To = new DateTime();
                         To = AzureBackupJobHelper.MinimumAllowedDate;
                     }
                 }
diff --git a/src/ResourceManager/AzureBackup/Commands.AzureBackup/Cmdlets/Jobs/WaitAzureRMBackupJob.cs b/src/ResourceManager/AzureBackup/Commands.AzureBackup/Cmdlets/Jobs/WaitAzureRMBackupJob.cs
@@ -96,7 +96,6 @@ public override void ExecuteCmdlet()
             {
                 if (!TimeOut.HasValue)
                 {
-                    TimeOut = new long();
                     TimeOut = Int64.MaxValue;
                 }
 
diff --git a/src/ResourceManager/AzureBatch/Commands.Batch.Test/Tasks/GetBatchTaskCommandTests.cs b/src/ResourceManager/AzureBatch/Commands.Batch.Test/Tasks/GetBatchTaskCommandTests.cs
@@ -172,9 +172,7 @@ public void ListBatchTasksODataTest()
                 };
 
             RequestInterceptor requestInterceptor = BatchTestHelpers.CreateFakeServiceResponseInterceptor(responseToUse: response, requestAction: extractTaskListAction);
-            cmdlet.AdditionalBehaviors = new List<BatchClientBehavior>() { requestInterceptor };
-
-            cmdlet.AdditionalBehaviors = new List<BatchClientBehavior>() { requestInterceptor };
+            cmdlet.AdditionalBehaviors = new List<BatchClientBehavior> { requestInterceptor };
 
             cmdlet.ExecuteCmdlet();
 
diff --git a/src/ResourceManager/Insights/Commands.Insights/OutputClasses/CustomPrinter.cs b/src/ResourceManager/Insights/Commands.Insights/OutputClasses/CustomPrinter.cs
@@ -79,7 +79,7 @@ private static void Print(object obj, string name, string currentIndent, StringB
 
             ICollection objAsCollection = obj as ICollection;
 
-            propName.Replace(':', ' ');
+            propName = propName.Replace(':', ' ');
             if (!string.IsNullOrWhiteSpace(propName))
             {
                 sb.AppendLine(propName);
diff --git a/src/ResourceManager/Network/Commands.Network/ApplicationGateway/NewAzureApplicationGatewayCommand.cs b/src/ResourceManager/Network/Commands.Network/ApplicationGateway/NewAzureApplicationGatewayCommand.cs
@@ -162,61 +162,51 @@ private PSApplicationGateway CreateApplicationGateway()
 
             if (this.GatewayIPConfigurations != null)
             {
-                applicationGateway.GatewayIPConfigurations = new List<PSApplicationGatewayIPConfiguration>();
                 applicationGateway.GatewayIPConfigurations = this.GatewayIPConfigurations;
             }
 
             if (this.SslCertificates != null)
             {
-                applicationGateway.SslCertificates = new List<PSApplicationGatewaySslCertificate>();
                 applicationGateway.SslCertificates = this.SslCertificates;
             }
 
             if (this.FrontendIPConfigurations != null)
             {
-                applicationGateway.FrontendIPConfigurations = new List<PSApplicationGatewayFrontendIPConfiguration>();
                 applicationGateway.FrontendIPConfigurations = this.FrontendIPConfigurations;
             }
 
             if (this.FrontendPorts != null)
             {
-                applicationGateway.FrontendPorts = new List<PSApplicationGatewayFrontendPort>();
                 applicationGateway.FrontendPorts = this.FrontendPorts;
             }
 
             if (this.Probes != null)
             {
-                applicationGateway.Probes = new List<PSApplicationGatewayProbe>();
                 applicationGateway.Probes = this.Probes;
             }
 
             if (this.BackendAddressPools != null)
             {
-                applicationGateway.BackendAddressPools = new List<PSApplicationGatewayBackendAddressPool>();
                 applicationGateway.BackendAddressPools = this.BackendAddressPools;
             }
 
             if (this.BackendHttpSettingsCollection != null)
             {
-                applicationGateway.BackendHttpSettingsCollection = new List<PSApplicationGatewayBackendHttpSettings>();
                 applicationGateway.BackendHttpSettingsCollection = this.BackendHttpSettingsCollection;
             }
 
             if (this.HttpListeners != null)
             {
-                applicationGateway.HttpListeners = new List<PSApplicationGatewayHttpListener>();
                 applicationGateway.HttpListeners = this.HttpListeners;
             }
 
             if (this.UrlPathMaps != null)
             {
-                applicationGateway.UrlPathMaps = new List<PSApplicationGatewayUrlPathMap>();
                 applicationGateway.UrlPathMaps = this.UrlPathMaps;
             }
 
             if (this.RequestRoutingRules != null)
             {
-                applicationGateway.RequestRoutingRules = new List<PSApplicationGatewayRequestRoutingRule>();
                 applicationGateway.RequestRoutingRules = this.RequestRoutingRules;
             }
 
diff --git a/src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/NewAzureExpressRouteCircuitCommand.cs b/src/ResourceManager/Network/Commands.Network/ExpressRouteCircuit/NewAzureExpressRouteCircuitCommand.cs
@@ -161,9 +161,7 @@ private PSExpressRouteCircuit CreateExpressRouteCircuit()
                 circuit.ServiceProviderProperties.BandwidthInMbps = this.BandwidthInMbps;
             }
 
-            circuit.Peerings = new List<PSPeering>();
             circuit.Peerings = this.Peering;
-            circuit.Authorizations = new List<PSExpressRouteCircuitAuthorization>();
             circuit.Authorizations = this.Authorization;
             circuit.AllowClassicOperations = this.AllowClassicOperations;
 
diff --git a/src/ResourceManager/Network/Commands.Network/LoadBalancer/NewAzureLoadBalancerCommand.cs b/src/ResourceManager/Network/Commands.Network/LoadBalancer/NewAzureLoadBalancerCommand.cs
@@ -130,37 +130,31 @@ private PSLoadBalancer CreateLoadBalancer()
 
             if (this.FrontendIpConfiguration != null)
             {
-                loadBalancer.FrontendIpConfigurations = new List<PSFrontendIPConfiguration>();
                 loadBalancer.FrontendIpConfigurations = this.FrontendIpConfiguration;
             }
 
             if (this.BackendAddressPool != null)
             {
-                loadBalancer.BackendAddressPools = new List<PSBackendAddressPool>();
                 loadBalancer.BackendAddressPools = this.BackendAddressPool;
             }
 
             if (this.Probe != null)
             {
-                loadBalancer.Probes = new List<PSProbe>();
                 loadBalancer.Probes = this.Probe;
             }
 
             if (this.InboundNatRule != null)
             {
-                loadBalancer.InboundNatRules = new List<PSInboundNatRule>();
                 loadBalancer.InboundNatRules = this.InboundNatRule;
             }
 
             if (this.LoadBalancingRule != null)
             {
-                loadBalancer.LoadBalancingRules = new List<PSLoadBalancingRule>();
                 loadBalancer.LoadBalancingRules = this.LoadBalancingRule;
             }
 
             if (this.InboundNatPool != null)
             {
-                loadBalancer.InboundNatPools = new List<PSInboundNatPool>();
                 loadBalancer.InboundNatPools = this.InboundNatPool;
             }
 
diff --git a/src/ResourceManager/Network/Commands.Network/VirtualNetwork/NewAzureVirtualNetworkCommand.cs b/src/ResourceManager/Network/Commands.Network/VirtualNetwork/NewAzureVirtualNetworkCommand.cs
@@ -118,7 +118,6 @@ private PSVirtualNetwork CreateVirtualNetwork()
                 vnet.DhcpOptions.DnsServers = this.DnsServer;
             }
 
-            vnet.Subnets = new List<PSSubnet>();
             vnet.Subnets = this.Subnet;
 
             // Map to the sdk object
diff --git a/src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs b/src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs
@@ -176,7 +176,6 @@ private PSVirtualNetworkGateway CreateVirtualNetworkGateway()
 
             if (this.IpConfigurations != null)
             {
-                vnetGateway.IpConfigurations = new List<PSVirtualNetworkGatewayIpConfiguration>();
                 vnetGateway.IpConfigurations = this.IpConfigurations;
             }
 
diff --git a/src/ResourceManager/OperationalInsights/Commands.OperationalInsights/Models/PSSearchListSavedSearchResponse.cs b/src/ResourceManager/OperationalInsights/Commands.OperationalInsights/Models/PSSearchListSavedSearchResponse.cs
@@ -26,19 +26,17 @@ public PSSearchListSavedSearchResponse()
 
         public PSSearchListSavedSearchResponse(SearchListSavedSearchResponse searchResponse)
         {
-            if (searchResponse != null)
+            if (searchResponse == null)
             {
-                if (searchResponse == null)
-                {
-                    throw new ArgumentNullException("saved search response");
-                }
-                SearchMetadata m = searchResponse.Metadata;
-                this.Metadata = new PSSearchMetadata(searchResponse.Metadata);
-                this.Value = new List<PSSavedSearchValue>();
-                foreach (SavedSearchValue v in searchResponse.Value)
-                {
-                    this.Value.Add(new PSSavedSearchValue(v));
-                }
+                throw new ArgumentNullException("saved search response");
+            }
+
+            SearchMetadata m = searchResponse.Metadata;
+            this.Metadata = new PSSearchMetadata(searchResponse.Metadata);
+            this.Value = new List<PSSavedSearchValue>();
+            foreach (SavedSearchValue v in searchResponse.Value)
+            {
+                this.Value.Add(new PSSavedSearchValue(v));
             }
         }
 
diff --git a/src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/SdkClient/ResourceManagerSdkClient.cs b/src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/SdkClient/ResourceManagerSdkClient.cs
@@ -351,13 +351,11 @@ private List<DeploymentOperation> GetNewOperations(List<DeploymentOperation> old
                     Enum.TryParse<HttpStatusCode>(operation.Properties.StatusCode, out statusCode);
                     if (!statusCode.IsClientFailureRequest())
                     {
-                        List<DeploymentOperation> newNestedOperations = new List<DeploymentOperation>();
-
                         var result = ResourceManagementClient.DeploymentOperations.List(
                             resourceGroupName: ResourceIdUtility.GetResourceGroupName(operation.Properties.TargetResource.Id),
                             deploymentName: operation.Properties.TargetResource.ResourceName);
 
-                        newNestedOperations = GetNewOperations(operations, result);
+                        List<DeploymentOperation>  newNestedOperations = GetNewOperations(operations, result);
 
                         foreach (DeploymentOperation op in newNestedOperations)
                         {
diff --git a/src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Utilities/TemplateUtility.cs b/src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Utilities/TemplateUtility.cs
@@ -39,7 +39,6 @@ public static class TemplateUtility
         /// <returns>The template parameters</returns>
         public static RuntimeDefinedParameterDictionary GetTemplateParametersFromFile(string templateFilePath, Hashtable templateParameterObject, string templateParameterFilePath, string[] staticParameters)
         {
-            RuntimeDefinedParameterDictionary dynamicParameters = new RuntimeDefinedParameterDictionary();
             string templateContent = null;
 
             if (templateFilePath != null)
@@ -54,7 +53,7 @@ public static RuntimeDefinedParameterDictionary GetTemplateParametersFromFile(st
                 }
             }
 
-            dynamicParameters = ParseTemplateAndExtractParameters(templateContent, templateParameterObject, templateParameterFilePath, staticParameters);
+            RuntimeDefinedParameterDictionary dynamicParameters = ParseTemplateAndExtractParameters(templateContent, templateParameterObject, templateParameterFilePath, staticParameters);
 
             return dynamicParameters;
         }
diff --git a/src/ResourceManager/SiteRecovery/Commands.SiteRecovery/ProtectionEntity/StartAzureSiteRecoveryTestFailoverJob.cs b/src/ResourceManager/SiteRecovery/Commands.SiteRecovery/ProtectionEntity/StartAzureSiteRecoveryTestFailoverJob.cs
@@ -236,7 +236,7 @@ private void StartPETestFailover()
                 }
                 else
                 {
-                    new ArgumentException(Properties.Resources.UnsupportedDirectionForTFO);// Throw Unsupported Direction Exception
+                    throw new ArgumentException(Properties.Resources.UnsupportedDirectionForTFO);// Throw Unsupported Direction Exception
                 }
             }
 
@@ -290,7 +290,7 @@ private void StartRpTestFailover()
                     }
                     else
                     {
-                        new ArgumentException(Properties.Resources.UnsupportedDirectionForTFO);// Throw Unsupported Direction Exception
+                        throw new ArgumentException(Properties.Resources.UnsupportedDirectionForTFO);// Throw Unsupported Direction Exception
                     }
                 }
             }
diff --git a/src/ServiceManagement/Compute/Sync/Download/BlobHandle.cs b/src/ServiceManagement/Compute/Sync/Download/BlobHandle.cs
@@ -70,7 +70,7 @@ private IEnumerable<IndexRange> GetPageRanges()
         {
             pageBlob.FetchAttributes(new AccessCondition(), blobRequestOptions);
             IEnumerable<PageRange> pageRanges = pageBlob.GetPageRanges(null, null, new AccessCondition(), blobRequestOptions);
-            pageRanges.OrderBy(range => range.StartOffset);
+            pageRanges = pageRanges.OrderBy(range => range.StartOffset);
             return pageRanges.Select(pr => new IndexRange(pr.StartOffset, pr.EndOffset));
         }
 
diff --git a/src/Storage/Commands.Storage/Common/StorageCloudCmdletBase.cs b/src/Storage/Commands.Storage/Common/StorageCloudCmdletBase.cs
@@ -297,7 +297,7 @@ internal virtual bool TryGetStorageAccount(IAzureProfile profile, out string acc
             account = null;
             bool result = false;
             //Storage Context is empty and have already set the current storage account in subscription
-            if (Context == null && profile != null && profile.Context != null && profile.Context.Subscription != null && profile.Context.Subscription != null)
+            if (Context == null && profile != null && profile.Context != null && profile.Context.Subscription != null)
             {
                 account = profile.Context.Subscription.GetProperty(AzureSubscription.Property.StorageAccount);
                 result = !string.IsNullOrWhiteSpace(account);

Original file line number	Diff line number	Diff line change
`@@ -867,7 +867,7 @@ public CredentialInfo CreateCredential(string resourceGroupName, string automati`
`867`	`867`
`868`	`868`	`if (createdCredential == null \|\| createdCredential.StatusCode != HttpStatusCode.Created)`
`869`	`869`	`{`
`870`		`- new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Create",`
	`870`	`+ throw new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Create",`
`871`	`871`	`"credential", name, automationAccountName));`
`872`	`872`	`}`
`873`	`873`	`return new CredentialInfo(resourceGroupName, automationAccountName, createdCredential.Credential);`
`@@ -891,7 +891,7 @@ public CredentialInfo UpdateCredential(string resourceGroupName, string automati`
`891`	`891`
`892`	`892`	`if (credential == null \|\| credential.StatusCode != HttpStatusCode.OK)`
`893`	`893`	`{`
`894`		`- new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Update",`
	`894`	`+ throw new AzureAutomationOperationException(string.Format(Resources.AutomationOperationFailed, "Update",`
`895`	`895`	`"credential", name, automationAccountName));`
`896`	`896`	`}`
`897`	`897`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,6 @@ public override void ExecuteCmdlet()`
`90`	`90`	`throw new Exception(Resources.AzureBackupJobArguementException);`
`91`	`91`	`}`
`92`	`92`	`WriteDebug(Resources.SettingStartTime);`
`93`		`- From = new DateTime();`
`94`	`93`	`From = AzureBackupJobHelper.MinimumAllowedDate;`
`95`	`94`	`}`
`96`	`95`
`@@ -112,7 +111,6 @@ public override void ExecuteCmdlet()`
`112`	`111`	`else`
`113`	`112`	`{`
`114`	`113`	`WriteDebug(Resources.SettingEndTime);`
`115`		`- To = new DateTime();`
`116`	`114`	`To = AzureBackupJobHelper.MinimumAllowedDate;`
`117`	`115`	`}`
`118`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,6 @@ public override void ExecuteCmdlet()`
`96`	`96`	`{`
`97`	`97`	`if (!TimeOut.HasValue)`
`98`	`98`	`{`
`99`		`- TimeOut = new long();`
`100`	`99`	`TimeOut = Int64.MaxValue;`
`101`	`100`	`}`
`102`	`101`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ private static void Print(object obj, string name, string currentIndent, StringB`
`79`	`79`
`80`	`80`	`ICollection objAsCollection = obj as ICollection;`
`81`	`81`
`82`		`- propName.Replace(':', ' ');`
	`82`	`+ propName = propName.Replace(':', ' ');`
`83`	`83`	`if (!string.IsNullOrWhiteSpace(propName))`
`84`	`84`	`{`
`85`	`85`	`sb.AppendLine(propName);`
Original file line number	Diff line number	Diff line change
`@@ -162,61 +162,51 @@ private PSApplicationGateway CreateApplicationGateway()`
`162`	`162`
`163`	`163`	`if (this.GatewayIPConfigurations != null)`
`164`	`164`	`{`
`165`		`- applicationGateway.GatewayIPConfigurations = new List<PSApplicationGatewayIPConfiguration>();`
`166`	`165`	`applicationGateway.GatewayIPConfigurations = this.GatewayIPConfigurations;`
`167`	`166`	`}`
`168`	`167`
`169`	`168`	`if (this.SslCertificates != null)`
`170`	`169`	`{`
`171`		`- applicationGateway.SslCertificates = new List<PSApplicationGatewaySslCertificate>();`
`172`	`170`	`applicationGateway.SslCertificates = this.SslCertificates;`
`173`	`171`	`}`
`174`	`172`
`175`	`173`	`if (this.FrontendIPConfigurations != null)`
`176`	`174`	`{`
`177`		`- applicationGateway.FrontendIPConfigurations = new List<PSApplicationGatewayFrontendIPConfiguration>();`
`178`	`175`	`applicationGateway.FrontendIPConfigurations = this.FrontendIPConfigurations;`
`179`	`176`	`}`
`180`	`177`
`181`	`178`	`if (this.FrontendPorts != null)`
`182`	`179`	`{`
`183`		`- applicationGateway.FrontendPorts = new List<PSApplicationGatewayFrontendPort>();`
`184`	`180`	`applicationGateway.FrontendPorts = this.FrontendPorts;`
`185`	`181`	`}`
`186`	`182`
`187`	`183`	`if (this.Probes != null)`
`188`	`184`	`{`
`189`		`- applicationGateway.Probes = new List<PSApplicationGatewayProbe>();`
`190`	`185`	`applicationGateway.Probes = this.Probes;`
`191`	`186`	`}`
`192`	`187`
`193`	`188`	`if (this.BackendAddressPools != null)`
`194`	`189`	`{`
`195`		`- applicationGateway.BackendAddressPools = new List<PSApplicationGatewayBackendAddressPool>();`
`196`	`190`	`applicationGateway.BackendAddressPools = this.BackendAddressPools;`
`197`	`191`	`}`
`198`	`192`
`199`	`193`	`if (this.BackendHttpSettingsCollection != null)`
`200`	`194`	`{`
`201`		`- applicationGateway.BackendHttpSettingsCollection = new List<PSApplicationGatewayBackendHttpSettings>();`
`202`	`195`	`applicationGateway.BackendHttpSettingsCollection = this.BackendHttpSettingsCollection;`
`203`	`196`	`}`
`204`	`197`
`205`	`198`	`if (this.HttpListeners != null)`
`206`	`199`	`{`
`207`		`- applicationGateway.HttpListeners = new List<PSApplicationGatewayHttpListener>();`
`208`	`200`	`applicationGateway.HttpListeners = this.HttpListeners;`
`209`	`201`	`}`
`210`	`202`
`211`	`203`	`if (this.UrlPathMaps != null)`
`212`	`204`	`{`
`213`		`- applicationGateway.UrlPathMaps = new List<PSApplicationGatewayUrlPathMap>();`
`214`	`205`	`applicationGateway.UrlPathMaps = this.UrlPathMaps;`
`215`	`206`	`}`
`216`	`207`
`217`	`208`	`if (this.RequestRoutingRules != null)`
`218`	`209`	`{`
`219`		`- applicationGateway.RequestRoutingRules = new List<PSApplicationGatewayRequestRoutingRule>();`
`220`	`210`	`applicationGateway.RequestRoutingRules = this.RequestRoutingRules;`
`221`	`211`	`}`
`222`	`212`
Original file line number	Diff line number	Diff line change
`@@ -161,9 +161,7 @@ private PSExpressRouteCircuit CreateExpressRouteCircuit()`
`161`	`161`	`circuit.ServiceProviderProperties.BandwidthInMbps = this.BandwidthInMbps;`
`162`	`162`	`}`
`163`	`163`
`164`		`- circuit.Peerings = new List<PSPeering>();`
`165`	`164`	`circuit.Peerings = this.Peering;`
`166`		`- circuit.Authorizations = new List<PSExpressRouteCircuitAuthorization>();`
`167`	`165`	`circuit.Authorizations = this.Authorization;`
`168`	`166`	`circuit.AllowClassicOperations = this.AllowClassicOperations;`
`169`	`167`
Original file line number	Diff line number	Diff line change
`@@ -130,37 +130,31 @@ private PSLoadBalancer CreateLoadBalancer()`
`130`	`130`
`131`	`131`	`if (this.FrontendIpConfiguration != null)`
`132`	`132`	`{`
`133`		`- loadBalancer.FrontendIpConfigurations = new List<PSFrontendIPConfiguration>();`
`134`	`133`	`loadBalancer.FrontendIpConfigurations = this.FrontendIpConfiguration;`
`135`	`134`	`}`
`136`	`135`
`137`	`136`	`if (this.BackendAddressPool != null)`
`138`	`137`	`{`
`139`		`- loadBalancer.BackendAddressPools = new List<PSBackendAddressPool>();`
`140`	`138`	`loadBalancer.BackendAddressPools = this.BackendAddressPool;`
`141`	`139`	`}`
`142`	`140`
`143`	`141`	`if (this.Probe != null)`
`144`	`142`	`{`
`145`		`- loadBalancer.Probes = new List<PSProbe>();`
`146`	`143`	`loadBalancer.Probes = this.Probe;`
`147`	`144`	`}`
`148`	`145`
`149`	`146`	`if (this.InboundNatRule != null)`
`150`	`147`	`{`
`151`		`- loadBalancer.InboundNatRules = new List<PSInboundNatRule>();`
`152`	`148`	`loadBalancer.InboundNatRules = this.InboundNatRule;`
`153`	`149`	`}`
`154`	`150`
`155`	`151`	`if (this.LoadBalancingRule != null)`
`156`	`152`	`{`
`157`		`- loadBalancer.LoadBalancingRules = new List<PSLoadBalancingRule>();`
`158`	`153`	`loadBalancer.LoadBalancingRules = this.LoadBalancingRule;`
`159`	`154`	`}`
`160`	`155`
`161`	`156`	`if (this.InboundNatPool != null)`
`162`	`157`	`{`
`163`		`- loadBalancer.InboundNatPools = new List<PSInboundNatPool>();`
`164`	`158`	`loadBalancer.InboundNatPools = this.InboundNatPool;`
`165`	`159`	`}`
`166`	`160`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,6 @@ private PSVirtualNetwork CreateVirtualNetwork()`
`118`	`118`	`vnet.DhcpOptions.DnsServers = this.DnsServer;`
`119`	`119`	`}`
`120`	`120`
`121`		`- vnet.Subnets = new List<PSSubnet>();`
`122`	`121`	`vnet.Subnets = this.Subnet;`
`123`	`122`
`124`	`123`	`// Map to the sdk object`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,6 @@ private PSVirtualNetworkGateway CreateVirtualNetworkGateway()`
`176`	`176`
`177`	`177`	`if (this.IpConfigurations != null)`
`178`	`178`	`{`
`179`		`- vnetGateway.IpConfigurations = new List<PSVirtualNetworkGatewayIpConfiguration>();`
`180`	`179`	`vnetGateway.IpConfigurations = this.IpConfigurations;`
`181`	`180`	`}`
`182`	`181`
Original file line number	Diff line number	Diff line change
`@@ -351,13 +351,11 @@ private List<DeploymentOperation> GetNewOperations(List<DeploymentOperation> old`
`351`	`351`	`Enum.TryParse<HttpStatusCode>(operation.Properties.StatusCode, out statusCode);`
`352`	`352`	`if (!statusCode.IsClientFailureRequest())`
`353`	`353`	`{`
`354`		`- List<DeploymentOperation> newNestedOperations = new List<DeploymentOperation>();`
`355`		`-`
`356`	`354`	`var result = ResourceManagementClient.DeploymentOperations.List(`
`357`	`355`	`resourceGroupName: ResourceIdUtility.GetResourceGroupName(operation.Properties.TargetResource.Id),`
`358`	`356`	`deploymentName: operation.Properties.TargetResource.ResourceName);`
`359`	`357`
`360`		`- newNestedOperations = GetNewOperations(operations, result);`
	`358`	`+ List<DeploymentOperation> newNestedOperations = GetNewOperations(operations, result);`
`361`	`359`
`362`	`360`	`foreach (DeploymentOperation op in newNestedOperations)`
`363`	`361`	`{`