Skip to content

Commit 37de9fe

Browse files
authored
Merge pull request #6842 from vermashi/ade-get-status-fix
Fix for the Get-AzureRmVMDiskEncryptionStatus cmdlet
2 parents c0dc48c + 16a6ca3 commit 37de9fe

File tree

7 files changed

+370
-336
lines changed

7 files changed

+370
-336
lines changed

src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineExtensionTests.ps1

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1052,7 +1052,7 @@ function Test-AzureDiskEncryptionExtensionSinglePass
10521052
$status = Get-AzureRmVmDiskEncryptionStatus -ResourceGroupName $vm.ResourceGroupName -VMName $vm.Name
10531053
Assert-NotNull $status
10541054
Assert-AreEqual $status.OsVolumeEncrypted Encrypted
1055-
Assert-AreEqual $status.DataVolumesEncrypted Unknown
1055+
Assert-AreEqual $status.DataVolumesEncrypted NoDiskFound
10561056

10571057
# verify encryption settings
10581058
$settings = $status.OsVolumeEncryptionSettings
@@ -1091,6 +1091,7 @@ function Test-AzureDiskEncryptionExtensionSinglePassDisableAndRemove
10911091
$status = Get-AzureRmVmDiskEncryptionStatus -ResourceGroupName $vm.ResourceGroupName -VMName $vm.Name
10921092
Assert-NotNull $status
10931093
Assert-AreEqual $status.OsVolumeEncrypted Encrypted
1094+
Assert-AreEqual $status.DataVolumesEncrypted NoDiskFound
10941095

10951096
# disable encryption
10961097
$status = Disable-AzureRmVmDiskEncryption -ResourceGroupName $vm.ResourceGroupName -VMName $vm.Name
@@ -1100,6 +1101,7 @@ function Test-AzureDiskEncryptionExtensionSinglePassDisableAndRemove
11001101
$status = Get-AzureRmVmDiskEncryptionStatus -ResourceGroupName $vm.ResourceGroupName -VMName $vm.Name
11011102
Assert-NotNull $status
11021103
Assert-AreEqual $status.OsVolumeEncrypted NotEncrypted
1104+
Assert-AreEqual $status.DataVolumesEncrypted NoDiskFound
11031105

11041106
# remove extension
11051107
$status = Remove-AzureRmVmDiskEncryptionExtension -ResourceGroupName $vm.ResourceGroupName -VMName $vm.Name

src/ResourceManager/Compute/Commands.Compute/ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
* Updated all help files to include full parameter types and correct input/output types.
3535
* Update description for Set-AzureRmVMOSDisk
3636
* Update Example 1 for Set-AzureRmVMBginfoExtension to correct spelling and prefix.
37+
* Fix Get-AzureRmVMDiskEncryptionStatus cmdlet for certain singlepass related scenarios
3738

3839
## Version 5.3.0
3940
* Add -Tag parameter to Update/New-AzureRmAvailabilitySet

src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@
153153
<Compile Include="Extension\AzureDiskEncryption\AzureDiskEncryptionExtensionContext.cs" />
154154
<Compile Include="Extension\AzureDiskEncryption\AzureDiskEncryptionExtensionProtectedSettings.cs" />
155155
<Compile Include="Extension\AzureDiskEncryption\AzureDiskEncryptionExtensionPublicSettings.cs" />
156+
<Compile Include="Extension\AzureDiskEncryption\AzureDiskEncryptionMode.cs" />
156157
<Compile Include="Extension\AzureDiskEncryption\DisableAzureDiskEncryption.cs" />
157158
<Compile Include="Extension\AzureDiskEncryption\GetAzureDiskEncryptionStatus.cs" />
158-
<Compile Include="Extension\AzureDiskEncryption\OSType.cs" />
159159
<Compile Include="Extension\AzureDiskEncryption\RemoveAzureDiskEncryptionExtension.cs" />
160160
<Compile Include="Extension\AzureDiskEncryption\SetAzureDiskEncryptionExtension.cs" />
161161
<Compile Include="Extension\AzureVMBackup\AzureVMBackupExtensionUtil.cs" />
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
using Microsoft.Azure.Management.Compute.Models;
2+
using System;
3+
using System.Collections.Generic;
4+
using System.Linq;
5+
using System.Text;
6+
using System.Threading.Tasks;
7+
8+
namespace Microsoft.Azure.Commands.Compute.Extension.AzureDiskEncryption
9+
{
10+
enum AzureDiskEncryptionMode
11+
{
12+
SinglePass,
13+
DualPass,
14+
None
15+
}
16+
}

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/GetAzureDiskEncryptionStatus.cs

Lines changed: 347 additions & 304 deletions
Large diffs are not rendered by default.

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/OSType.cs

Lines changed: 0 additions & 29 deletions
This file was deleted.

src/ResourceManager/Compute/Commands.Compute/Models/AzureDiskEncryptionStatusContext.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ enum EncryptionStatus
2525
DecryptionInProgress,
2626
EncryptionInProgress,
2727
VMRestartPending,
28-
Unknown
28+
Unknown,
29+
NoDiskFound
2930
}
3031

3132
class AzureDiskEncryptionStatusContext

0 commit comments

Comments
 (0)